Comments (3)
Yeah, it's really confusing what the difference between them is, and worse, I don't think the tests do a good job of asserting that they do the things specific to them (why is it a stateError and not a stateChangeError to navigate to a nonexistent state?).
A couple things:
- is there any real distinction to be found?
- Is it notable that some error events only happen between state changes starting and ending? I think that might be the current logic. Maybe this could be indicated by just a boolean between state changes.
- how significant is the difference between an error happening in a user-land function (like the provided
activate
function, or event handlers) and some other error happening (not able to turn a state name into a route whengo
is called or not being able to find a matching state whenevaluateCurrentRoute
is called)
- are any of these state routing issues serious enough to emit actual
error
events?
from abstract-state-router.
current stateError
events:
abstract-state-router/index.js
Line 176 in f598319
stateChangeAttempt
listener threw an error. This should probably just be thrown in another tick instead of being emitted as a state-router error.
Same for
abstract-state-router/index.js
Line 288 in f598319
For
abstract-state-router/index.js
Line 331 in f598319
evaluateCurrentRoute
, the only place I see that could be causing that error would be if prototypalStateHolder.guaranteeAllStatesExist
threw, which means that someone tried to navigate to a state that doesn't exist.
Maybe that should just throw straight out as well? It seems like a different kind of "not found" than the traditional one I'd imagine existing, which would be "there was no matching route for the url in the location bar".
from abstract-state-router.
I would expect to be directed to the hashBrownRouter.setDefault
(404) state if the state doesn't exist.
If there wasn't a hash, I would expect to go to the fallbackState
.
If I call state.go('this.route.does.not.exist')
, I would expect to have an error thrown.
from abstract-state-router.
Related Issues (20)
- Ignore parameters that are not used by any state HOT 3
- No way for children to depend on route parameters of ancestors HOT 2
- Eliminate references to node modules HOT 2
- Need to allow for adding custom hash fragments HOT 1
- When using root path '/' the page doesn't render on refresh HOT 9
- Why doesn't it scroll to the top when you navigate between states HOT 1
- Proposal to implement empty state HOT 4
- When using pushState routing, encodeURI should be used instead of encodeURIComponent
- Reloading current route HOT 22
- A dot/period(.) in url for a named parameter returns an error HOT 3
- Adding multiple keyed templates for a state HOT 6
- Possible to send actual objects via callback.redirect? HOT 10
- Push state routing not working with "defaultChild state with an empty route string" HOT 1
- It is possible for `makePath` to return a url that will not be matched by the router
- Non-async resolve results in confusing behavior HOT 1
- Lazy-loading states HOT 3
- State name should be optional to `state.go` HOT 4
- Get browserstack tests passing again HOT 1
- Modern JS features HOT 5
- Default values for route parameters HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abstract-state-router.