Code Monkey home page Code Monkey logo

Comments (4)

daytonlowell avatar daytonlowell commented on June 3, 2024 2

I've created 3 failing tests for this in my branch

The last one, 'calling redirect with no stateName in resolve should use current state', has an issue where the 'second' state never gets called.

from abstract-state-router.

TehShrike avatar TehShrike commented on June 3, 2024

The tests should be good now (I added route strings). I pushed them up to https://github.com/TehShrike/abstract-state-router/tree/83-null-state-name-passed-to-go-function

from abstract-state-router.

TehShrike avatar TehShrike commented on June 3, 2024

I think that the "current state" should be the one that you're transitioning to. That way if you pass in null to the redirect function inside a resolve, you will be going to that same state instead of the state before.

This behavior is asserted by the third test @daytonlowell wrote, so as soon as those new tests are passing and the docs are updated then the feature should be good to go.

from abstract-state-router.

TehShrike avatar TehShrike commented on June 3, 2024

Published as 5.13.0

from abstract-state-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.