teddriggs / fql Goto Github PK

An incomplete infix expression currently doesn't produce an error about the missing right-hand side.

Observed Output

[email protected]
  [email protected]
    [email protected]
      [email protected]
        [email protected] "host"
        [email protected] "."
        [email protected] "online"
      [email protected] ":"
      [email protected]
        [email protected]
          [email protected] "true"
    [email protected] "+"

This test documents the current behavior, and will need to be updated.

Goal: Have something akin to syn::Lit and support Operand::lit(&self) -> Option<Lit>.

Right now, literals are represented by single tokens, and it's unclear how to create AST node wrappers for those. Just using ast_node doesn't work, because Rowan doesn't consider these nodes.

A query such as "host.online:true--" should produce errors on the two trailing - characters. Ideally, the error would indicate that we expected one of + or ,.

This will need to take into account the parser's RECOVERY_SET. Given the expression (host:)+host.online:true, the correct parse is:

[email protected]
  [email protected]
    [email protected]
      [email protected] "("
      [email protected]
        [email protected]
          [email protected] "host"
        [email protected] ":"
      [email protected] ")"
    [email protected] "+"
    [email protected]
      [email protected]
        [email protected] "host"
        [email protected] "."
        [email protected] "online"
      [email protected] ":"
      [email protected]
        [email protected]
          [email protected] "true"

At 6..7, expected '!', '>', '<', '>=', '<=', '~', '!~', '[', boolean, string, or integer, found ')'

However, the RECOVERY_SET currently means that trying to create errors for trailing characters enters an infinite loop for this input: host.online:true).