tecsiaron / anaf-api-client-php Goto Github PK

Hey,

Thanks for the work on this library so far. I was thinking of refactoring the loading of the token logic, but wanted to run it by you first. What do you think of:

• making LoadAccessToken private and calling it from the constructor
• moving the refresh token check from HasToken to LoadAccessToken
• setting the AccessToken in the LoadAccessToken and the SaveAccessToken
• in HasToken just check if AccessToken is not null
• making the SaveAccessToken private and call it also from GetAccessToken
• making $authCode optional for GetAccessToken in which case it would just return the current AccessToken

• All response classes should extend/implement ANAFAPIResponse
• ANAFAPIResponse should declate Throwable|null $LastException
• ANAFAPIClient should set LastExeception where an Error response is created from a catch block