tclindner / eslint-config-tc Goto Github PK

https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/prefer-spy-on.md

https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/prefer-hooks-on-top.md

Not sure we should do this, but I've seen a few repos doing it and it seems like it might be valuable for us. Would need to tweak the extension.

'import/no-extraneous-dependencies': ['error', {devDependencies: ['**/test/*.ts'], peerDependencies: false}],

I saw that eslint-config-airbnb-base has been updated to support eslint 7. What other dependencies do we need to see updated before we take the plunge?

Please see https://eslint.org/docs/rules/no-promise-executor-return

See https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-large-snapshots.md

• Adds the other new "recommended" rules from v24 (why don't we just use their recommendations?)

Right now we do everything in overrides, which don't support extends. We can add the jest rules so they apply to all files. What do you think?

Yea that's fine. Just seems like unnecessary maintenance.

Originally posted by @pohnemus in #219 (comment)

Tasks

• Add Jest recommended (plugin:jest/recommended) config to extends section. See https://www.npmjs.com/package/eslint-plugin-jest#recommended
• Remove all jest/* rules from overrides - https://github.com/tclindner/eslint-config-tc/blob/master/index.js#L41
• Move the following rules to a new jest file in the rules directory. jest/no-alias-methods, jest/no-duplicate-hooks, jest/no-if, jest/no-large-snapshots, jest/no-test-return-statement, jest/prefer-called-with, jest/prefer-hooks-on-top, jest/prefer-strict-equal, jest/prefer-to-be-null, jest/prefer-to-be-undefined, jest/prefer-to-contain, jest/prefer-to-have-length, jest/prefer-todo, jest/require-to-throw-message, and jest/require-top-level-describe.

Please see https://eslint.org/docs/rules/no-setter-return

https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/prefer-called-with.md

https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/require-top-level-describe.md

I'd like to add this to our config - https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-ternary.md

Please see https://eslint.org/docs/rules/prefer-exponentiation-operator

Link to docs: https://eslint.org/docs/rules/require-atomic-updates

https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/prefer-expect-assertions.md

Release notes | Migration guide

Dependencies

• airbnb/javascript#2478
• sindresorhus/eslint-plugin-unicorn#1486
• jest-community/eslint-plugin-jest#881
• mysticatea/eslint-plugin-eslint-comments#62
• prettier/eslint-config-prettier#200

Update eslint-config-prettier to v7.x.x.

Update config to extend:

• prettier/unicorn

Please see https://eslint.org/docs/rules/no-constructor-return

Pre-reqs - peer dependencies that need to add support:

• Airbnb, eslint-config-airbnb-base

https://github.com/sindresorhus/eslint-plugin-unicorn/releases/tag/v24.0.0

• Add new rules.
• Update peerDeps on current version before releasing a new major version. https://github.com/tclindner/eslint-config-tc/releases/tag/v16.4.0

https://github.com/sindresorhus/eslint-plugin-unicorn#recommended-config

https://eslint.org/docs/rules/no-async-promise-executor

Please see https://eslint.org/docs/rules/grouped-accessor-pairs

https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/expect-expect.md

Please see https://eslint.org/docs/rules/no-unreachable-loop

Please see https://eslint.org/blog/2020/07/eslint-v7.5.0-released#optional-chaining-support

Remove jest and mocha environments from config

env: {
  jest: true,
  mocha: true,
},

See https://eslint.org/docs/user-guide/configuring#specifying-environments
In our code: https://github.com/tclindner/eslint-config-tc/blob/master/index.js#L37

This aligns with Jest's long-term direction. Please see:
https://jestjs.io/blog/2020/05/05/jest-26#a-new-way-to-consume-jest---jestglobals