expensive Packet::push; have 12 wanted 14 about fastclick HOT 4 CLOSED

InfiniteSource uses a larger default packet headroom when it creates the packet. It is also configurable. Where RatedSource uses a smaller header size which ends up as less than the space needed by your two encap elements. The end result is Click will then have to reallocate the packet memory to cater for the packet size, hence the "expensive push" warning.

Everything should work, it just warns about the additional memory allocation and copy.

RatedSource could be updated to also accept a header argument maybe?

from fastclick.

Thanks Beyers,

I could work on a handler for that, however there is a note about click-align. I don't know what click-align is used for.

Perhaps L255-L256 can be substituted with the following

from fastclick.

Click-align ensures that access to bytes of the packet are always on the architecture word size boundary by introducing "Align" elements here and there. I doubt anyone is still using an arch where accessing un-aligned bytes is more costly than moving the whole packets multiple times in memory, though... @pallas ?

I think you can safely also use default_headroom here. And making it a configuration option still allows people to revert to the normal behavior.

from fastclick.

Thanks guys, the warning now disappeared.
#133

from fastclick.