Code Monkey home page Code Monkey logo

Comments (5)

jpalawaga avatar jpalawaga commented on June 11, 2024 1

thanks for taking the time to respond!

from work.

taylorchu avatar taylorchu commented on June 11, 2024

Could you explain "not really compatible with long-running jobs/heartbeating"?

The intended usage is that we set a long timeout for context timeout, and in heartbeater it will periodically extend a short lease while the job is running.

from work.

jpalawaga avatar jpalawaga commented on June 11, 2024

Ah. that actually makes sense. I guess the way I was thinking about it was, either I want a deterministic maximum execution time, or I want no maximum. Picking some arbitrarily long maximum never occurred to me, but looking at the code, it is fine to use it exactly as you describe.

from work.

taylorchu avatar taylorchu commented on June 11, 2024

np!

from work.

jpalawaga avatar jpalawaga commented on June 11, 2024

I did encounter a bug that had me revert to my branch w/ context cancelation removed: if a job dies with a long expiry, it could stay invisible for a long time if the heartbeat hasn't had a chance to fire.

This means that long-running jobs that get killed shortly into their lifespan could sit idle for quite some time.

Not really sure what the solve is. This was causing a mysterious "where did my job go? lol" phenomenon.

from work.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.