Job's MaxExecutionTime option does not work about work HOT 4 CLOSED

this will stop the command after deadline is exceeded. do you mean supporting context in handler?

from work.

You are correct, missed that part when reading the code.

However, it is confusing because I assume that the worker will take care of the context's deadline because that is what the job option MaxExecutionTime implies, no? Aka the job has max execution time.

What do you think about following logic instead:

• after job has been dequeued and if job's MaxExecutionTime is not nil and greater than 0, then create timeout context with the option's duration value in the worker's loop
• call handle
• if context's <-ctx.Done() gets triggered before handle returns, then that job must be cancelled and retried with backoff

In that way, you do not have to define context.WithTimeout in job.

from work.

cancellation requires subfunctions to respect context timeout, and exit themselves, so we cannot do exactly what you said. but we could change the handler function signature to support it in the next major version.

from work.

done in #41

from work.