taoqf / javascript-state-machine Goto Github PK

Can anyone help me with that:

var FSM = StateMachine.factory({
  init: 'A',
  transitions: [{
    name: 'step',
    from: 'A',
    to: 'B'
  }, {
    name: 'step',
    from: 'B',
    to: 'C'
  }]
});

var fsm1 = new FSM();
fsm1.goto('B');

I'm getting the following error:
fsm1.goto('B');
^
TypeError: fsm1.goto is not a function

$ node -v
$ v8.2.0

According to the docs, the following behavior is incorrect: when the onBeforeTransition function returns a Promise which resolves with false, I would expect that the state transition fails. However that's not the case, it continues and calls onEnterState.

What I noticed is that:
a. If the onBeforeTransition method is sync and returns false synchronously, then it behaves as expected and the state transition is canceled.
b. If the onBeforeTransition method is async and returns a rejected promise, then it also behaves as expected and the state transition is canceled.

Are the docs incorrect maybe? Or is it a bug?

@taoqf/javascript-state-machine is found and imported successfully
but @taoqf/javascript-state-machine/lib/visualize cannot be found

Something looks bad in the minified script which is the entry point of the lib.

I'm using
"react-app-rewired": "^1.5.2",
"react-scripts-ts": "^2.17.0",
webpack "3.8.1"

The problem occures with dev server and production build as well. Do you have any idea what's wrong?
I suspect that setting the main to "dist/state-machine.min.js" might not be a good idea, the original lib has "lib/state-machine.js". Perhaps the double uglification causes a mess. What do you think?

Hi. I've installed this module under existing TypeScript project, because the upstream one still doesn't have v3 type definitions as far as I understand. However, the types/state-machine.d.ts is throwing a bunch of errors in my VSCode IDE (see attached). Am I missing anything?

declare class StateMachine {
	constructor(options: Partial<StateMachine.Options>);
	static factory(options: Partial<StateMachine.Options>): StateMachine.IFSM;
	static factory<T>(instance: T, options: Partial<StateMachine.Options>): StateMachine.IFSM | T;
	[action: string]: ((...args: any[]) => any);
	is: StateMachine.StateMachineIs;
	can: StateMachine.StateMachineCan;
	cannot: StateMachine.StateMachineCan;
	transitions: StateMachine.StateMachineTransitions;
	allTransitions: StateMachine.StateMachineTransitions;
	allStates: StateMachine.StateMachineStates;
	observe: StateMachine.Observe;
	// history: string[];
	clearHistory(): void;
	historyBack(): void;
	historyForward(): void;
	canHistory(): boolean;
	canhistoryForward(): boolean;
}

我扩展了这个状态机类，但是需要用到 state 属性，在 js 中是有的，但是TS中没有定义，可以添加一个吗？

In Typescript 4.1, following line causes an issue
https://github.com/taoqf/javascript-state-machine/blob/master/types/state-machine.d.ts#L5

When calling from code stateMachine[transition](), following error is returned by TS
"Not all constituents of type 'string | string[] | ((...args: any[]) => any)' are callable.
Type 'string' has no call signatures."