taoning2014 / srt-validator Goto Github PK

Make the PR workflow to be mandatory, banned push code directly to the master branch.

Is your feature request related to a problem? Please describe.
In some cases only the first error found is returned

Describe the solution you'd like
I would like the result to return an array of all errors found

Describe alternatives you've considered
None yet

Additional context
sample A
The response of the validator only returns the first error found on lineNumber 6.
Other errors are not returned (e.g. line 10, line 14).

When I fix the timestamps on these lines (6, 10, 14), see sample B and validate again. I do get an array of 4 errors found :). (line 5, 9, 10, 13).

To me it seems sample A should also return all errors found, instead of 1.

-- sample A
1
00:00:00,890 --> 00:00:02,500
aa

200
00:00:02,890 --> 00:00:04,500123
bb

2
00:00:00,890 --> 00:00:02,500test
cc

2
00:00:02,890broken --> 00:00:04,500
dd

-- sample B
1
00:00:00,890 --> 00:00:02,500
aa

200
00:00:02,890 --> 00:00:04,500
bb

2
00:00:00,890 --> 00:00:02,500
cc

2
00:00:02,890 --> 00:00:04,500
dd

For details, please refer to the advance usage section of this article

This repo defines a Github action that publishes each commit as a new version to npm. Due to npm needing a new version number on publishing from package.json, currently, it requires the developer to bump the package version manually in order to make the publishing successful(one example failure without npm version bump).

Add a post-merge commit to bump version automatically.

Type definitions are not being included in the package published to npm.

Describe the bug
When calling using import srtValidator from 'srt-validator', the package cannot be resolved. It can be when I use import srtValidator from 'srt-validator/src' but got this:

/home/fsevenm/works/tictag-io/backend/api-application/node_modules/srt-validator/src/index.js:1
import SRTParser from './parser';
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at wrapSafe (internal/modules/cjs/loader.js:1070:16)
    at Module._compile (internal/modules/cjs/loader.js:1120:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1176:10)
    at Module.load (internal/modules/cjs/loader.js:1000:32)
    at Function.Module._load (internal/modules/cjs/loader.js:899:14)
    at Module.require (internal/modules/cjs/loader.js:1042:19)
    at require (internal/modules/cjs/helpers.js:77:18)
...

To Reproduce
Steps to reproduce the behavior:

1. Call using import statement

Expected behavior
Should be resolved and work

Desktop (please complete the following information):

• OS: Ubuntu 21.10
• Node 12.16.2 using TypeScript

From their statement:

With everything from doorbells to rockets running on code, it's more important than ever to ensure quality code is being delivered with every release.

Code coverage is one of the most important metrics companies rely on to ship healthier code, faster, and with less risk.

Codecov gives companies actionable coverage insights when and where they need them to ensure they are shipping quality code.

After integration, add a code coverage badge on the readme file.