The utlapp's discuss from tanaikech

View Code? Open in Web Editor NEW

This is a Google Apps Script library including useful scripts for supporting to development of applications by Google Apps Script.

License: MIT License

JavaScript 100.00%

utlapp's Issues

Single Cell endRowIndex

Dear Tanaike, I use this script a lot in my work. thank you a ton!

Here's the issue I found:

Sample Code

function testApp() {
  var a1Notation = 'K1';
  var sheetId = 500;
  console.log(UtlApp.convA1NotationToGridRange(a1Notation, sheetId));
}

Output

{ sheetId: 500,
  startRowIndex: 0,
  endRowIndex: 1,
  startColumnIndex: 10,
  endColumnIndex: 1 }

Expected output

{ sheetId: 500,
  startRowIndex: 0,
  endRowIndex: 1,
  startColumnIndex: 10,
  endColumnIndex: 11 }

Steps to reproduce

Install the library
run sample code

Proposed solution

My guess is that it is a logical error in this line:

endColumnIndex: end ? end.col + 1 : 1,

I suggest to change it like this:

endColumnIndex: end ? end.col + 1 :start.col+1

If I did not understand the logics of grid creation, I'm sorry.

I also suggest to create a type for a grid like so for autocompletion purposes:

/**
 * @typedef {Object} RangeGrid
 * @property {Number} startRowIndex
 * @property {Number} endRowIndex
 * @property {Number} startColumnIndex
 * @property {Number} endColumnIndex
 */

 *
 * ...
 * @returns {RangeGrid} Gridrange.
 */
function convA1NotationToGridRange_(a1Notation, sheetName) {

Recommend Projects