tag-bio / umap-java Goto Github PK

Hey,

I really like this UMAP implementation. Unfortunately I have to clone the repo and build the maven artifact myself in order to integrate it into other projects. This is also preventing me to use it as a dependency in other maven projects as it cannot be downloaded from the central repository by the maven build tool.

Is it possible that you deploy the artifact to maven central (https://search.maven.org/)? I know that this process has a bit of an overhead when doing it for the first time, since you need to register for a maven group id that you will own ( com.github.tag-bio ). See details here https://central.sonatype.org/publish/ . I have been deploying java libraries to maven central before, so I could help in the process.

I think making this implementation available through the central repository would make it way more accessible and easy to use in software projects (would only require to add it as a dependency into the pom.xml file). It would also enable the use of different build systems like gradle, and build systems of other JVM languages e.g. scala-sbt (for Scala).

a simple workflow like:

git clone https://github.com/tag-bio/umap-java.git
cd umap-java
mvn install

does not work. It is failing on the tests in the tagbio.umap.Heyler10gbData class.

It appears that it is expecting the user to set three environment variables:
...
super( java.lang.System.getenv("TAGBIO_HEYLERTEST_10GB"));
...
super( java.lang.System.getenv("TAGBIO_HEYLERTEST_20GB"));
...
super( java.lang.System.getenv("TAGBIO_HEYLERTEST_30GB"));

With no description of what those are supposed to do.

Commenting out this file entirely builds as expected... Perhaps this should be someone's personal test, not a global test?