tabjy / container-jfr Goto Github PK

The HTTP server for container-web and the WebSocket server for command channel should be converted to use Vert.x framework. Optimally, they should use the same port and the same verticle.

Related to rh-jmc-team#6 and rh-jmc-team#9.

• UploadRecordingCommand.RecordingNotFoundException#RecordingNotFoundException(String) is missing formating argument recordingName

• ContainerJfr#main(String[]) has unused variable port

• TtyClientReader#scanner should use standard charset constant

• ExitCommand#execute contains trailing comma

• ContainerJfr's usage of Arrays.asList().stream() can be replaced with Arrays.stream()

• MainModule has unused import import com.redhat.rhjmc.containerjfr.net.NetworkModule;

• WaitForCommand can use String.repeat() instead of looping

• static modifier, final modifier and access modifier should not be used for interfaces:

  • PlatformDetectionStrategy
  • SerializableCommand

• Explicit type argument ListOutput<String> can be replaced with ListOutput<>

• Unnecessary return as the last statement in a void method

  • DeleteCommand
  • StopRecordingCommand

Currently, it's placed under /. It seems awkward that the application resource is not in a place relative to the application itself. Additionally, it leads to permission problems when running outside containers.