The i18n-number from t2ym

[Polymer 2.x][Edge 14][HTMLImports] Missing disconnect() method in MutationObserver

[Polymer 2.x][Edge 14][HTMLImports] missing disconnect() method in MutationObserver

Error Message from WCT

Windows 10 microsoftedge 14 Tests failed: Error thrown outside of test function: Object doesn't support property or method 'disconnect'
  A.prototype.disconnectedCallback at /components/webcomponentsjs/webcomponents-lite.js:145
                     A.prototype.a at /components/webcomponentsjs/webcomponents-lite.js:143
                Anonymous function at /components/webcomponentsjs/webcomponents-lite.js:42

Related Code in HTML Imports: `src/html-imports.js`

    processImportsIfLoadingDone() {
      // Wait until all resources are ready, then load import resources.
      if (this.inflight) {
        return;
      }

      // Stop observing, flatten & load resource, then restart observing <head>.
      this.dynamicImportsMO.disconnect();
      this.flatten(document);

The validity of the object this.dynamicImportsMO has not been tracked in debugger.
Not Reproducible on Edge 13

[4.0] Remove dependency on Polymer library

Status

Part of t2ym/i18n-element#63
WIP in 4.0-develop branch
NPM package
- npm install i18n-number@next or npm install [email protected]

Tasks

Design Issues

How to port notifyPath() feature from Polymer?
- Just call _onOptionsPropertyChanged()
Is reflectToAttribute feature required? No
root property for shadowRoot to imitate a Polymer element
Should attachShadow() be put off until the first rendering like i18n-format? Yes
- i18n-element tests fail with <plural-gender-element>
Should assignment of this.lang with the default value be put off until connectedCallback? Yes
Is importMeta property necessary? No.

Issues

document.createElement('i18n-number') fails with "The result must not have attributes"
- Fix: Put off setting this.lang in the constructor to the next microtask timing
- Fix: Add 'null' guards for lang property
lang attribute/property is unexpectedly set to "en"

window.t = document.createElement('template');
t.innerHTML = '<i18n-number id="overridden-lang" lang="fr">12.34</i18n-number>'
document.body.appendChild(t.content);
document.querySelector('i18n-number#overridden-lang').lang === 'fr' // must be true, actually false

Root Cause: lang has to be set at connectedCallback instead of the microtask timing after constructor

Intl polyfill throws Range Error on malformed extension languages

Intl polyfill throws Range Error on malformed extension languages like zh-Hans-CN-x

[3.0][webcomponents.org] Not property published on webcomponents.org

[3.0][demo] Build demo for static servers

Demo

Prerequisite for Building and Serving Demo

    npm install -g polymer-cli

On-the-fly Build

    # Serve at http://localhost:8080/components/i18n-number/demo/
    polymer serve --npm --module-resolution=node -p 8080

Static Builds

Build

    polymer build

Targets

target	browser	minify	bundled
build/esm-unbundled	es6,modules	no	no
build/esm-bundled	es6,modules	yes	yes
build/es6-bundled	es6	yes	yes
build/es5-bundled	es5	yes	yes

Serve

    # Serve at http://localhost:8080/
    cd build/{esm-unbundled|esm-bundled|es6-bundled|es5-bundled}
    python -m SimpleHTTPServer 8080 # or any HTTP(S) server

[3.0] this.textNode is incorrectly set if childNodes[0] is not a text node

[3.0] this.textNode is incorrectly set if childNodes[0] is not a text node

Root Cause

Checking for nodeType === TEXT_NODE is missing and childNodes[0] is hard-coded

Fix

Search for the first text node in childNodes

[3.0][webcomponents.org] Demo on webcomponents.org does not work

Demo link on webcomponents.org

https://www.webcomponents.org/element/t2ym/i18n-number/demo/demo/index.html
browsed from 3.0.0-pre.* version READMEs

Suspected Root Cause

Failing to load NPM modules as they are inexistent on the generated server environment

Fix

~~Use this link instead.~~ (not working well)
https://npm-demos.appspot.com/[email protected].*/demo/index.html
Use inline demos

Language fallback is unreliable in Intl.js locale module dynamic loading

Normalization, i.e., case sensitive URL path name generation of Intl.js locale data modules are too simple and unreliable.

For example, ZH-haNS-cn is incorrectly normalized to zh-HANS-CN, which results in file not found error and thus must be changed to zh-Hans-CN.

For language fallback, an inexistent locale ja-CA directly falls back to en instead of ja.

[3.0] Use _template property instead of <dom-module>

[3.0] Use _template property instead of <dom-module>

Root Cause

Older versions of polymer-modulizer converts <dom-module> as imperative attachment of the element instead of _template property

[Safari 7] lang property observer does not work

With Safari 7, lang property observer _langChanged() is not called on the value changes.

The root cause is the overridden lang property by Safari 7.

[test][Chrome][Firefox] zh-yue-Hans-CN, zh-CHS are treated as invalid locales

[test][Chrome][Firefox] zh-yue-Hans-CN, zh-CHS are treated as invalid locale

Root Cause

Intl.NumberFormat in Chrome and Firefox has been changed to reject rare locales like zh-yue-Hans-CN, zh-CHS

Fix

Avoid these locales in tests and use zh-CN instead

[Polymer 2.x][Safari 9] Failed to load Intl library

Root Cause:

At registered callback of 2.0-preview, this.resolveUrl() does not provide the correct URL.

[Polymer 2.x] Intl is not polyfilled

On Polymer 2.x, Intl object is not polyfilled due to the missing beforeRegister callback.

[3.0] Use this.importMeta for resolveUrl at the timing of registered callback

[3.0] Use this.importMeta for resolveUrl at the timing of registered callback

Notes

Until Polymer 2.x, this.importMeta is unavailable at the registered callback
On Polymer 3.x, this.importMeta is available but this.resolveUrl is unreliable at the registered callback

[Enhancement] Customize paths to Intl.js modules

Paths to Intl.js modules are currently hard-coded as ../intl/dist/Intl.min.js and ../intl/locale-data/jsonp/{locale}.js, which is inflexible and would be inconvenient if i18n-number.html and other modules are vulcanized.

A convenient and flexible method to customize the hard-coded paths to the modules like this is desired.

<meta name="intl-js-path" content="/dynamic-components/intl">

Possible Fix

Since new Intl.NumberFomrat is called with lang and options, observe these parameters and cache the new Intl.NumberFormat(lang, options) object for later usage
The expected reliable caching algorithm is not as simple as expected with performance in consideration.

Notes

Just calling .format() method is 100 times faster than instantiating Intl.NumberFormat on each call
The fix priority is low since <i18n-number> should not be used so heavily

t2ym / i18n-number Goto Github PK

i18n-number's Introduction

i18n-number's People

Contributors

Watchers

i18n-number's Issues

Error Message from WCT

Related Code in HTML Imports: src/html-imports.js

Status

Tasks

Design Issues

Issues

Demo

Prerequisite for Building and Serving Demo

On-the-fly Build

Static Builds

Root Cause

Fix

Demo link on webcomponents.org

Suspected Root Cause

Fix

Root Cause

Root Cause

Fix

Root Cause:

Notes

Possible Fix

Notes

Recommend Projects

Recommend Topics

Recommend Org

Related Code in HTML Imports: `src/html-imports.js`