Code Monkey home page Code Monkey logo

phonebook's Introduction

Phonebook

by T-Systems Multimedia Solutions GmbH

semantic-release Commitizen friendly GitHub issues GitHub GitHub

❓ What is the Phonebook?

The Phonebook is a community project for us, from us and everybody is welcome to participate. This Single-Page-Application is able to display People, Rooms and the organization structure. It is perfect to search for people in a company, get information where they sit in your building and how to contact them.

▶️ View the live demo on https://demo-phonebook.aquiver.de/.

👋 New to the Phonebook?

We are always searching for new contributors who want to be a part of a growing community. The contribution benefits are huge. You can learn a lot about the technologies displayed below, bring new ideas into the project, connect with new people from different departments and learn how it is to be an OpenSource-Developer.

You're not interested in developing and just want to know more about how to use the software? 🔰 Right this way

🔍 You want to be a part of this community?

You can contribute with any skill or use this project to evolve your techniques.

If you're not interested in developing but want to help you can submit new issues or contact one of the {{site.contributors}}.

If you're interested in developing check out the following links.

View some other examples to contribute
  • Review Pull Requests
  • Test the Application and suggest new enhancements or report new bugs
  • Design a cool Phonebook-Logo
  • Develop a new User-Centered Design
  • Provide Accessibility
  • Write a User-Guide

Note that you also can keep an eye on our good first issue-Badge. This Label shows that the issue can be perfect to dive into the project.

If you're a part of T-Systems MMS you can also take a look at the internal get-started page.

🔌 Technologie overview

The project makes use of the following noteworthy frameworks:

Frontend Frameworks
  • Angular: The popular JavaScript framework is the base of this application. We also use the Angular routing for navigation to different views.
  • Angular CLI: Makes development and the build process of the application much easier. It encapsulates the Webpack build configuration and provides some reasonable conventions to follow instead. The CLI also provides some convenient commands to generate new components, services, etc.
  • Angular Material: Provides components to build an application with Google's Material design. We use it as a basis for our graphical layout.
Backend Frameworks

🌎 The Community

✏️ Contributors ⚙️ Maintainer
Anyone who participates in any way to the community Voluntarily takes over the coordination of a work package, a milestone or a topic
This can be: develop new features, fix bugs, write documentation or review pull requests. Controls the contributors and supports the onboarding
Is responsible for the quality of the respective work package
Becomes visible as an expert

DanielHabenicht

💬 🐛 📝 💻 🖋 📖 🎨 🤔 🚇 🚧 📆 👀 🛡️ 🌍 ⚠️

Max S.

💻 🐛 📝 📖 🤔 🚧 📆 👀 🌍 💬

paule96

💻 🤔 🚧 👀

Marcus Krahl

👀 💬

Kirsten Kluge

💬 👀

GentleJames

💻

Julius T.

💻

PhoebeNgnfld

📖

schurzi

💻 🤔

René Kießig

💻 🤔

danielsy

💻 🤔

Oliver Guhr

💻 🤔

FrankLambrette

💻

Dominik Mangatter

💻

BrunoZirnstein

💻

friedaxvictoria

💻

Tom Frenzel

💻

And a big thanks to all other contributors of T-Systems MMS.

This project follows the all-contributors specification. Contributions of any kind welcome!

✨ Need Help?

If you still have questions feel free to contact us under [email protected].

💻 Supported Browsers

Browser Support Offline Capability Comment
Chrome ✔ Working ✔ Working
FireFox ✔ Working ✖ Not Working (activate in ESR via Feature Flag or available from Firefox 61 upwards) There might be a Bug.
Safari ✔ Working ✖ Not Supported yet Service Worker are not available yet: https://bugs.webkit.org/show_bug.cgi?id=174541
Edge ✔ Working ✖ Not Supported (available from Edge Version 17 upwards)

We do not support Internet Explorer.

📃 License

This project is licensed under the MIT License - see the LICENSE file for details

phonebook's People

Contributors

77772777244 avatar allcontributors[bot] avatar brunozirnstein avatar danielhabenicht avatar dependabot[bot] avatar dnlkllr avatar friedaxvictoria avatar j-c-o avatar jandd avatar mr-woodapple avatar mschwrdtnr avatar paule96 avatar phoebengnfld avatar renovate-bot avatar renovate[bot] avatar vanlampe avatar zeroks77 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

phonebook's Issues

Sort and filter don't work together

Reproduce:

  1. Search for something. e.g. name, telefon, organization unit.
  2. Try to sort the results . e.g. name

Problem:
The default-data will be sorted. After 3 clicks you will see the searched for data.

Expected:
It's possible to sort the filtered items.

Update the docs in the frontend source code

In the frontend source code, there is a docs folder with some information for developers to get started with this repo. But there are many missing pieces of information.

So the goal of this issue is to remove all TODO's in the .md files under docs.

bug(search): table show all users if a blank is after the name in searchbar

Describe the bug:
If you search for a name and you write a space after (to also type the surname) the table will show all filtered results and after that all other results.

To Reproduce:

  1. Type a name in the search bar e.g. Max -> you'll see xx results.
  2. Type a space after the name
  3. You'll see the filtered results and after that all other results. -> xxxx Results

Expected behavior:
There should be no difference between "Max" and "Max ".
There should not be shown other results than the expected from the search.

Add status/comment box to user profile

Is your feature request related to a problem? Please describe.
It happens sometimes that a user wants to inform others about room changes, other contact information or something like. On the current state it`s not possible to present a small status text in your profile like in Skype.

Describe the solution you'd like
It would be cool if a little box is under the profile picture where i can set a status persistent for all other users. I imagine something like it's present in Skype.

Additional context
Can not be done if the new backend is not live.

copyd from internal TFS (7506)

Optimization of Workflows

Reduce number of clicks for typical workflows:

  • f.e. add copy Button next to Mail/Phone
  • f.e. add dail Button next to Phone
    Enable copy and paste by selecting text by mouse in Buttons "mat-buttons"

bug(user): it's not possible to search for "München"

Describe the bug:
It's not possible to search for words with ü. It's also not possible to replace the word with ue.

To Reproduce:

  • Try to search for "München"
    -> No results
  • Try to search for "Muenchen"
    -> No results
  • ../search/?city=M%C3%BCnchen
    -> also no results

Expected behavior:
It should be possible to filter for "München"

Additional context:
The search is working with names but not with citys.

Make environment Tag Configurable

Status Quo:

There are 3 Environments specified: local, preview, production, they are activated by the domain name.
Theses Settings set a tag at the top of the page accordingly:
image

Should Be:

  • Make the tags fully configurable (free text).
  • add an environment flag for setting the mode of the application (local by default, preview, prod )
    • use these settings for configuring raven and maybe other stuff currently set by environment.production

Ignore diacritics in search

When searching for someone whose name contains a diacritic (e.g. the ´ in André) I have to type the diacritic.

Expected: For example when searching for Andre I also want to see all people named André

BUG: Costcenter heißt nun Profitcenter

Describe the bug:
Durch Klick auf mein Profil bzw. bei Anzeoige eines gesuchten Kollegen erschein u.a. hinter dem "$" Icon das Wort Costcenter.
Die Costcenter heißen nun Profitcenter: bitte daher um Umbenennung von Costcenter in Profitcenter

Expected behavior:
Wort Costcenter ist in Profitcenter umbenannt

Additional context:
Edge / Windows 10

From Ticket 7969

bug(user): User-Image have problems with delete/change (chrome)

Describe the bug:
If you want to change your user image or delete it the page won't show the change/delete. It also doesn't change if you restart the browser.
The problem only occur in Chrome!

The picture gets deleted from the picture endpoint and you can see the result in other browsers (firefox, edge).

To Reproduce:

  1. Go to "My Profile"
  2. Change/delete your Picture
  3. Reload the page

Expected behavior:
I can change/delete my profile image and the result is, that is

Additional context:
This issue was listed intern as BUG 8594.

Fix Opensearch.xml

It has to be in the root of the webpage, otherwise, it won't be detected.

Dashboard Redesign

Redesign the current Dashboard

  • Redesign user-small-card
  • Redesign user-tiny-card
  • Add Supervisor as Bookmark
  • Add Team Assistants as Bookmark
  • Add a small card with description "How to bookmark"

Write a User-Guide

Write a User-Guide for the Phonebook

The documentation is already prepared and only need to save in /pages/user-docs/

Make Environment Variables for the Frontend App Optional

Make Variables like

  • ROOMPLANNINGTOOL_URL
  • CONTACT_EMAIL
  • CONTACT_URL
  • RAVEN_URL

truly optional by removing them from the .sh script but also make the app deal with those variables if they are not supplied.

Update the Documentation Accordingly.

Bug(user): type a full name don't show results

Describe the bug:
When you type a full name in the searchbar there will not be shown any result.
The problem is not occurring in the live version. Maybe this bug is since #41 .

To Reproduce:

  1. Search for a name e.g. Max Schwerdtner
  2. You can't see a result.

Expected behavior:
I search for a name and got results.

Additional context:
The problem don't occur in the live version.

user: Automatically put focus on the search bar

When opening the phonebook, the search bar is not initially focused.
I need to click into the search bar before being able to type a search query.

Steps to reproduce:

  1. Open phonebook
  2. Start typing
  3. No text is entered in search bar

Does not work in Browsers:

  • FF 67.0.4

add service-worker

With Angular 8 finally multiple service worker on one domain are supported.

This should enable service worker for all languages.

  • Update nginx.conf to not ignore ngsw.json
  • Update ngsw.configs

enhance: only show Feature Flag Container if there are feature flags

Description
Add a Feature Flag Checker into settings.component.html. The code is provided here.

It's needed to add a function in settings.component.ts which checks if there are feature Flag container in the code.

The Idea is, that the code can still be implemented but only will show (*ngIf="function()" == true) if there are Feature Flag Containers in the Code (<ng-container *featureFlag="">)

Add Theme switcher

  • Make theme select persistent
  • Add Theme Enum for better type support.
  • Make Magenta the standard theme 😏
  • remove feature flag
  • Add Feature Description to notification dialog

Interactive Floorplan

Additional context
Should not work on until the new Backend is live.

Is your feature request related to a problem? Please describe.
The floorplans are hard coded and don't offer any interaction.
There are also some duplicates because the backend is offering bad information. So it's very hard to maintain the roomplans bc you need to change different files just for one floor.

Describe the solution you'd like

  • It's possible to click through all floors and rooms
  • You can see the members of the room
  • you can change between the view of all rooms and the view of meeting rooms.

Idea from @paule96: Also show the location of printers.

Bug(user): Notification-popup cut the text on small resolutions

Steps to reproduce:

  1. Open the Phonebook
  2. Delete the localStorage (if you already opened the site)
  3. Decrease your Browser-Window.

Actual behavior:
The text in the notification popup will be cut off if <mat-item> is used.

Screenshots:
Video

Expected behavior:
The user can see the full text on lower resolutions.

Other Information:
This problem happens on every dialog window.

Small Icon for all contributors

Added from Confluence "Idea-List"

Is your feature request related to a problem? Please describe.
It is not visible for phonebook users who is contributing to the project. The idea is that everyone who contributes to the project gets a small icon or batch.
-> This can have many positive effects. E.g. more people will contribute to the project because it is noticeable for others that you had contributed.

Describe the solution you'd like
A small icon or batch next to the user image. It's also possible to make different icon colors for the number of contributions or something like that.

Additional context
I am not sure if it's possible to release this feature without a mark in the backend. We can write the contributor names in a file and if the name of a user is in this file the icon will be added on load. But before that fwe need to ask for permission of the contributor because the file will be in the public repository.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.