Code Monkey home page Code Monkey logo

debounce-async's People

Contributors

szchenghuang avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

debounce-async's Issues

Throws error when cancelled

This lib is useful, but it throws a "cancelled" error when a debounced function is called multiple times. To work with node/browser promises, I would then need to "catch" this cancelled error..but in reality it should only throw if the promise returned by the debounced function throws.

debounce(() => {
    return new Promise((resolve, reject) => {
        // some logic here...
        resolve(); // should never throw an error

        // some more logic
        reject('Error message'); // this should throw
    });
});

Function is exported incorrectly

The actual function is exported to exports.default.
What this means is that when trying to "require" debounce, one has to either do

const {default: debounce} = require("debounce-async")

or

const debounce = require("debounce-async").default

Leading edge debounce doesn't work consistently

When configuring this library to use a leading edge debounce, things don't work consistently.

On each consecutive call the debounce is applied in an alternating leading, then trailing, then leading fashion.

That seems to be because invokeAtLeading never clears the latestResolve variable upon resolution:

function invokeAtLeading( args, resolve, reject ) {
func.apply( this, args ).then( resolve ).catch( reject )
shouldCancel = false
}

On every other call this condition is failing because latestResolve is still set:

if ( !latestResolve ) { // The first call since last invocation.

And the execution falls through to invokeAtTrailing even when latestResolve has long since been resolved.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.