If no comrade is registered i.e. all the 6 fields are blank, and the users clicks help me, a dialog box displays the message " This msg has been send to all registered comrades" . However no msg is sent to anybody, since there were no comrades registered and the user is unaware of this.

Hence it would be better if in such a case user is notified that no comrades are registered , hence no message was sent and that he should add comrades.

It would also be better if we displayed the exact number of comrades to whom msg has been sent e.g " This msg has been send to 3 registered comrades" instead of displaying "this msg has been send to all registered comrades".

Why are we not having Action Bar, menu here?
Instead of these, only simple Text is written at top of every activity with no Menu Options.

Will addition on these things be good?

We can make the application more responsive by adding sound effects at appropriate places.
E.g. the app will generate a alert beep if message sending fails after pressing help me. Similarly there can be a success beep if messages are sent successfully .
This will help the user in case he/she forgets to see the toast displayed after pressing Help Me button.

Circle of trust looks like this:

This could be made something like:

Can I submit a PR for this?

If a comrade contact number is left empty, then message sending is failed for all comrades after that comrade. Example if comrade 1's contact number is left empty as shown:

Then message is not send for comrades placed after comrade1 i.e 2,3,4,5,6 and failure message is dispalyed as shown.

Similarly if comrade 3 is empty and rest are filled, then message is only sent to comrade 1,2 and fails for comrade 4,5,6. In this case also a failure message is displyed.

I would like to fix this issue .

I wanted to implement get help now as shown in mockup.pdf, can I continue?

Along with the select request message phone call also can be made to the comrades
At a time six phone calls cannot be made so,
The phone calls can be made in order like comrade1 then comrade2 so on...(if one comrade doesn't lift then next comrade so on.....)

Idea : Suppose I press 'Help Me' then SMS sends to my comrades list.
Nowadays many person ignores SMS thinking of that they will read it later(Or doesn't give much effort to read a SMS).

Solution : What about if Comrade will have PCSA-Android app install in his/her phone, a Ring can be generated to notify user on receiving SMS sended by PCSA-Android.

The option icon here on the left of the page heading is useless, are there any options which are needed to be added by making it clickable?

If the user navigates to Reporting Process -> Reporting Types from the application, the horizontally scrollable view shows the same content twice.
See attached screenshots

The reporting types page looks like this on tablets:

This could be changed to something like -

Can I go ahead and send a PR?

The text seems very unclear at the moment
Maybe we could change the color of the text

Current Implementation

As in mockup

Updates required :

1. Change button borders to black
2. Add a line divider below "Get Help Now" and above "Other Staff and ... "
3. Clean up the UI as in Mockup
4. Maybe have another arrow pointing to the left which will lead us back to the ContactPostStaffActivity

I am using my Nexus 5 and it looks slightly pushed to the left.

Over in the CircleOfTrustFragment.java, I noticed that we have used harcoded strings for switch case.

I suggest we should put these constant values in a static class. This way we can reuse the same information later as well.

Let me know if this is a welcome change. If yes, I will send a pull request for the same.

Thanks,
Harshita

The launcher image of the application seems rather small in size when compared to the other apps. I would like to create a new launcher icon using Photoshop or equivalent tools.

When the comrade icon is clicked the phonenumber and possibly name can be displayed

Just a suggestion :)
It would be helpful if comrade name is also stored with the number , and on clicking on any comrade a pop up window shows the description of comrade

Enabling and redirecting to gmail (or yahoo) with recievers email in it
Body can be added by user and mail sent

There is an option to contact Office of General Inspector in the Other Staff option. On this page, there is a link given to learn more.

The link is currently inactive.The link would serve useful if clicking on it opens up the destination page on our web browser, so that the users can get more information if they wish to. There will be no UI added and no existing UI will be changed, just an enhancement added.

@sandarumk I went through the mockup provided and would like to implement the reporting steps page in the way described. Should I start working on that?

When Application is asking for permission, if we denied it now or maybe set to 'Always Deny' earlier. Then it didn't perform any check and simply show "Message Sent" without awareness of user.

If we store numbers for all comrades as shown in image :

When we reopen the page to edit numbers , number for comrade 6 is not shown.

I'm not sure if this is required but it would be great to have something like

By doing this, it would give a clear picture about the registered comrades. Also, on editing the comrades, the registered numbers are displayed right there.
Also, on editing the comrades, the user needs to click the back button to perform any further changes.

I've already implemented the workaround for the above mentioned issues. I'll submit a PR as soon as this is approved as a valid issue.

In the 2nd page, text color is not matching with the background which makes unable to read in small screens.
Spelling error in "Prees" -> "Press"

In the last page, Picture has white background

Mockup.pdf : https://github.com/systers/PCSA-Android/raw/develop/docs/design/mockup.pdf

Under Reporting Process/Contact Staff to Report changing location just changes contact info locally for an activity. However, Are we going to change location frequently? If not will it be good practices to save location in Shared Preferences.

As per the coding section in the systers development process page, the source code needs to have proper comments such as "what does function do, what are the parameters, what does it return". But the current source code doesn't have that kind of commenting in some places.

Shall I add the comments in necessary places?

Improvement in adding comrade numbers

Now comrade numbers have to enter manually by entering the phone number.
This is not user-friendly design and user might enter an incorrect number.

I think it's better to give the feature to select a phone number from the user contacts list.
Then the default icons for the circle of trust icons can be replaced with the contact picture. If a contact picture is not found, it can fill with the default icon.

We have to add new permission (android.permission.READ_CONTACTS) to read contact lists.

Let's say Comrade list is Empty, then on clicking Help Me. It's simply showing Message sent instead of showing No Comrade Contact is Added

Over in the MainActivityFragment.java as well as in the HomeScreen.java I noticed that the same line of code is written multiple times. I would like to fix this. Is this a welcome contribution right now?

As per android best practices hardcoding must be avoided. All the dimensions must be placed in dimens.xml, colors in colors.xml and integers in integer.xml and strings in strings.xml.

Currently strings have been placed in strings.xml , we need to do the same for dimensions, colors and integers.

The comrade numbers is accepting any length of digits
The phone number type changes according to country but a basic validation can be implemented
Willing to work on this

In the fragment_circle_of_trust.xml file contains invalid tags for ImageViews and ImageButtons like
android:text, android:textColor, android:textSize.

These are non usable tags for image specific views. Shall I remove them and refactor the layout files?

In the circle of trust, there is an option "Come get me" which sends a SMS message saying
"Come and get me. I need help getting home Safely. Call ASAP to get my Location.Sent through First Aide's Circle of Trust."

This can be improved by adding location latitude and longitude by acquiring via GPS. If the user already enabled GPS and if the device can acquire accurate location it can be added to the SMS. Otherwise, the original SMS message can be sent saying "Call ASAP to get my Location".

It's possible to add Google maps URL so that user can open Google maps by tapping the SMS message link

@Buddhiprabha @sandarumk @rosariorobinson @shruti-gupta
I would like to implement the following parts of the applications which are yet to be done as specified in the mockup

1. Safety Resources (Pg. 10)
2. Confidentiality (Pg 11)
3. Helping (Pg 12).

I am very much interested in implementing these. And i would like to present you the UI i am going to make in advance if you think it would be more helpful. Waiting for your sugggestions
Thanking you
Chetan mann

Change the style to be reflective of the original design found in this document. https://drive.google.com/open?id=0B8cm8EBZg0GaZlNSdFpxeXJWelU (Mobile version starts at 0:58 of this video.

• Change color codes to the following:
  Main green color: 05D197
  Dark accent: 2DB58F
  Darker accent: 02845F
  White, for text: FFFFFF
  Main secondary yellow color: FFD590
  Dark accent: FFC25C
• Change font to Avenir Next, with "regular" as the main weight for content while "bold" used for buttons. (An alternative is Lato if we can't find a free one (https://www.google.com/fonts/specimen/Lato)
• Create opening screen with the following design:
  
• Add First Aide Title home page, (And generally add a title and subtitle to each screen as shown)
  
• Adjust border radius on buttons to make them more square. Like this:
  
• Adjust Hamburger appearance:
  
• Add forward and back buttons to header. Like this:
  
• Create Slide-in side-bar menu that looks like this:
  

With content like this, in this order:

• Change order of buttons to the following on home page:
• Get help now
• Circle of trust
• Safety Tools
• Support Service
• Sexual Assault Awareness
• Policies and Glossary

There is a white strap at the bottom of the user interface.
See the screenshot

It's better to go back once the user pressed OK button.

Shall I start fixing these two issues?

Add a proper README file for PCSA.

In case of any emergency, instead of browsing application in launcher then opening it going to specific activity and pressing Button "Help Me", What about a widget, just a single click for such cases.

This may be added to lock screen to make it even more faster.

Since it is already implemented,
Can I write an intent which starts ContactPostStaffActivity on clicking Get Help Now button in MainActivity?

Currently says no functionality

In mockup.pdf :

Actual :

Here are the changes I propose to do:

1. Remove the cancel button, since it is of no use , dialog box can be canceled by clicking anywhere in the background.
2. Remove the heading "Select a request" , as options are self explanatory.
3. Remove the radio buttons, since the text is itself clickable and radio buttons serve on real purpose in this case.
4. Insert dividers between options as in mockup.pdf.

Here, It will look nice if on submitting, empty gaps in middle show be ignored before saving.

And it look like this on opening again

Adjust content to reflect this updated document: https://drive.google.com/open?id=0B8cm8EBZg0GaQy1CUkRUOXhWZUE

This document has a great table of contents that corresponds to H1 titles and H2 subtitles and the content that would be found in each section.

Provides a seamless UI Experience.

Could so something like this.

Intro screen can be added for Reporting Process same way as they are for Circle of Trust. These screens will appear to user the first time they click the option .

Implementing Pager under Reporting Process/Contact Staff to Report instead of simply clicking on small TextView

Current Implementation

Updates required :

1. Button borders should change from white to black
2. Line divider below Get Help Now and above Post Staff
3. Link to "ContactOtherStaff" is shown as arrow next to one of the buttons in mockup while it's in the bottom in the current implementation

Currently there are no tests.
What about adding UI Espresso based test?