Code Monkey home page Code Monkey logo

migrate2composer's People

Contributors

sypets avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

migrate2composer's Issues

Reconsider writing of PHP version

We currently write only major.minor. We do not know if migrate2composer is executed on production machine. Possibly, we should just use the same version that is specified in the core / in base-distribution:

TYPO3 version PHP version in composer.json core) PHP version in base distri
9.5.23 7.2.5 (in core git repo) 7.2 (in 9.x branch)
--------------------- ------------------------------------------------ ----------------------------------
10.4.10 7.2.5 (in core git repo) 7.2 (in 9.x branch)
--------------------- ------------------------------------------------ ----------------------------------

The PHP requirement can also be added later :

composer config platform.php 7.2.5

Risky removal of TYPO3 Console scripts

If the TYPO3 Console is not found the scripts part gets removed. This is a risky change as Composer installs do not work correctly without this scripts and the TYPO3 Console. See also the recommendations made by the Core team with the TYPO3.CMS.BaseDistribution.

if (!isset($packagesInfo['helhum/typo3-console'])) {
if (isset($this->composerManifest['scripts']['typo3-cms-scripts'])) {
unset($this->composerManifest['scripts']['typo3-cms-scripts']);
}
if (isset($this->composerManifest['scripts']['post-autoload-dump'])) {
foreach ($this->composerManifest['scripts']['post-autoload-dump'] as $key => $post) {
if ($post === '@typo3-cms-scripts') {
unset($this->composerManifest['scripts']['post-autoload-dump'][$key]);
}
}
if (!$this->composerManifest['scripts']['post-autoload-dump']) {
unset($this->composerManifest['scripts']['post-autoload-dump']);
}
}
}

The default behavior should be creating a composer.json similar to the base dist. If you still like to provide to create a composer.json without the minimal scripts part you should consider using an option for this explicity.

Create interactive version?

This should be done as different command so previous command (migrate2composer:dump) works as before.

This version could ask a few questions (such as PHP version, web-dir directory, usage of caret or tilde etc.) and would make usage more intuitive.

typo in readme

hi,

many thanks for this extension :)
I just followed the instructions in the readme, but stumbled at the first instruction.

git clone https://github.com/sypets/migrate2composere.git
should be
git clone https://github.com/sypets/migrate2composer.git

Fix composer.json template

The template Resources\Private\Composer\composer.json had some errors which makes the resulting composer.json not validate:

composer validate

[Composer\Json\JsonValidationException]                           
  "./composer.json" does not match the expected JSON schema:        
   - authors : Object value found, but an array is required         
   - autoload.psr-4 : Array value found, but an object is required  
   - scripts : Array value found, but an object is required        

see schema: https://getcomposer.org/doc/04-schema.md#authors

Change order of typo3_console commands in composer.json template

Order should get switched to:

"php typo3cms install:generatepackagestates",
"php typo3cms install:fixfolderstructure"

"typo3cms install:fixfolderstructure",

install:fixfolderstructure
... It is recommended to be executed after executing typo3cms install:generatepackagestates ...

https://docs.typo3.org/p/helhum/typo3-console/6.3/en-us/CommandReference/InstallFixfolderstructure.html

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.