Code Monkey home page Code Monkey logo

mail_jack's People

Contributors

synth avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar

Forkers

planetio boy-jer

mail_jack's Issues

Implement encoding parameters with middleware

Should have the ability/option so that users can request their tracking parameters to be encoded. The parameters would then be decoded at middleware level and then sent along.

I'm imagining the following spec:

MailJack.config do |c|
  c.encode_params = :param_name
end

so then ?param_name=xxxencodedstringxxx would be appended to urls

Issue in development mode

I'm seeing sporadic behavior with the parameters not getting assigned in development mode, particularly when i change code in a controller.

This leads me to believe there is some issue when Rails reloads classes and so the dynamic methods that are added are not getting reloaded

link replacement is broken in some situations

if you have "myapp.com/signup/verify?token=abc"
and then later a different link,say: "myapp.com"

replacement will occur poorly, doing the replacement of the first properly, but when we replace the second, it also replaces the first causing this malformed link:

myapp.com?source=abc/signup/verify?token=abc&source=abc

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.