sylvainjule / kirby-categories Goto Github PK

Hi Sylvain,
there is an issue with the way you handle the categories indexes when adding a new category...

How to reproduce it

Let say I have a list of 3 categories with indexes 1, 2 and 3. If I remove the category number 2 which is in in the middle of my list, then if I add a new category, the new category id and panelIndex will be 3, which is already taken by the third category of my initial list.

How to fix it

I would suggest not using this.localValue.length to define the newIndex in Categories.vue.

Here are different options :

1. If you want to increment indexes based on the highest existing index :

newIndex() {
    const indexes = !this.localValue || !this.localValue.length ? [0] : this.localValue.map((item) => item.panelIndex)
    return Math.max(...indexes) + 1
}

2. If you want to fill unused indexes :

newIndex() {
    const indexes = !this.localValue || !this.localValue.length ? [] : this.localValue.map((item) => item.panelIndex)
    for (var i = 1; i <= indexes.length + 1; i++) {
        if (indexes.indexOf(i) == -1) {
            return i
        }
    }
}

There is probably better ways of writing this, though...

Just checking out your plugin, and when I try to add a (second) item to the categories field; I get an error: Cannot read property '0' of undefined?

Tried in a fresh starterkit with Kirby 3.5.3

Hey,
first of all: Thank you very much for this solution. I was struggling all the time with my multilanguage sites and this is exactly what I need.
I wonder if its possible to create category fields inside the site blueprint. If i try for example:

    'sylvainjule.categories.watch' => [
        'site'     => 'fruits',
    ]

it doesn't seem to sync.

Kind regards