The chat_room from sylar-yin

sylar-yin / chat_room Goto Github PK

View Code? Open in Web Editor NEW

C++聊天室服务器，基于sylar框架开发，使用http服务器做资源服务，websocket server做聊天server

CMake 9.98% HTML 12.74% C++ 74.49% Shell 1.29% Makefile 1.49%

chat_room's People

Contributors

Stargazers

Watchers

chat_room's Issues

发现两个bug~

2020-05-05 15:19:30 7405 io_1 15 [INFO] [system] sylar/http/ws_session.cc:32 http header Connection != Upgrade
我用的是火狐浏览器测试的，然后出错了，检查了火狐发的请求头是这样的：

Host: 192.168.56.132:8062
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0
Accept: */*
Accept-Language: zh-CN,en-US;q=0.7,en;q=0.3
Accept-Encoding: gzip, deflate
Sec-WebSocket-Version: 13
Origin: http://192.168.56.132:8090
Sec-WebSocket-Extensions: permessage-deflate
Sec-WebSocket-Key: 1+JeWXx4sEoAoNBT6rGwpQ==
Connection: keep-alive, Upgrade   //这里多了keep-alive
Pragma: no-cache
Cache-Control: no-cache
Upgrade: websocket

https://github.com/sylar-yin/sylar/blob/33f94fb37766ca9ec88db7106ced0a64bbbcff3c/sylar/http/ws_session.cc#L27

我在ws_session.cc:27,32把字符串判断改成包含关系就可以了：
if(strstr(req->getHeader("Upgrade").c_str(), "websocket") == NULL) {
if(strstr(req->getHeader("Connection").c_str(), "Upgrade") == NULL) {

chat_room/chat/chat_servlet.cc

Line 108 in 7fd04c6

if(session_exists(id)) {

然后在chat_servlet.cc:108，应该是要判断name才对，才能判断是不是重名。

            if(session_exists(name)) {
                rsp->set("result", "402");
                rsp->set("msg", "name exists");
                return SendMessage(session, rsp);
            }

Recommend Projects