sweis / step2 Goto Github PK

The documentation and wiki are silent. It appears that a simple maven run
will build it, but the tests fail. There is no hints as to what tests are 
expected to pass, which fail, and nothing on how to fix the failures.

What steps will reproduce the problem?
1. mvn --version
Apache Maven 2.2.1 (rdebian-1)
Java version: 1.6.0_21


2. mvn  clean install

What is the expected output? What do you see instead?

many, many test failures: here are some samples:

Aug 28, 2010 9:22:03 PM com.google.step2.discovery.LegacyXrdsResolver 
checkSecurity
WARNING: signature on XRD from http://example.com/xrdsdid not verify
com.google.step2.xmlsimplesign.XmlSimpleSignException: no signature

Running com.google.step2.xmlsimplesign.CachedCertPathValidatorTest
Aug 28, 2010 9:22:03 PM com.google.step2.xmlsimplesign.CachedCertPathValidator 
validateNoCache
WARNING: Certificate validation failed, certs were: [[

]]
java.security.cert.CertPathValidatorException: Path does not chain with any of 
the trust anchors
    at sun.security.provider.certpath.PKIXCertPathValidator.engineValidate(PKIXCertPathValidator.java:195)

Running com.google.step2.util.XmlUtilTest
Exception in thread "Thread-1" java.lang.RuntimeException: 
java.net.SocketException: Socket closed


What version of the product are you using? On what operating system?
latest from svn.
Ubuntu 10.04
mvn --version
Apache Maven 2.2.1 (rdebian-1)
Java version: 1.6.0_21


Please provide any additional information below.

In com.google.step2.example.consumer.SimpleProviderInfoStore, i believe
it's using a non-standard way to load the providers.properties. According
to "Smartly load your properties"
(http://www.javaworld.com/javaworld/javaqa/2003-08/01-qa-0808-property.html?page
=2),
if you load a resource with ClassLoader, it shall not use leading slash.
(see the 2nd col of the table: '"/"-separated names; no leading "/" (all
names are absolute)')

In most environment there should be no impact. But when I'm trying to
deploy the step2 example as a Grails application, the providers.properties
cannot be loaded without removing the leading '/'. 

Add an XHR-based onCloseHandler that will call the server to obtain the
user's info.

Add an option to the popup page to use either type of handler (redirect, ajaxy)

I am using the step2 code in a web application and I'm seeing a Java exception 
related to the incorrect use of SingleClientConnectionManager within the step2 
code. Stacktrace is below. Please advise. Thanks,
-Patricia


 Jan 17, 2011 12:27:04 PM com.google.step2.discovery.Discovery2$FallbackDiscovery get
INFO   | jvm 1    | 2011/01/17 12:27:04 | WARNING: could not perform new-style 
discovery on test.northwestern.edu
INFO   | jvm 1    | 2011/01/17 12:27:04 | 
org.openid4java.discovery.DiscoveryException: 0x500: could not get host-meta 
for test.northwestern.edu
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
com.google.step2.discovery.Discovery2.discoverOpEndpointsForSite(Discovery2.java
:192)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
com.google.step2.discovery.Discovery2$1.newStyleDiscovery(Discovery2.java:116)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
com.google.step2.discovery.Discovery2$1.newStyleDiscovery(Discovery2.java:111)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
com.google.step2.discovery.Discovery2$FallbackDiscovery.get(Discovery2.java:411)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
com.google.step2.discovery.Discovery2.discover(Discovery2.java:345)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
com.google.step2.AuthRequestHelper.getDiscoveryInformation(AuthRequestHelper.jav
a:115)
... (many more lines)
...
...

INFO   | jvm 1    | 2011/01/17 12:27:04 | Caused by: 
com.google.step2.discovery.HostMetaException: no fetcher found a host-meta for 
test.northwestern.edu
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
com.google.step2.discovery.ParallelHostMetaFetcher.getHostMeta(ParallelHostMetaF
etcher.java:79)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
com.google.step2.discovery.Discovery2.discoverOpEndpointsForSite(Discovery2.java
:190)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       ... 79 more
INFO   | jvm 1    | 2011/01/17 12:27:04 | Caused by: 
java.util.concurrent.ExecutionException: java.lang.IllegalStateException: 
Invalid use of SingleClientConnManager: connection still allocated.
INFO   | jvm 1    | 2011/01/17 12:27:04 | Make sure to release the connection 
before allocating another one.
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:222)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
java.util.concurrent.FutureTask.get(FutureTask.java:83)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
java.util.concurrent.AbstractExecutorService.doInvokeAny(AbstractExecutorService
.java:153)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
java.util.concurrent.AbstractExecutorService.invokeAny(AbstractExecutorService.j
ava:187)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
com.google.step2.discovery.ParallelHostMetaFetcher.getHostMeta(ParallelHostMetaF
etcher.java:74)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       ... 80 more
INFO   | jvm 1    | 2011/01/17 12:27:04 | Caused by: 
java.lang.IllegalStateException: Invalid use of SingleClientConnManager: 
connection still allocated.
INFO   | jvm 1    | 2011/01/17 12:27:04 | Make sure to release the connection 
before allocating another one.
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
org.apache.http.impl.conn.SingleClientConnManager.getConnection(SingleClientConn
Manager.java:199)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
org.apache.http.impl.conn.SingleClientConnManager$1.getConnection(SingleClientCo
nnManager.java:173)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
org.apache.http.impl.client.DefaultRequestDirector.execute(DefaultRequestDirecto
r.java:356)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:6
41)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:5
76)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:5
54)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
com.google.step2.http.DefaultHttpFetcher.fetch(DefaultHttpFetcher.java:76)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
com.google.step2.discovery.UrlHostMetaFetcher.getHostMeta(UrlHostMetaFetcher.jav
a:58)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
com.google.step2.discovery.ParallelHostMetaFetcher$FetcherThread.call(ParallelHo
stMetaFetcher.java:103)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
com.google.step2.discovery.ParallelHostMetaFetcher$FetcherThread.call(ParallelHo
stMetaFetcher.java:92)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
java.util.concurrent.FutureTask.run(FutureTask.java:138)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
java.util.concurrent.FutureTask.run(FutureTask.java:138)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:8
86)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
INFO   | jvm 1    | 2011/01/17 12:27:04 |       ... 1 more

What steps will reproduce the problem?
1.
Use the 20090602 build of step2-commons from
http://code.google.com/p/step2/source/browse/#svn/code/java/maven/com/google/ste
p2/step2-common/1-SNAPSHOT
2.
OR, mvn install on trunk, and use the corresponding jar generated in target/


--
What is the expected output? What do you see instead?
Expected: only com.google.step files in the jar
Actual: A subset of the openid4java files are included in the step2-common
jar. 

--
What version of the product are you using? On what operating system?
Maven version: 2.0.9
Java version: 1.6.0_01
OS name: "linux" version: "2.6.24-gg24-generic" arch: "i386" Family: "unix"

--
Additional information
Because both step2-common and openid4java's own jar define the
org.openid4java package, the classloader can be confused. When loading
classes and resources, the classloader would terminate on the first jar
file it encounters with the target package, making the correctness
dependent on the order of jar files in the CLASSPATH.

The openid4java class files should not be included in the resulting jar file.

The step2 project is using an out-of-date version of the OAuth jar:

    <dependency>
      <groupId>net.oauth</groupId>
      <artifactId>core</artifactId>
      <version>20081027</version>
    </dependency>

Can you upgrade to the latest jar?

    <dependency>
        <groupId>net.oauth</groupId>
        <artifactId>oauth-core</artifactId>
        <version>20090121</version>
    </dependency>

what about checkForPopupClose?

<dependency>
        <groupId>net.oauth.core</groupId>
        <artifactId>oauth-httpclient4</artifactId>
        <version>20090913</version>
</dependency>


http://oauth.googlecode.com/svn/code/maven/net/oauth/core/oauth-httpclient4/2009
0913/

What steps will reproduce the problem?
1. Start the project on the local machine using mvn jetty:run
2. Use the popup option and allow the permission in the resulting popup.
3. When the popup closes, I see the following exception in the console

WARNING: could not perform new-style discovery on 
https://www.google.com/accounts/o8/id?id=<XYZ>
org.openid4java.discovery.DiscoveryException: 0x500: link-element-based 
discovery is not implemented yet
    at 
com.google.step2.discovery.Discovery2.tryLinkElementBasedDiscoveryForUser(D
iscovery2.java:312)
    at 
com.google.step2.discovery.Discovery2.discoverOpEndpointsForUser(Discovery2
.java:250)
    at 
com.google.step2.discovery.Discovery2$2.newStyleDiscovery(Discovery2.java:1
52)
    at 
com.google.step2.discovery.Discovery2$2.newStyleDiscovery(Discovery2.java:1
47)
    at 
com.google.step2.discovery.Discovery2$FallbackDiscovery.get(Discovery2.java
:411)
    at 
com.google.step2.discovery.Discovery2.discover(Discovery2.java:350)
    at 
com.google.step2.ConsumerHelper.getDiscoveryInfoForClaimedId(ConsumerHelper
.java:233)
    at com.google.step2.ConsumerHelper.verify(ConsumerHelper.java:110)
    at 
com.google.step2.example.consumer.servlet.CheckAuthServlet.doGet(CheckAuthS
ervlet.java:108)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
    at 
org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487)
    at 
org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:362)
    at 
org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
    at 
org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
    at 
org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:722)
    at 
org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:404)
    at 
org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCol
lection.java:206)
    at 
org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:1
14)
    at 
org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:139)
    at org.mortbay.jetty.Server.handle(Server.java:324)
    at 
org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:505)
    at 
org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnecti
on.java:828)
    at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:514)
    at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:211)
    at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:380)
    at 
org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:395
)
    at 
org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:
450)




What version of the product are you using? On what operating system?
Trunk Version on linux

What steps will reproduce the problem?
I use consumer example.

What is the expected output? What do you see instead?
Success login.

java.security.AccessControlException: access denied (java.net.NetPermission 
getProxySelector)
    at java.security.AccessControlContext.checkPermission(AccessControlContext.java:323)
    at java.security.AccessController.checkPermission(AccessController.java:546)
    at java.lang.SecurityManager.checkPermission(SecurityManager.java:532)
    at com.google.appengine.tools.development.DevAppServerFactory$CustomSecurityManager.checkPermission(DevAppServerFactory.java:166)
    at java.net.ProxySelector.getDefault(ProxySelector.java:73)
    at org.apache.http.impl.conn.ProxySelectorRoutePlanner.determineProxy(ProxySelectorRoutePlanner.java:180)
    at org.apache.http.impl.conn.ProxySelectorRoutePlanner.determineRoute(ProxySelectorRoutePlanner.java:144)
    at org.apache.http.impl.client.DefaultRequestDirector.determineRoute(DefaultRequestDirector.java:619)
    at org.apache.http.impl.client.DefaultRequestDirector.execute(DefaultRequestDirector.java:319)
    at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:641)
    at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:576)
    at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:554)
    at com.google.step2.http.DefaultHttpFetcher.fetch(DefaultHttpFetcher.java:76)
    at com.google.step2.discovery.UrlHostMetaFetcher.getHostMeta(UrlHostMetaFetcher.java:58)
    at com.google.step2.discovery.Discovery2.tryHostMetaBasedDiscoveryForUser(Discovery2.java:274)
    at com.google.step2.discovery.Discovery2.discoverOpEndpointsForUser(Discovery2.java:231)
    at com.google.step2.discovery.Discovery2$2.newStyleDiscovery(Discovery2.java:152)
    at com.google.step2.discovery.Discovery2$2.newStyleDiscovery(Discovery2.java:147)
    at com.google.step2.discovery.Discovery2$FallbackDiscovery.get(Discovery2.java:411)
    at com.google.step2.discovery.Discovery2.discover(Discovery2.java:350)
    at com.google.step2.ConsumerHelper.getDiscoveryInfoForClaimedId(ConsumerHelper.java:233)
    at com.google.step2.ConsumerHelper.verify(ConsumerHelper.java:110)
    at ru.budget.web.server.handlers.login.CheckAuthServlet.doGet(CheckAuthServlet.java:105)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
    at com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:216)
    at com.google.inject.servlet.ServletDefinition.service(ServletDefinition.java:141)
    at com.google.inject.servlet.ManagedServletPipeline.service(ManagedServletPipeline.java:93)
    at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:63)
    at com.google.inject.servlet.FilterDefinition.doFilter(FilterDefinition.java:134)
    at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:59)
    at com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:122)
    at com.google.inject.servlet.GuiceFilter.doFilter(GuiceFilter.java:110)
    at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
    at com.google.appengine.api.blobstore.dev.ServeBlobFilter.doFilter(ServeBlobFilter.java:58)
    at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
    at com.google.apphosting.utils.servlet.TransactionCleanupFilter.doFilter(TransactionCleanupFilter.java:43)
    at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
    at com.google.appengine.tools.development.StaticFileFilter.doFilter(StaticFileFilter.java:122)
    at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
    at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:388)
    at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
    at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
    at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
    at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418)
    at com.google.apphosting.utils.jetty.DevAppEngineWebAppContext.handle(DevAppEngineWebAppContext.java:70)
    at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
    at com.google.appengine.tools.development.JettyContainerService$ApiProxyHandler.handle(JettyContainerService.java:349)
    at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
    at org.mortbay.jetty.Server.handle(Server.java:326)
    at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
    at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:923)
    at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:547)
    at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
    at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
    at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:409)
    at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)

What version of the product are you using? On what operating system?
GAE 1.4 GWT 2.1.1. GWT Platgorm 0.4

Please provide any additional information below.

What steps will reproduce the problem?
1. Use eclipse to integrate the code manually
2. DefaultTrustRootProvider should shows error post build
P.S: Do not use maven

What is the expected output? What do you see instead?
Covered above. 
Errors Shown
javax.net.ssl.X509TrustManager is not supported by Google App Engine's Java 
runtime environment
javax.net.ssl.TrustManager is not supported by Google App Engine's Java runtime 
environment

What version of the product are you using? On what operating system?
Window XP

Please provide any additional information below.
1. Does one need to provide a RSA certificate or key to work around this issue?

just notice a minor issue with the redirect hello page. 

in most browsers like IE6, safari, the layout is normal with 2 columns.

in FF 3.0.6, it shows as a single col and require scroll down.

Hi, it was easy to add the Maven dependency. But how do I use it now? Any link 
to public java docs or a short tutorial with some code snippets?

What steps will reproduce the problem?
1. Use an openID to login a user with a non English name. I found the problem 
with the first name: Smári

From the successful response ((ConsumerManager.java:1145) - Received positive 
auth response.) The nounce can't be parsed. For the above name this is the 
value in the url: openid.ext1.value.firstName=Sm%C3%A1ri


What is the expected output? What do you see instead?
I expected a successful login. I get this exception:
SEVERE: Servlet.service() for servlet CheckAuth threw exception
com.google.step2.VerificationException: 0x0: something went wrong during 
response verification, such as nonce or signature checking. Check your debug 
logs.
        at com.google.step2.ConsumerHelper.verify(ConsumerHelper.java:121)


What version of the product are you using? On what operating system?
version=1-SNAPSHOT on Ubuntu Linux - Built with and used under Sun JDK 1.6.0_18

What steps will reproduce the problem?
1. In the index.php of hybrid source code, I had pass value to 
$CONSUMER_KEY and $CONSUMER_SECRET.
2. Looking for OpenID Endpoint failed in the code segmen:
if ($identifier) {
      $fetcher = Auth_Yadis_Yadis::getHTTPFetcher();
      list($normalized_identifier, $endpoints) =
          Auth_OpenID_discover($identifier, $fetcher);

      if (!$endpoints) {
        debug('No OpenID endpoint found.');
      }
...
header('Location: ' . $endpoints[0]->server_url . '?' . rtrim($uri, '&'));
3. I tried changing the header statement to:
$uri = 'Location: https://www.google.com/accounts/o8/ud' . '?' . rtrim
($uri, '&');
header($uri);
and now I can see it's successful.
4. But now I want to connect to flexible endpoint. How can I do that?
Thanks for helping.

Hong An.

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?


Please provide any additional information below.

What steps will reproduce the problem?
1. Use yahoo id to login
2.
3.

What is the expected output? What do you see instead?
Get full name, but get null.

What version of the product are you using? On what operating system?


Please provide any additional information below.
Please add FULL_NAME to AxSchema:

  public enum AxSchema {
    EMAIL("http://axschema.org/contact/email", "email"),
    COUNTRY("http://axschema.org/contact/country/home", "country"),
    LANGUAGE("http://axschema.org/pref/language", "language"),
    FIRST_NAME("http://axschema.org/namePerson/first", "firstName"),
    LAST_NAME("http://axschema.org/namePerson/last", "lastName"),
    FULL_NAME("http://axschema.org/namePerson", "fullname"),
    ALIAS("http://axschema.org/namePerson/friendly", "nickname");

Purpose of code changes on this branch:

next revision of discovery code. To just see the delta to previous version, 
start here: http://code.google.com/p/step2/source/diff?
show=review&format=side&path=/code/java/changes/balfanz-
discovery/common/src/main/java/com/google/step2/discovery/Discovery2.java&r=374&
spec=
svn374

When reviewing my code changes, please focus on:


After the review, I'll merge this branch into:
/trunk

please create google group to encourage more users to use it

Using the example-consumer with AppEngine (local) I get a null point exception.

1. Start AppEngine
2. Insert "https://www.google.com/accounts/o8/id" as OpedId URL
3. I get:

java.lang.NullPointerException
    at java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:881)
    at com.google.appengine.api.urlfetch.URLFetchServiceImpl.fetch(URLFetchServiceImpl.java:45)
    at 
com.google.step2.example.consumer.appengine.Openid4javaFetcher.fetch(Openid4java
Fetcher.java:108)
    at 
com.google.step2.example.consumer.appengine.Openid4javaFetcher.head(Openid4javaF
etcher.java:65)
    at org.openid4java.discovery.yadis.YadisResolver.retrieveXrdsLocation(YadisResolver.java:376)
    at org.openid4java.discovery.yadis.YadisResolver.discover(YadisResolver.java:245)
    at org.openid4java.discovery.yadis.YadisResolver.discover(YadisResolver.java:229)
    at org.openid4java.discovery.yadis.YadisResolver.discover(YadisResolver.java:163)
    at org.openid4java.discovery.Discovery.discover(Discovery.java:147)
    at com.google.step2.discovery.Discovery2.access$101(Discovery2.java:98)
    at 
com.google.step2.discovery.Discovery2$FallbackDiscovery.oldStyleDiscovery(Discov
ery2.java:436)
    at com.google.step2.discovery.Discovery2$FallbackDiscovery.get(Discovery2.java:428)
    at com.google.step2.discovery.Discovery2.discover(Discovery2.java:345)
    at com.google.step2.AuthRequestHelper.getDiscoveryInformation(AuthRequestHelper.java:115)
    at com.google.step2.AuthRequestHelper.generateRequest(AuthRequestHelper.java:216)
    at com.google.step2.example.consumer.servlet.LoginServlet.doPost(LoginServlet.java:177)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:713)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
    at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487)
    at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1093)
    at com.google.appengine.api.blobstore.dev.ServeBlobFilter.doFilter(ServeBlobFilter.java:51)
    at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
    at 
com.google.apphosting.utils.servlet.TransactionCleanupFilter.doFilter(Transactio
nCleanupFilter.java:4
3)
    at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
    at 
com.google.appengine.tools.development.StaticFileFilter.doFilter(StaticFileFilte
r.java:121)
    at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
    at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:360)
    at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
    at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
    at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:712)
    at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
    at 
com.google.apphosting.utils.jetty.DevAppEngineWebAppContext.handle(DevAppEngineW
ebAppContext.java:70)
    at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:139)
    at 
com.google.appengine.tools.development.JettyContainerService$ApiProxyHandler.han
dle(JettyContainerSer
vice.java:352)
    at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:139)
    at org.mortbay.jetty.Server.handle(Server.java:313)
    at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:506)
    at org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:844)
    at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:644)
    at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:211)
    at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:381)
    at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:396)
    at org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:442)

I'm using AppEngine 1.3.1 and the latest step2 source code.
I'm completely new to OpenId, so I don't know if I missed something.
Thanks

Nicola

Maybe I'm dumb, but the current source is not working for me.
The current demo on step2.appspot.com is not returning an Oauth token, even 
if requested.
My code says that the isHybrid...-method is not returning a token even if 
requested.

see the patch

What steps will reproduce the problem?
1. Run Application on Local Machine
2. HybridOauthRequest req = new   
   HybridOauthRequest("2glue.com",Constants.SCOPE);


What is the expected output? What do you see instead?
HybridOauthResponse hybridResponse = 
 (HybridOauthResponse)authSuccess.getExtension(HybridOauthMessage.OPENID_NS_OAUTH);

When i fetch response then There is no request_token in the response. I am 
confused that what should i set HybridOauthRequest so that i can get the token. 
I am running application on local machine and OpenId is working fine but now i 
have to add OAuth Support also in the project. Can anybody help me on it?


What version of the product are you using? On what operating system?
Windows 7,Grails 1.3.3

Please provide any additional information below.

This is the Maven repository for Guice 2.0

http://google-maven-repository.googlecode.com/svn/repository/com/google/inject/g
uice/2.0/

Add to popuplib.js a handler to run prior to the window opening.

What steps will reproduce the problem?
1. Parsing the host-meta files (using UrlHostMetaFetcher)
2. Fetching Xrd files (using DefaultHttpFetcher)

Inside DefaultHttpFetcher, the method to getContentAsStream opens an
InputStream, but this InputStream never seems to be released. 

Related to this, inside UrlHostMetaFetcher, this makes a method call that
ultimately calls getContentAsStream, and never seems to be released. 

This might present a slow leakage of resources. 

using google's open id url and checked the "country" field. in the
"approval" page, google doesn't say the RP ask for my country. And in the
result page, the AX Fetch Country Response is empty.

in my google profile, "Where I live now" is filled

from firebug, in the outgoing http request, the following does exist:
openid.ext1.required=email,country
openid.ext1.type.country=http://axschema.org/contact/country/home

but at the end, google doesn't seem to send back the country info. i've
added log at ConsumerHelper that shows only the following:

authResponse: openid.op_endpoint:https://www.google.com/accounts/o8/ud
openid.signed:op_endpoint,claimed_id,identity,return_to,response_nonce,assoc_han
dle,ns.ext1,ext1.mode,ext1.type.email,ext1.value.email
openid.ns.ext1:http://openid.net/srv/ax/1.0
openid.sig:Gx2xi2Pd65ERQknVwuJPM+SlIz+x0BN7e0CRJwprFGE=
openid.response_nonce:2009-02-09T07:15:47ZFN-EoQLu5AuLMg
openid.claimed_id:https://www.google.com/accounts/o8/id?id=AItOawm8x8-_qlWnnYXTy
4kwbutoHuv_wMxCe4g
openid.assoc_handle:AOQobUdxHomG03ZUfTOmEgHYQ9syfOjfr1vN_Vo9rr4-bW2Ld0dlrKCHfTqr
v35oImkaad_y
openid.ext1.value.email:MY_EMAIL_ADDRESS
openid.ns:http://specs.openid.net/auth/2.0
openid.identity:MY_OPENID
wbutoHuv_wMxCe4g
openid.ext1.type.email:http://axschema.org/contact/email
openid.mode:id_res
openid.ext1.mode:fetch_response
openid.return_to:http://localhost:8080/checkauth

What steps will reproduce the problem?
1. svn checkout http://step2.googlecode.com/svn/code/java/trunk/ step2
2. cd step2
3. mvn install

What is the expected output? What do you see instead?

Successful compile but. 

[INFO] Copying 0 resource
[WARNING] POM for
'org.openid4java:openid4java-consumer:pom:0.9.5-SNAPSHOT:compi
le' is invalid.

Its dependencies (if any) will NOT be available to the current build.
[WARNING] POM for
'org.openid4java:openid4java-server:pom:0.9.5-SNAPSHOT:compile
' is invalid.
...
...
could not parse error message:
org\openid4java\discovery\xri\LocalXriResolver.ja
va(org\openid4java\discovery\xri:LocalXriResolver.java):204: cannot find symbol
symbol  : class XRI
location: class org.openid4java.discovery.xri.LocalXriResolver
                new XRI(identifier.toString()),
                    ^


[INFO] ------------------------------------------------------------------------
[INFO] For more information, run Maven with the -e switch
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 5 seconds
[INFO] Finished at: Sun Apr 26 22:54:50 EEST 2009
[INFO] Final Memory: 19M/34M
[INFO] ------------------------------------------------------------------------


What version of the product are you using? On what operating system?

apache maven 2.1.0 , jdk 1.6.0_10-rc2

Please provide any additional information below.

openid is working fine, but there is error below in console

0x500: could not get host-meta


[WARN] could not perform new-style discovery on yahoo.com
org.openid4java.discovery.DiscoveryException: 0x500: could not get host-meta 
for yahoo.com
at 
com.google.step2.discovery.Discovery2.discoverOpEndpointsForSite(Discovery2.java
:192)
at 
com.google.step2.discovery.Discovery2$1.newStyleDiscovery(Discovery2.java:116)
at 
com.google.step2.discovery.Discovery2$1.newStyleDiscovery(Discovery2.java:111)
at 
com.google.step2.discovery.Discovery2$FallbackDiscovery.get(Discovery2.java:411)
at com.google.step2.discovery.Discovery2.discover(Discovery2.java:345)
at 
com.google.step2.AuthRequestHelper.getDiscoveryInformation(AuthRequestHelper.jav
a:115)
at 
com.google.step2.AuthRequestHelper.generateRequest(AuthRequestHelper.java:216)
at 
org.springframework.security.openid.OpenID4JavaConsumer.beginConsumption(OpenID4
JavaConsumer.java:194)
at 
org.springframework.security.openid.OpenIDAuthenticationFilter.attemptAuthentica
tion(OpenIDAuthenticationFilter.java:132)
at 
org.springframework.security.web.authentication.AbstractAuthenticationProcessing
Filter.doFilter(AbstractAuthenticationProcessingFilter.java:199)
at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(Fi
lterChainProxy.java:380)
at 
org.springframework.security.web.authentication.logout.LogoutFilter.doFilter(Log
outFilter.java:105)
at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(Fi
lterChainProxy.java:380)
at 
org.springframework.security.web.context.SecurityContextPersistenceFilter.doFilt
er(SecurityContextPersistenceFilter.java:79)
at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(Fi
lterChainProxy.java:380)
at 
org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java
:169)
at 
org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFi
lterProxy.java:237)
at 
org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterPr
oxy.java:167)
at 
org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.jav
a:1157)
at 
com.google.appengine.api.blobstore.dev.ServeBlobFilter.doFilter(ServeBlobFilter.
java:58)
at 
org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.jav
a:1157)
at 
com.google.apphosting.utils.servlet.TransactionCleanupFilter.doFilter(Transactio
nCleanupFilter.java:43)
at 
org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.jav
a:1157)
at 
com.google.appengine.tools.development.StaticFileFilter.doFilter(StaticFileFilte
r.java:122)
at 
org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.jav
a:1157)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:388)
at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418)
at 
com.google.apphosting.utils.jetty.DevAppEngineWebAppContext.handle(DevAppEngineW
ebAppContext.java:70)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at 
com.google.appengine.tools.development.JettyContainerService$ApiProxyHandler.han
dle(JettyContainerService.java:349)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:326)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
at 
org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:938)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:755)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:218)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:409)
at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
Caused by: com.google.step2.discovery.HostMetaException: no fetcher found a 
host-meta for yahoo.com
at 
org.springframework.security.openid.ext.ContinuousHostMetaFetcher.getHostMeta(Co
ntinuousHostMetaFetcher.java:38)
at 
com.google.step2.discovery.Discovery2.discoverOpEndpointsForSite(Discovery2.java
:190)
... 41 more

i have set my eclipse's jre as 1.6

org.apache.jasper.compiler.Compiler : Compiler.java : 387] : Javac 
exception 
Compile failed; see the compiler error output for details.
 at org.apache.tools.ant.taskdefs.Javac.compile(Javac.java:933)
 at org.apache.tools.ant.taskdefs.Javac.execute(Javac.java:757)
 at org.apache.jasper.compiler.Compiler.generateClass(Compiler.java:382)
 at org.apache.jasper.compiler.Compiler.compile(Compiler.java:472)
 at org.apache.jasper.compiler.Compiler.compile(Compiler.java:451)
 at org.apache.jasper.compiler.Compiler.compile(Compiler.java:439)
 at 
org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:
511)
 at 
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:
295)
 at 
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:292)
 at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:236)
 at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
 at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487)
 at 
org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:362)
 at 
org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
 at 
org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
 at 
org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:729)
 at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
 at org.mortbay.jetty.servlet.Dispatcher.forward(Dispatcher.java:285)
 at org.mortbay.jetty.servlet.Dispatcher.forward(Dispatcher.java:126)
 at 
com.google.step2.example.consumer.servlet.LoginServlet.doGet(LoginServlet.j
ava:86)
 at javax.servlet.http.HttpServlet.service(HttpServlet.java:693)
 at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
 at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487)
 at 
org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:362)
 at 
org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
 at 
org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
 at 
org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:729)
 at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
 at 
org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
 at 
org.mortbay.jetty.handler.RequestLogHandler.handle(RequestLogHandler.java:4
9)
 at 
org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
 at org.mortbay.jetty.Server.handle(Server.java:324)
 at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:505)
 at 
org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnecti
on.java:829)
 at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:513)
 at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:211)
 at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:380)
 at 
org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:396
)
 at 
org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:48
8)

ERROR in 
D:\work\test\src\com\google\step2\example\consumer\OAuthConsumerUtil.java 
(at line 27)
 @Inject
 ^^^^^^^
Syntax error, annotations are only available if source level is 1.5

    <groupId>com.google.step2</groupId>
    <artifactId>step2-parent</artifactId>
    <version>1-SNAPSHOT</version>

Hi 

The above mentioned jar seems to be missing in the repository. Can I know a
sample code to integrate this with Struts 2 please.

step2 currently depends on OpenID4Java 0.9.6-SNAPSHOT in its pom.xml:

http://code.google.com/p/step2/source/browse/code/java/trunk/pom.xml#32

A final release of 0.9.6 was tagged today: 
http://code.google.com/p/openid4java/source/detail?r=663

It would be a good idea to update the dependency to 0.9.6 final to ensure 
stable builds for people using Maven to mange their dependencies on step2 and 
OpenID4Java.

It would also be a good idea to tag a release of step2 itself for the same 
reason.

It should be noted that 0.9.6 is not in the Maven Central repository yet, but 
then again the SNAPSHOT version is not either.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?


Please provide any additional information below.

What is the expected output? What do you see instead?
HostMeta logs each line it ignores or can't parse using a level of INFO.  This 
results in excessive logging at default when discovering a google account since 
the site on the user's domain is also parsed.  

Please provide any additional information below.
It's typically difficult to configure the Java Util Logging (JUL) library.  It 
would be nice to see logging for step2 switched to apache logging (as per 
openid4java) or perhaps SLF4J.

similar to issue 4

1. LoginViaPopupServlet, change line 108
    realm.append(req.getContextPath())
        .append(REDIRECT_PATH);
    session.setAttribute(RETURN_TO, realm.toString());

2. at popup.jsp, change the javascript from line 94 to:
              url: "<%=request.getContextPath()%>/hello?size=short",
              cache: false,
              success: function(response) {
                $("#welcomePane").html(response);
              }
          });
        } else {
          window.location = "<%=request.getContextPath()%>/hello";
        }
      };

I'm able to get the example working without problem

Purpose of code changes on this branch:


When reviewing my code changes, please focus on:


After the review, I'll merge this branch into:
/trunk

Let's have another look when you have time.

Dirk.

you guys probably have tested the project with localhost:8080 only :-)

when i run step2 in port 80 under my domain name, e.g. http://mydomain.com.
The LoginServlet will generate a realm as mydomain.com:80, and it will
cause a VerificationException 

com.google.step2.VerificationException: 0x0: something went wrong during
response verification, such as nonce or signature checking. Check your
debug logs. verification.opSetupUrl: null, verification.authResponse:
org.openid4java.message.AuthSuccess@da2af3

In LoginServlet, by commenting the port at line 89, i.e. always use port 80
    //realm.append(":").append(req.getServerPort());
it will work.

the line should probably be rewritten as:
if (req.getServerPort()!=80) realm.append(":").append(req.getServerPort());

What steps will reproduce the problem?

Currently, the example for libpopup.js results in very long URLs.

What is the expected output? What do you see instead?

The library should change behavior to use 'POST' and form-encoded OpenID 
parameters instead 
of 'GET' for long URLs.

This implies that window.open() should load a javascript() form that 
auto-submits itself.

Please use labels and text to provide additional information.

What steps will reproduce the problem?
1. New project create 
2. Copy example files
3. Register domain
4. Run application on app-engine

What is the expected output? What do you see instead?
Working example.

What version of the product are you using? On what operating system?
Latest trunk version.
GAE 1.4

GAE LOG:




Please provide any additional information below.

What steps will reproduce the problem?

Use ab to generate 2 (or more) concurrent post requests against the 
example-consumer application:
ab -n 2 -c 2 -p post_data -T 'application/x-www-form-urlencoded' 
http://localhost:8080/lso2/
where post_data contains the following:
openid=yourdomain.com&stage=discovery

What is the expected output? What do you see instead?

Caused by: java.lang.IllegalStateException: Invalid use of 
SingleClientConnManager: connection still allocated.
Make sure to release the connection before allocating another one.
    at org.apache.http.impl.conn.SingleClientConnManager.getConnection(SingleClientConnManager.java:199)
    at org.apache.http.impl.conn.SingleClientConnManager$1.getConnection(SingleClientConnManager.java:173)
    at org.apache.http.impl.client.DefaultRequestDirector.execute(DefaultRequestDirector.java:356)
    at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:641)
    at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:576)
    at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:554)
    at com.google.step2.http.DefaultHttpFetcher.fetch(DefaultHttpFetcher.java:76)
    at com.google.step2.discovery.UrlHostMetaFetcher.getHostMeta(UrlHostMetaFetcher.java:58)


What version of the product are you using? On what operating system?
Latest snapshot

Please provide any additional information below.
The problem appears to stem from the use of DefaultHttpClient in the default 
fetcher. The httpclient docs indicate the DefaultHttpClient is threadsafe: 
http://hc.apache.org/httpcomponents-client-dev/tutorial/html/httpagent.html

However, other information suggests using ThreadSafeClientConnManager 
http://stackoverflow.com/questions/1281219/best-practice-to-use-httpclient-in-mu
ltithreaded-environment

Updating to the latest httpclient and httpcore libraries didn’t resolve the 
problem. Switching to ThreadSafeClientConnManager resolves the issue.  I have 
an HttpFetcher implementation which I can contribute.

when run in Jetty, the following exception is thrown:
java.lang.NoClassDefFoundError: org/apache/AnnotationProcessor

no problem when run in Tomcat.

What steps will reproduce the problem?
1. Run popup-style demo
2. Make sure "stay on this page after login" is checked
3. Click the "Sign in using your Google account" button
4. Click to allow email and language
5. AX Fetch Language response is empty, should be "en" for "English"

LoginViaPopupServlet is building the AX fetch request using aliases that 
don't match with the short names in Step2.AxSchema. See patch attached.

What steps will reproduce the problem?
1. Use step2 on GAE application such as puffypoodles
2. Attempt OpenID discovery on se-warren.k12.ia.us

What is the expected output? What do you see instead?
Google should allow an se-warren.k12.ia.us user to login; instead, an error is 
thrown.

The following error trace is thrown when attempting to access this domain:

org.openid4java.discovery.DiscoveryException: 0x500: could not get host-meta 
for se-warren.k12.ia.us
    at com.google.step2.discovery.Discovery2.discoverOpEndpointsForSite(Discovery2.java:192)
    at com.google.step2.discovery.Discovery2$1.newStyleDiscovery(Discovery2.java:116)
    at com.google.step2.discovery.Discovery2$1.newStyleDiscovery(Discovery2.java:111)
    at com.google.step2.discovery.Discovery2$FallbackDiscovery.get(Discovery2.java:411)
    at com.google.step2.discovery.Discovery2.discover(Discovery2.java:345)
    at com.google.step2.AuthRequestHelper.getDiscoveryInformation(AuthRequestHelper.java:115)
    at com.google.step2.AuthRequestHelper.generateRequest(AuthRequestHelper.java:216)
...

would be good, if you create google group

What steps will reproduce the problem?
1. Use an invalid domain name and generate an auth request by calling
AuthRequestHelper.generateRequest
2. Reuse the same ConsumerHelper to generate an AuthRequestHelper and use
now a valid domain name and generate an auth request by calling
AuthRequestHelper.generateRequest
The discovery will fail and the following exception is the root cause:
Caused by: java.lang.IllegalStateException: Invalid use of
SingleClientConnManager: connection still allocated.
Make sure to release the connection before allocating another one.
    at
org.apache.http.impl.conn.SingleClientConnManager.getConnection(SingleClientConn
Manager.java:199)
    at
org.apache.http.impl.conn.SingleClientConnManager$1.getConnection(SingleClientCo
nnManager.java:173)
    at
org.apache.http.impl.client.DefaultRequestDirector.execute(DefaultRequestDirecto
r.java:390)
    at
org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:6
41)
    at
org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:5
76)
    at
org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:5
54)
    at com.google.step2.http.DefaultHttpFetcher.fetch(DefaultHttpFetcher.java:76)
    at
com.google.step2.discovery.UrlHostMetaFetcher.getHostMeta(UrlHostMetaFetcher.jav
a:54)
    at
com.google.step2.discovery.ParallelHostMetaFetcher$FetcherThread.call(ParallelHo
stMetaFetcher.java:103)
    at
com.google.step2.discovery.ParallelHostMetaFetcher$FetcherThread.call(ParallelHo
stMetaFetcher.java:92)
    at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:269)
    at java.util.concurrent.FutureTask.run(FutureTask.java:123)
    at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:6
51)
    at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:676)
    ... 1 more


What is the expected output? What do you see instead?
The second discovery should succeed.

What version of the product are you using? On what operating system?
This issue has been reproduced with revision 435 and is also not fixed in
trunk.

Please provide any additional information below.
The fix is to close the InputStream returned from the response in a finally
block in the UrlHostMetaFetcher.

finally
    {
        if(response != null)
        {
            try
            {
                response.getContentAsStream().close();

            }
            catch(Exception ex)
            {
                //ignored
            }
        }
    }

This fixed the problem for us.

Purpose of code changes on this branch:

first pass of new discovery code

When reviewing my code changes, please focus on:


After the review, I'll merge this branch into:
/trunk

i have create one website, i need to implement open id registration 

please tell me procedure .

thanks,
raja

Hello,

It may not be the right place to ask my question, please pardon me.
But I would like to write my First Marketplace App using Java.

Please guide me where I can find a Hello-World type application.

Regards,
Subodh Bansal

The com.google.step2.VerificationException thrown in 
com.google.step2.ConsumerHelper.verify(String, ParameterList, 
DiscoveryInformation) (l.121 on r.540/trunk) could be improved.

The org.openid4java.consumer.VerificationResult.getStatusMsg() is always set if 
the org.openid4java.consumer.VerificationResult.getAuthResponse() is of type 
org.openid4java.message.AuthSuccess.

I now have several projects that depend on step2 and it would be useful if you 
could periodically "release" maven artifacts-- i.e. with a non-SNAPSHOT version 
number. 

This way we can release non-SNAPSHOT builds downstream.