swapynetwork / swapy-exchange-protocol Goto Github PK

1. Install truffle as a dev dependency (instead of globally) and call it via npm script
2. Create a sample.env that is not on .gitignore so the user can rename it as .env;

InvestmentAsset.refuseInvestment and InvestmentAsset.cancelInvestment are the same function, the difference is just the modifiers, the first one being onlyOwner and the second onlyInvestor. So I suggest to merge the functions and create a ownerOrInvestor modifier.

Every time that a new offer is created, the contract is adding the assets in the same offer. So after N offers created, the first offer will have N * 5 assets.

After investigating I discovered that the way that the assets are being created, using an array.push is causing the issue.

    address[] newAssets;
    for (uint index = 0; index < _assets.length; index++) {
      newAssets.push(address(new InvestmentAsset(msg.sender, VERSION, newOffer)));
    }

• Receive a list of assets as argument in createOffer(..) (SwapyExchange.sol) and
  call createAsset(...) (InvestmentOffer.sol) for each asset.
• Track an event after all the process.

• Receive an attribute_id as argument and use it when fire a new event