Further improve bundle size about svelte HOT 9 CLOSED

Was about to suggest the similar optimization. Plucking methods like document.createElement into the variables at the top of the module (like const __createElement = document.createElement.bind(document)) will help the minifier when the components have many nodes.

from svelte.

Yup. I did a little test locally yesterday, and found about a 20% savings by doing this on a relatively small project.

from svelte.

We should definitely do this. As a starting point, helpers like createElement and detachElement would reduce the size a bit (gzip notwithstanding) and could be externalised if necessary. I hadn't thought of custom factories though, that's an interesting idea.

from svelte.

cloneNode could be helpful here, too.

from svelte.

BTW does it make sense to have elementWithClass actually compatible with React.createElement which is (name, attributes, children)?
Who knows if it will provide some positive side-effect like JSX compatibility?

from svelte.

@emirotin you want to avoid polymorphic functions like that, that's why Inferno avoids them in core – they result in functions that can't be properly optimised.

from svelte.

Interesting @trueadm thanks for the insight.

from svelte.

Helpers have been in Svelte for a while, is this issue open for other helpers? Like the suggested elementWithClass and potentially similar ones like elementWithId?

from svelte.

Probably slightly trickier to do elementWithClass in Svelte's current form, because creating nodes and adding attributes happens in two separate places (so that hydration can work). So maybe we should close this and revisit it if we ever need to eke out a few extra microseconds 😀

from svelte.