Code Monkey home page Code Monkey logo

svelte-todomvc's Introduction

svelte-todomvc's People

Contributors

opedromiranda avatar rich-harris avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

svelte-todomvc's Issues

Cannot save edited item

After double clicking item and editing text enter button causes following error:

Uncaught TypeError: Cannot set property 'description' of undefined
    at E.submit (TodoMVC.html:159)
    at HTMLInputElement.m (shared.js:46)
    at E.blur (TodoMVC.html:121)
    at HTMLInputElement.<anonymous> (TodoMVC.html:22)
    at HTMLInputElement.d (TodoMVC.html:56)

Doesn't work on Opera 54, Chrome 68, Firefox 61 on production version on http://svelte-todomvc.surge.sh/

nice to have: the final output inside the repo

Of particular interest is the final output before minification, since only this reveals the magical disappearance. Reading the final bundle.js from http://svelte-todomvc.surge.sh/ is only partially helpful as this demos the size but the minified and uglified code is hard to read.

Maybe you can add a dist folder with the unminified js output.

Thank you, great work.

Active filter does not update

When on the Active filter, checking an item should make it no longer visible in the view, since the filter is for items that are Active (not completed) only.

Cancelling Edit throws exception

  1. on blur is tied to submit
  2. cancelling edit removes the input element which fires blur before getting removed
  3. this blur event calls submit, but the element for editing is not there anymore

this is a nasty thing, i try to handle elegantly in another framework. faced the very same problem.

A11y warning: Avoid using autofocus

When running the application, a warning appears in the console:

rollup v1.7.3
bundles src/main.js โ†’ public/bundle.js...
(!) svelte plugin: A11y: Avoid using autofocus
src/TodoMVC.svelte
92:     on:keydown={createNew}
93:     placeholder="What needs to be done?"
94:     autofocus
        ^
95:   >
96: </header>
src/TodoMVC.svelte
117:               on:keydown={handleEdit}
118:               on:blur={submit}
119:               autofocus
                   ^
120:             >
121:           {/if}
created public/bundle.js in 369ms

[2019-10-13 10:47:46] waiting for changes...

Double click for editing not working in Chrome Desktop

When I double click an item, I can change the text, but I cannot commit the change into the model. Clicking anywhere does nothing, double clicking a different item makes that item editable, but reverts the changes.

Tested:
Chrome Version 56.0.2924.87 (64-bit)
FF 53.0.3 (32-Bit)
IE 11.0.9600.18617

Testing!

Hey, do you want me to add Cypress tests?

screen shot 2018-03-07 at 9 08 50 pm

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.