Code Monkey home page Code Monkey logo

suzie97 / communique Goto Github PK

View Code? Open in Web Editor NEW

This project forked from jangernert/feedreader

77.0 77.0 0.0 16.89 MB

Featureful RSS Reader for elementary OS

License: GNU General Public License v3.0

HTML 0.04% CSS 0.78% C 26.67% Vala 70.04% PHP 0.29% Shell 0.07% XSLT 0.28% Meson 1.64% Python 0.08% Dockerfile 0.09% Makefile 0.01%
bazqux elementary-apps elementary-os elementaryos feed feedbin feedhq freshrss gtk inoreader instapaper news nextcloud-news pocket reader reading rss ttrss vala wallabag

communique's Introduction

communique's People

Contributors

39aldo39 avatar atn-d avatar bilelmoussaoui avatar brendanlong avatar comradekingu avatar dsboger avatar emintufan avatar floflr avatar grigorii-horos avatar hadess avatar harmathy avatar jangernert avatar jkingweb avatar koji avatar nielsk avatar nlgranger avatar pwithnall avatar sebras avatar sgpthomas avatar sirredbeard avatar stunkymonkey avatar suzie97 avatar tytan652 avatar victorenator avatar weblate avatar welaq avatar wellinkstein avatar wezm avatar xarbit avatar xpih avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

communique's Issues

Fails to compile on Alpine

Describe the bug

When compiling on Alpine with ninja -C builddir, the build fails with:

[15/161] Compiling Vala source ../plugins/backend/fresh/freshAPI.vala ../plugins/backend/fresh/freshInterface.vala ../plugins/backend/fresh/freshUtils.vala ../plugins/backend/fresh/freshConnection.vala FeedReader.vapi
ninja: job failed: cc -Icom.github.suzie97.communique.p -I. -I.. -Ilibraries/libIvy -I../libraries/libIvy -Ilibraries/libgtkimageview -I../libraries/libgtkimageview -Ilibraries/htmlclean -I../libraries/htmlclean -Ilibraries -I../libraries -Idata -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/libdrm -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/json-glib-1.0 -I/usr/include/libsoup-2.4 -I/usr/include/libxml2 -I/usr/include/gee-0.8 -I/usr/include/libsecret-1 -I/usr/include/rest-0.7 -I/usr/include/webkitgtk-4.0 -I/usr/include/gstreamer-1.0 -I/usr/include/orc-0.4 -I/usr/include/libpeas-1.0 -I/usr/include/gobject-introspection-1.0 -I/usr/include/goa-1.0 -I/usr/lib/goa-1.0/include -I/usr/include/granite -I/usr/include/libhandy-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -w -O0 -g -pthread -g -w -rdynamic -Wno-deprecated-declarations '-DVERSION="undefined"' '-DGETTEXT_PACKAGE="com.github.suzie97.communique"' '-DGNOMELOCALEDIR="/usr/local/share/locale"' -DGOA_API_IS_SUBJECT_TO_CHANGE -include FeedReader.h -MD -MQ com.github.suzie97.communique.p/meson-generated_src_FeedReaderMain.c.o -MF com.github.suzie97.communique.p/meson-generated_src_FeedReaderMain.c.o.d -o com.github.suzie97.communique.p/meson-generated_src_FeedReaderMain.c.o -c com.github.suzie97.communique.p/src/FeedReaderMain.c
../src/FeedReaderMain.vala: In function 'feed_reader_main_main':
../src/FeedReaderMain.vala:94:31: error: assignment of read-only variable 'stdout'
   94 |                         var old_stdout =(owned)stdout;
      |                               ^
com.github.suzie97.communique.p/src/FeedReaderMain.c:28:52: error: assignment of read-only variable 'stdout'
   28 | #define _fclose0(var) ((var == NULL) ? NULL : (var = (fclose (var), NULL)))
      |                                                    ^
../src/FeedReaderMain.vala:95:24: note: in expansion of macro '_fclose0'
   95 |                         stdout = FileStream.open("/dev/null", "w");
      |                 ^       ~~~~~~~
../src/FeedReaderMain.vala:95:31: error: assignment of read-only variable 'stdout'
   95 |                         stdout = FileStream.open("/dev/null", "w");
      |                               ^
com.github.suzie97.communique.p/src/FeedReaderMain.c:28:52: error: assignment of read-only variable 'stdout'
   28 | #define _fclose0(var) ((var == NULL) ? NULL : (var = (fclose (var), NULL)))
      |                                                    ^
../src/FeedReaderMain.vala:97:24: note: in expansion of macro '_fclose0'
   97 |                         stdout =(owned)old_stdout;
      |                 ^       ~~~~~~~
../src/FeedReaderMain.vala:97:31: error: assignment of read-only variable 'stdout'
   97 |                         stdout =(owned)old_stdout;
      |                               ^
sqlite3.vapi:34.59-34.76: warning: Use of possibly unassigned parameter `errmsg'
   34 | 		public int exec (string sql, Callback? callback = null, out string? errmsg = null) {
      | 		                                                        ^~~~~~~~~~~~~~~~~~
sqlite3.vapi:54.90-54.107: warning: Use of possibly unassigned parameter `errmsg'
   54 | 		public int get_table (string sql, out string[] resultp, out int nrow, out int ncolumn, out string? errmsg = null) {
      | 		                                                                                       ^~~~~~~~~~~~~~~~~~

To Reproduce

This should be unrelated, but I've patched out the dependency on execinfo.h with the following patch:

diff --git a/libraries/libIvy/Extractor.vala b/libraries/libIvy/Extractor.vala
index 9111ef1f..f82faf78 100644
--- a/libraries/libIvy/Extractor.vala
+++ b/libraries/libIvy/Extractor.vala
@@ -398,16 +398,8 @@ namespace Ivy {
                                        trace.is_all_function_name_blank = true;
                                        trace.is_all_file_name_blank = true;

-                                       // TODO fix that > 0.26
-                                       #if VALA_0_26 || VALA_0_28
-                                       var size = Linux.Backtrace.@get (array);
-                                       var strings = Linux.Backtrace.symbols (array);
-                                       #else
-                                       int size = Linux.backtrace (array, frame_count);
-                                       unowned string[] strings = Linux.backtrace_symbols (array, size);
-                                       // Needed because of some weird bug
-                                       strings.length = size;
-                                       #endif
+                                      var size = 0;
+                                      string[] strings = new string[0];

                                        int[] addresses = (int[])array;
                                        string module = get_module_name ();

Expected behavior

Program compiles successfully

Platform Information

Compiled master branch and v1.2.0, on Alpine edge.

Add the option to auto-start Communique in the background

Problem

Adding Communique to the startup applications will launch the whole application.

Proposal

Communique should be able to start in the background when the computer boots.

Prior Art

Some appcenter apps like elementary calendar, clips, reminduck etc.

Update GNOME runtime

Problem

As I trigger my flatpak update script, it says:
Info: org.gnome.Platform//41 is end-of-life, with reason:
The GNOME 41 runtime is no longer supported as of September 17, 2022. Please ask your application developer to migrate to a supported platform.
Applications using this runtime:
com.github.suzie97.communique

Proposal

Update the GNOME runtime to something newer, so the flatpak updater becomes happy about it.

Crashes with FreshRSS set up

Describe the bug

It seems like once it tries to fetch updates from my FreshRSS server it just hangs and then after a while the "Force Quit" dialog pops up

Platform Information

I'm using a fresh install of ElementaryOS and I have ran all the updates available

Podcast player

Problem

Currently, Communique does not support playing podcasts.

Proposal

Many modern RSS feed readers also support podcasts, including Nextcloud News, which you can sign in on Communique.

Prior Art

(List any relevant examples of how others have implemented this feature)
These feed readers can do this;

404 Page Not Found Error when setting up Inoreader

Describe the bug

404 Page Not Found Error when setting up Inoreader

I hit the Back button and tried connecting to Inoreader again and succeeded the second time.

To Reproduce

  1. Click gear icon to get set up
  2. Choose Inoreader as my Feed reader
  3. Login via google authentication
  4. 404 page not found error displays

Expected behavior

After logging into Inoreader I see my feeds.

Screenshots

communique-404-page-not-found

Platform Information

Linux ThinkPad 5.13.0-27-generic #29~20.04.1-Ubuntu SMP Fri Jan 14 00:32:30 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
NAME="elementary OS"
VERSION="6.1 Jólnir"
ID=elementary
ID_LIKE=ubuntu
PRETTY_NAME="elementary OS 6.1 Jólnir"
LOGO=distributor-logo
VERSION_ID="6.1"
HOME_URL="https://elementary.io/"
DOCUMENTATION_URL="https://elementary.io/docs/learning-the-basics"
SUPPORT_URL="https://elementary.io/support"
BUG_REPORT_URL="https://github.com/elementary/triage/issues/new"
PRIVACY_POLICY_URL="https://elementary.io/privacy-policy"
VERSION_CODENAME=jolnir
UBUNTU_CODENAME=focal

Can't remove broken share accounts

Describe the bug

I had some trouble logging into Pocket while setting it up for sharing from Communique, and tried adding Pocket repeatedly. Eventually I realized the problem was with my Pocket account and not just the authentication process, reset my password there, and successfully added Pocket to my account.

But I still had 5 Pocket accounts in the Share menu that all said "403 Unauthorized." They didn't appear in the settings, so I couldn't delete them from there. I ended up tracking down the config file and deleting them from there, and now I only have the one Pocket account in the menu (and it works!), so I did find a workaround!

Expected

Broken share accounts either appear in the settings and can be deleted, or are removed automatically.

Actual

Broken share accounts cluttered up the menu, didn't appear in settings.

Platform Information

  • Fedora 37
  • Flatpak version of Communique 1.1.0

feedly secret expired

A few weeks ago the feedly API secret of FeedReader that is still used in NewsFlash expired: https://gitlab.com/news-flash/news_flash/-/issues/66

This means the feedly integration as it exists now is broken. As you can see further down in the issue report I tried to apply for a new secret and was rejected. I doubt that its worth the try to apply for a secret for Communique. Communique stores the secret as clear-text in the git-repository. And obfuscating the secret is one of the base requirements.

There is the option to let users generate and enter developer API tokens. But these are quite limited in the number of API calls per day and the time they are valid.

I came to the conclusion to drop support for feedly from NewsFlash.

[SOLVED] TT-RSS doesn't connect.

Describe the bug

Login to Tiny Tiny RSS doesn't seem to work, and doesn't give any error message back.

To Reproduce

  1. Use my (already tested) address to my tt-rss server, user and stored password
  2. Hit login
  3. Nothing happens

Expected behavior

Log in successfully (or at least give an error message explaining why it doesn't work)

Platform Information

Flatpak version 1.1.0


Should any API plugin be enabled at server side to run with communique?

Account setup should be shown on initial start

Describe the bug

I just did a fresh installation of Communique from AppCenter and then started the app. After this initial start, it tried to somehow set its state to online and the spinner in the upper left corner just spinned endlessly.

So eventually I opened the settings by clicking on the gear icon and then choose "Change Account". After confirming the warning dialog, the account setup page appeared. There I was able to successfully add my Nextcloud News account.

To Reproduce

  1. Do a fresh installation of Communique from AppCenter
  2. Start Communique
  3. You'll end up in the main interface w/o any hints about setting up a new account

Expected behavior

After Communique is freshly installed and started, it should display the "Setting up a new account" page immediately, because there is nothing else to display.

Maybe it makes sense to always display the account setup if there aren't any accounts setup - regardless if it is the first time Communique was started.

Platform Information

Latest elementary OS v6 (stable). Installed latest Communique from AppCenter.

Share to Nextcloud Bookmarks

Proposal

Just like Pocket, sharing the article to Nextcloud Bookmarks could be a great option. Since the user is already able to sign in with a Nextcloud ID, I assume it'd be easier to implement this. Tags are also supported on both Communique and NC Bookmarks.

Alternative Solutions

It's really optional and non-necessary feature.

Prior Art

Couldn't find any. 😅️

Export database as OPML file

Problem

There is no way to export the current local database and that makes it hard to sync subscriptions, favourites etc. across different machines.

Proposal

Add feature to export the local database as an OPML file. Importing OPML files is already supported.

Alternative Solutions

Using one of the supported syncing services to sync feeds between different systems.

Prior Art

Hubert Figuière has a rust script to export the FeedReader database as an OPML file, https://gitlab.gnome.org/hub/feedreader-export

Disk read and write total is too high

Describe the bug

Hi, it's me again! 😅️ As you can see below, Communique's disk write total is too high. I don't know what's causing this but let me know if I can help in any way.

To Reproduce

  1. Open the application
  2. Let it run in the background for a while (an hour or so)
  3. See that disk read and write is way too excessive for an app that's supposed to do nothing but watch new feeds.

Expected behavior

Normal amount of disk read and write

Screenshots

comm

Platform Information

ElementaryOS 6, app is installed from Appcenter.

Adding the ability to listen to a Podcast

Problem

Its possible to subscribe to Podcasts using an RSS Feed. For example 60-Second Science: http://rss.sciam.com/sciam/60secsciencepodcast

It would be great to be able to listen to a Podcast directly from Communique.

Proposal

Show audio controls to listen to the Podcast directly from within Communique if the currently selected article contains audio data.

Prior Art

Update EOL runtimes for flatpak

  • org.gnome.Platform branch 41:

    Info: runtime org.gnome.Platform branch 41 is end-of-life, with reason:
       The GNOME 41 runtime is no longer supported as of September 17, 2022. Please ask your application developer to migrate to a supported platform.
    Info: applications using this runtime:
       com.github.suzie97.communique
    

    This request would be duplicate of #25 and #29.

  • But also org.freedesktop.Platform.GL.default branch 21.08:

    Info: runtime org.freedesktop.Platform.GL.default branch 21.08 is end-of-life, with reason:
       org.freedesktop.Platform 21.08 is no longer receiving fixes and security updates. Please update to a supported runtime version.
    Info: applications using this extension:
       com.github.suzie97.communique
    

Thanks!

Make unread bubbles less huge

Proposal

I think the unread bubbles (see screenshot) are too big, they should be more embedded into the list element, they hit the borders of the list element which just looks messy and unnecessarily huge IMHO

image

Images don't show up

Describe the bug

No images load up. This occurs only with some feeds (elementary OS for example does not show images), thus I don't know whether it is this app's problem or the feed's:
image

To Reproduce

  1. Add the elementary OS feed
  2. Click on any article - no images should load

Expected behavior

Pictures should load.

Platform Information

image

Local RSS looks ugly

Screenshot from 2021-09-15 09-08-31

  • The RSS symbol could be orange (maybe, not 100% on that one)
  • "Communi...", that's just ugly, either reduce the font, or remove the half-word <--
  • Local RSS is OK
  • The whole thing looks too big

It's just a detail, definitely not a reason not to use the app, but it did annoy me a bit

Beautiful app, where to donate?

I'd like to contribute to your project because I liked it very much. Please show me a way to make a donation (no PayPal please). Thank you for this amazing app.

Won't let me add feeds and won't load.

Describe the bug

I open the app and it keeps loading and saying it's "Offline". It won't let me add any feeds.

To Reproduce

I just opened the app.

Expected behavior

I thought It would prompt me to add feeds.

Screenshots

offline

Platform Information

I am currently using GeckoLinux Rolling with Pantheon Desktop

sorting of feeds; and, sync interval

I am new to comminque.

  1. How do I sort the feeds in ascending alphabetical order by feed title?

  2. How frequently does comminque sync itself with the nextcloud server? How do I control that interval?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.