Code Monkey home page Code Monkey logo

Comments (3)

decanus avatar decanus commented on July 28, 2024 1

@Ro5s not sure if it has any gas impact but you can do masterDeployer.bento.selector just so its a bit more readable.

from trident.

Ro5s avatar Ro5s commented on July 28, 2024

this seems like an easy optimization to refactor and check out - so you are suggesting we might turn calls to BentoBox and similar into low-levels? (similar to how we do safeTransfer and balance checking?) **Edit: Similarly, it looks like we can reduce cost on Pool deployment by doing low-level calls to fetch variables from MasterDeployer:
image

from trident.

Ro5s avatar Ro5s commented on July 28, 2024

thanks @decanus -- solid tip, and I agree that looks much better. I believe in order to define the selector like that (in the above case, bento) we would need to include an interface (masterDeployer) into Pool code. This isn't that big of a deal, but I think we can get away with low-code approach here, though I do regret not having a more legible low-level call.

from trident.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.