Identifier uniqueness isn't enforced about trident HOT 2 OPEN

uniqueness shouldn't be hard to enforce by adding a check in MasterDeployer and the addToWhitelist function (& storing the identifier for each pool (factory)). So, no extra costs to Trident users. Though, arguably, we likely can avoid these errors in careful mgmt of this role.

from trident.

uniqueness shouldn't be hard to enforce by adding a check in MasterDeployer and the addToWhitelist function (& storing the identifier for each pool (factory)). So, no extra costs to Trident users. Though, arguably, we likely can avoid these errors in careful mgmt of this role.

Agree. My thoughts were the same, either enforce this on MasterDeployer, or expect that we'd never add a pool type with the same identifier but with different logic (this is why versioning would be nice), none the less there's potential for human error to creep in here which is why the point was made.

from trident.