surjithctly / astroship Goto Github PK

I have a couple of minor accessibility improvements to your theme and wonder if you would be open to me creating a PR?

(main) $ npm run dev

> [email protected] dev
> astro dev

  🚀  astro  v2.10.12 started in 4949ms
  
  ┃ Local    http://localhost:3000/
  ┃ Network  use --host to expose
  
12:13:26 AM [content] Watching src/content/ for changes
12:13:27 AM [content] Types generated
12:13:27 AM [astro] update /.astro/types.d.ts

Result: HTTP ERROR 401

Hi

I cloned this repo, did npm install and npm run dev. When the site is running locally it is displaying for mobile. When I resize the browser window it is also not responsive. I can see the wide layout appear when I go to devices in dev tools but do not get the wide layout normally. When I go to the demo site link it appears ok. Is this behaviour by design when running locally?

Something seems wrong here?

Can anyone help me please

Hi im getting this error when i run npm start:

PS D:\Users\Usuario\Downloads\eef8e25d-30cb-472e-a467-6301fdd70b05\Production\astroship> npm start

@example/[email protected] start
astro dev

astro v1.9.2 started in 1638ms

┃ Local http://localhost:3000/
┃ Network use --host to expose

node:internal/process/promises:288
triggerUncaughtException(err, true /* fromPromise */);
^

[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "fetch failed".] {
code: 'ERR_UNHANDLED_REJECTION'
}

help please

Hello,

I am trying to import more images into md like this:

![Image1](/src/assets/images/california/image1.jpg) ![Image2](/src/assets/images/california/image2.png)

but the images won't appear on production via vercel. However, locally the images work fine.

I was wondering if anyone knew of a fix or solution to this issue. Your input would be much appreciated!

Thanks!

Hi, what do you mean by "Up to 20 users" ? 20 engineers ? 20 projects? 20 team members? 20 customers ?Thanks

I noticed that the about team page photos don't render in Microsoft Edge browser. You most probably what to use a Picture component.

I'm using a pretty stock version (no pnpm) on my local and it builds fine. Is there a way to remove pnpm so that it doesn't try to build from that on Vercel?

ERR_PNPM_OUTDATED_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with package.json
--
22:55:00.873 |  
22:55:00.873 | Note that in CI environments this setting is true by default. If you still need to run install in such cases, use "pnpm install --no-frozen-lockfile"
22:55:00.874 |  
22:55:00.874 | Failure reason:
22:55:00.874 | specifiers in the lockfile ({"@astrojs/image":"^0.17.2","@astrojs/mdx":"^0.19.7","@astrojs/sitemap":"^2.0.1","@astrojs/tailwind":"^4.0.0","@fontsource-variable/inter":"^5.0.5","@tailwindcss/typography":"^0.5.9","astro":"^2.9.7","astro-icon":"^0.8.1","astro-navbar":"^2.0.1","astro-seo":"^0.7.5","sharp":"^0.32.4","tailwindcss":"^3.0.24"}) don't match specs in package.json ({"@astrojs/image":"^0.17.2","@astrojs/mdx":"^0.19.7","@astrojs/sitemap":"^2.0.1","@astrojs/tailwind":"^4.0.0","@fontsource-variable/inter":"^5.0.5","@tailwindcss/typography":"^0.5.9","astro":"^2.9.7","astro-icon":"^0.8.1","astro-navbar":"^2.0.1","astro-seo":"^0.7.5","sharp":"^0.32.5","tailwindcss":"^3.0.24"})
22:55:00.903 | Error: Command "pnpm install" exited with 1

Hi nice theme. Is pagination out of the box for the blog page?

@surjithctly I was wondering if you'll be upgrading this to Astro 2.0 soon. If it already works with 2.0 please let me know. Thanks!

Seems like something broke with commit 5f36154, the introduction of Astro 2.9.7. From then on, I can't get drop downs to work in nav bars.

It would be awesome if there was support for grouping blog posts according to category/tag. Unfortunately I can't implement this right now and open a PR, but here's a suggestion in case someone wants to do it.

 WARN  Issues with peer dependencies found
.
├─┬ @astrojs/mdx 0.16.0
│ └─┬ @mdx-js/rollup 2.2.1
│   ├── ✕ missing peer rollup@>=2
│   └─┬ @rollup/pluginutils 5.0.2
│     └── ✕ missing peer rollup@^1.20.0||^2.0.0||^3.0.0
└─┬ @astrojs/vercel 3.1.2
  └─┬ @vercel/analytics 0.1.9
    └── ✕ missing peer react@^16.8||^17||^18
Peer dependencies that should be installed:
  react@^16.8||^17||^18                      rollup@">=2.0.0 <3.0.0 || >=3.0.0 <4.0.0"  

Done in 2.1s

The last one about react missing is because I added the vercel SSR integration, though I did that through pnpm astro add vercel and would think it would have worked that out.

Will the template upgrade to the app directory ? Or need any help with it?

Not sure if it's a good idea or not, but Astro gives you the option to create your own custom 404 page. The docs:
https://docs.astro.build/en/core-concepts/astro-pages/#custom-404-error-page

How about we add a simple 404.astro to this template? Some of the reasons for this IMO are:

1. A custom 404 page makes any site feel a little more user-friendly
2. It's a great way to show someone new to Astro that such option (having a custom 404 page) even exists
3. It's easy to delete in case you don't want to have one

Anyway, what are your thoughts on this? I'm building one right now for my personal portfolio (based on Astroship), so I can probably submit a PR pretty easily

Great Astro Theme.
Noticed that the spaceship hero image does not render on Microsoft Edge browser on Win 11.
Works fine in Firefox, but as Edge has about 10% market share it might worth providing alternate format.

browser: chrome / latest (font size: 18)

I don't know if it's the desired.

If it's not I think it could be changend by using same classes as the box below, it doesn't seem to casuse any trouble with responisvness

The active link at the navbar it's a nice feature.
I would like to contribute to the template.
I'm learning Alpinejs seems like a nice place to start.
Let me know your thoughts.
If you can point the direction I'll work on PR.

Can you suggest and guide me on how to add a newsletter? I saw the contact form but didn't understand how would I make API calls on that. I am still learning Astro.

Free version scores 100 but pro version scores in 80s, such a huge speed difference.
https://pagespeed.web.dev/analysis/https-astroship-pro-web3templates-com/5f4balshzj?form_factor=mobile

It beats the purpose of migrating from react/nextjs to a modern high performance claiming framework like Astro.
I am sure we are missing something fundamental in here.
Look at https://github.com/onwidget/astrowind it scores 100

Hi,

I am a little bit lost in terms of proper attribution for usage of the template.

Is Website was created using Astroship template info in the footer with a link to Github repo enough?

Or should I add additional info? 🤔