supernova-studio / exporter-style-dictionary Goto Github PK

Describe the bug
When targeting Github for a build, target repo cannot have a branch named supernova or the PR creation will fail with the error:

Error exporting to github: Error: fatal: cannot lock ref 'refs/heads/supernova/style-dictionary': 'refs/heads/supernova' exists; cannot create 'refs/heads/supernova/style-dictionary'

I think this is because the exporter tries to create a supernova/style-dictionary branch to do its work on?

Once I removed the supernova branch on that repo, the export worked fine.

Expected behavior
There probably shouldn't be a magically prohibited branch name in the target repo, and especially not supernova. This error happened when I added a new supernova branch to my repo to test... well, Supernova :)

Maybe instead of creating a branch called supernova/style-dictionary, it could be something randomly-generated or ID-based, like supernova-exporter-{workspaceId or UUID}/style-dictionary}, to remove the possibility of an unintentional conflict?

Screenshots

Describe the bug
Tokens defined within "Other" category are not exported

Expected behavior
When the tokens are being exported, a corresponding file should be created for "Other" tokens.

Screenshots
Not applicable.

Additional context
Hello Supernova team! I have defined several tokens within the "Other" category, and I expect them to be exported as all the other categories are. Unfortunately, it does not work as I expect. Could you explain why? I also noticed the same behavior with all the other officially supported exporters.

I'm experiencing an issue when I reference tokens in the measures.json file.

In my solution I generate some global tokens where I reference tokens from the measures.json file.
I use the style-dictionary npm package (https://github.com/amzn/style-dictionary) to transform the tokens to CSS.

The exporter's JSON format wraps token values in a value property, which breaks the reference logic in the style-dictionary package. The logic looks for a value property in the reference path to the token (ex. {measure.dimension.space.spacing-none.value.measure.value}), and deletes the property.
Because the value property is deleted, the reference to the token breaks, so the build fails.

In the exporter code, would it be possible to change the wrapper property name here:

to maybe values?

So the output would look something like this:

{
  "measure": {
    "dimension": {
      "space": {
        "spacing-00": {
          "values": {
            "measure": {
              "type": "size",
              "value": 0
            },
            "unit": {
              "type": "string",
              "value": "pixels"
            }
          },
          "type": "measure"
        },
        "spacing-01": {
          "values": {
            "measure": {
              "type": "size",
              "value": 2
            },
            "unit": {
              "type": "string",
              "value": "pixels"
            }
          },
          "type": "measure"
        }

I hope that the explanation is clear enough.
If not, let me know.