superbuker / terraform-provider-dns-he-net Goto Github PK

I'm trying to create multiple a-records. I populate an array with values:

locals {
  he_net_test = {
    "test1" = {
      Hostname   = "test1"
      Domainname = "subdomain.domain.tld
      IPAddress  = "192.168.88.35"
    }
    "test2" = {
      Hostname   = "test2"
      Domainname = "subdomain.domain.tld"
      IPAddress  = "192.168.88.36"
    }
  }
}

I then apply those values to a resource:

resource "dns-he-net_a" "containers" {
  for_each = local.he_net_test
  zone_id  = 123456
  domain   = format("%s.%s", each.value.Hostname, each.value.Domainname)
  ttl      = 86400
  data     = each.value.IPAddress
}

But this fails with:

| Error: Invalid A record configuration
│
│   with dns-he-net_a.containers,
│   on dns.tf line 37, in resource "dns-he-net_a" "containers":
│   37: resource "dns-he-net_a" "containers" {
│
│ Static A records must have Data configured.

This passes plan, though:

resource "dns-he-net_a" "containers" {
  for_each = local.he_net_test
  zone_id  = 123456
  domain   = format("%s.%s", each.value.Hostname, each.value.Domainname)
  ttl      = 86400
  data     = "192.168.1.2"
}

(but will configure the wrong IP address)

Is your feature request related to a problem? Please describe.
User can't validate on the client the record fields values.

Only once the client makes a request to the server the validation is performed, this can abort the in progress deployment.

Describe the solution you'd like
Introduce validation on the client side, for each record type.

Additionally, it would be nice to hace a server side dry-run mode, but this depends on he.net.

Describe alternatives you've considered
Keep it as it is and cross your fingers.

Is your feature request related to a problem? Please describe.
The api client currently isn't currently using the a terraform logger

Describe the solution you'd like
Add the option to add a custom logger.

Describe alternatives you've considered
Integrating the terraform logger, but it this really needs to be properly decoupled.

Additional context
It might be great to log the "status" responses.
<div id="dns_status" onclick="hideThis(this);">Successfully added new record to dns-he-net.ovh</div>

Is your feature request related to a problem? Please describe.
The current user agent is generic and makes this tool requests difficult to identify in the server logs.

Describe the solution you'd like
Define a custom user agent instead of the current go-resty one.
Additionally, add support to "TF_APPEND_USER_AGENT".

Additional context
The usage of TF_APPEND_USER_AGENT is explained here:
https://registry.terraform.io/providers/hashicorp/aws/latest/docs#custom-user-agent-information
TF code example: https://github.com/hashicorp/terraform/blob/main/internal/httpclient/useragent.go

TODO:

• Add go generate for the documentation
• Add documentation in the provider/resources/datasources
• Add automatically generated documentation
• Add examples