sunrise-php / http-header-kit Goto Github PK

Sunrise\Http\Header\HeaderCollection class does not exist in repository.

https://github.com/sunrise-php/http-header-kit#http-header-collection

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update cimg/php Docker tag to v8.1

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

What do you think about a helper method that takes your classes and returns an array of formatted headers suitable for the ServerRequest?

$headers = \Sunrise\Http\Headers::make([
    new HeaderCookie('whatever'),
    new HeaderContentEncoding('multipart/form-data')
    new HeaderSomethingElse('foo')
]);
$request = new ServerRequest('POST', 'https://example.com', $headers, 'Whatever');

Hi. Thanks for http-header-kit. Tons of handy tools in here.
A couple of related questions

https://github.com/sunrise-php/http-header-kit/blob/master/src/AbstractHeader.php#L26 has @inheritdoc but it does not inherit from anything.

If I do something like this

$handler = new class implements RequestHandlerInterface {
    public function handle(\Psr\Http\Message\ServerRequestInterface $request): \Psr\Http\Message\ResponseInterface
    {
        $response = new \GuzzleHttp\Psr7\Response(200, [], 'Hello world');
        $response = (new \Sunrise\Http\Header\HeaderContentType('text/plain'))->setToMessage($response);
        return $response;
    }
};

phpstan and phpStorm both complain that $response is a MessageInterface instead of a ResponseInterface

Would you consider changing the return types in AbstractHeader to eg

	/**
	 * @return MessageInterface|RequestInterface|ServerRequestInterface|ResponseInterface
	 */
	public function setToMessage(MessageInterface $message);

to keep these tools happy?

or (alternatively) providing strictly typed variants eg

	/**
	 * @return ServerRequestInterface
	 */
	public function setToServerRequest(ServerRequestInterface $message): ServerRequestInterface;

and similar for MessageInterface, ResponseInterface, RequestInterface etc

What about Sunset also? https://tools.ietf.org/id/draft-wilde-sunset-header-03.html

Originally posted by @cjunge-work in #1 (comment)

• Custom
• Accept
• Accept-Charset
• Accept-Encoding
• Accept-Language
• Accept-Ranges
• Access-Control-Allow-Credentials
• Access-Control-Allow-Headers
• Access-Control-Allow-Methods
• Access-Control-Allow-Origin
• Access-Control-Expose-Headers
• Access-Control-Max-Age
• Access-Control-Request-Headers
• Access-Control-Request-Method
• Age
• Allow
• Alt-Svc
• Authorization
• Cache-Control
• Clear-Site-Data
• Connection
• Content-Disposition
• Content-Encoding
• Content-Language
• Content-Length
• Content-Location
• Content-MD5
• Content-Range
• Content-Security-Policy
• Content-Security-Policy-Report-Only
• Content-Type
• Cookie
• DNT
• Date
• Early-Data
• Etag
• Expect
• Expect-CT
• Expires
• Forwarded
• From
• Host
• If-Match
• If-Modified-Since
• If-None-Match
• If-Range
• If-Unmodified-Since
• Index
• Keep-Alive
• Last-Modified
• Link
• Location
• Origin
• Proxy-Authenticate
• Proxy-Authorization
• Public-Key-Pins
• Public-Key-Pins-Report-Only
• Range
• Referer
• Referrer-Policy
• Refresh
• Retry-After
• Sec-WebSocket-Accept
• Server
• Server-Timing
• Set-Cookie
• SourceMap
• Strict-Transport-Security
• Sunset
• TE
• Timing-Allow-Origin
• Tk
• Trailer
• Transfer-Encoding
• Upgrade-Insecure-Requests
• User-Agent
• Vary
• Via
• WWW-Authenticate
• Warning
• X-Content-Type-Options
• X-DNS-Prefetch-Control
• X-Frame-Options
• X-XSS-Protection