Is anyone else having this issue? Sometimes when engages ACC the gas pedal doesn’t engage. I also have a comma pedal.

Describe the bug

ev6 2022 hda2
sunny pilot 0.9.4
comma 3x
An error message appears when the preceding vehicle stops and departs while using SunnyPilot. CAN Bus Disconnected: Likely Faulty Cable
Every time an error

Which car does this affect?

기아 ev6 2022

Provide a route where the issue occurs

11111

openpilot version

0.9.4.1

Additional info

I've done some tests so far, and if I run a sunny pilot while using i-pelal, a cable error message will occur at the time of departure after stopping

2022 Hundai ioniq 5 (soundeast asia model)
In Gap Adjust Cruise setting, I can't switch gap mode from steering wheel but only on touch screen UI.

Separate issue to track in project in response to #32

I installed using installer.comma.ai/sunnyhaibin/test-c3 (sunny pilot 2022.11.13/test-c3/f34deb6/Nov 13) and got a car not supported error. It directed me to the SP Vehicles menu to manually select my car (2023 Toyota Highlander). The SP Vehicles list only lists Highlanders up to model year 2022. I have a comma3 (dongle ID 9EF0 941B E9F8 057D). It works fine on a 2017 Highlander (which I traded in for the 2023 Highlander).
I tried the standard openpilot release at openpilot.comma.ai, but also get the same unsupported car error. I ordered a new harness, which looks identical to the old one. The same problem occurs for either harness. I made a note in the discussion section of openpilot, but haven't seen any replies for several days.
Any ideas you may have would be greatly appreciated. I look forward to being able to use my comma3 again. I will be glad to send any additional info/pictures you need.

Thanks.

Is it possible to enable speed spoof like jve? I love sunny but want this feature. Can I donate?

Add GPX upload with OpenStreetMap integration. Big thanks to DragonPilot!

Hi I was checking out your fork deciding whether it could be a good fit on my 2019 VW Golf. I saw that it's not in the list of manufacturers at the top of the README, but there is mention of some features like custom stock longitudinal control working for VW MQB. So I'm a little bit confused, is there support for my golf, or is it not recommended? Cheers!

When switching back to test-c3-apollo branch it works fine but something brakes with test-c3.

Error logs show "0x1FA NOT SEEN" from opendbc/can/parser.cc

Thanks for your development,
I ran into the problem of "slow frame rate" while referencing your code.
The cause of this problem is ButtonsWindow::updateState().

It was solved by modifying it as follows

void ButtonsWindow::updateState(const UIState &s) {
if (m_dynamic_lane_profile != s.scene.dynamic_lane_profile) {
m_dynamic_lane_profile = s.scene.dynamic_lane_profile;
if (s.scene.dynamic_lane_profile == 0) {
dlpBtn->setStyleSheet(QString("font-size: 45px; border-radius: 100px; border-color: %1").arg(dlpBtnColors.at(0)));
dlpBtn->setText("Lane\nonly");
}
else if (s.scene.dynamic_lane_profile == 1) {
dlpBtn->setStyleSheet(QString("font-size: 45px; border-radius: 100px; border-color: %1").arg(dlpBtnColors.at(1)));
dlpBtn->setText("Lane\nless");
}
else if (s.scene.dynamic_lane_profile == 2) {
dlpBtn->setStyleSheet(QString("font-size: 45px; border-radius: 100px; border-color: %1").arg(dlpBtnColors.at(2)));
dlpBtn->setText("Auto\nLane");
}
}
}

I'm afraid that I have had to revoke the OAuth token you are using to upload traces to OpenStreetMap. There are several reasons for this:

• Firstly you have committed a bearer token which gives access to the API under your account to this repository which is not acceptable - bearer tokens should be treated as secret as they given access to operate (in limited ways) as you.
• Secondly you are uploading vast numbers of traces under one account that is using an email address that cannot in any way handle the number of upload notifications it is getting which is causing yahoo to block our email server which is impacting other users and causing thousands of emails at a time to get stuck in our queue.

Please do not attempt to reauthorise your application using a new token without first addressing these issues.

Caused by subscripting the car state cruise buttons. Fixed here twilsonco/openpilot@16054d0

Problem:

The phrase "Turn on" in the context of a toggle and its label including"Disable" aren't clear.

Reference:

What is written in the ReadMe:
**Disable Onroad Uploads** - Disable uploads completely when onroad. Necessary to avoid high data usage when connected to Wi-Fi hotspot.

What is written on device in the SP-General Menu:
**Disable Onroad Uploads** - Disable uploads completely when onroad. Necessary to avoid high data usage when connected to Wi-Fi hotspot. Turn on this feature if you are looking to utilize map-based features, such as Speed Limit Control (SLC) and Map-based Turn Speed Control (MTSC).

Suggestion:

**Disable Onroad Uploads** - Disable uploads completely when onroad. Necessary to avoid high data usage when connected to Wi-Fi hotspot. Do not enable this toggle if you are looking to utilize map-based features, such as Speed Limit Control (SLC) and Map-based Turn Speed Control (MTSC).

Assumptions:

1. Onroad Uploads are a hard requirement for Map-based features

2. Map-based features, in nature will result in higher bandwidth/data usage

To support 2023 Santa Fe HEV, add the following lines to values.py

transmission:
b'\xf1\x8795441-3D120\x00\xf1\x89E16\x00\x00\x00\x00\x00\x00\x00\xf1\x82TTM2H16SA3',

engine
b'\xf1\x87391312MTL0',

I updated and noticed steer to 0 is missing. Will it be back? If not can you give me some insight on the pull request where it was removed. Thanks. Love your fork!

Version: 8.14
Model: Prius Prime 22"

Hi,
I take comma off because I don't want to leave expensive items in the car.
If I turn off my car and unplug USB-C from comma, it will show LTA unavailable warning sound.
But if turn off car for a while, and unplug it, it won't show and alert it.

Cruise fault will happen anytime pressing resume button with acc while at a standstill, will not happen if I tap the gas(will resume perfectly fine if I do). Car will jerk a little before engaging the breaks, and even sometimes the parking brake if you continue to press resume. On stock open pilot it will just say cannot resume below 3mph and give no faults.

Example on Sunny

Add Dev UI on screen while driving with the following metrics (if applicable):

• Lead car relative distance
• Lead car relative speed
• Actual steering degree
• Desired steering degree
• Engine RPM
• Longitudinal acceleration
• Lead car actual speed
• EPS torque
• Current altitude
• Compass direction

Sharing some trace info for these errors

Hello, Thanks for a great version of openpilot with wonderful features!

I was curious if there were plans to expand the Enhanced Speed Control to Toyota/Lexus models.

I can help test if needed.

Car Make: Lexus
Car Model: NX300
Car Year: 2018
Hardware: Comma Three

Thanks,
Mark

Could you make it possible to enable the "experimental mode" toggle in settings for unsupported cars? My car does not support OP e2e long, so I cannot enable experimental mode. It's simply greyed out. I'd still like to use the red/green light chime that was added in 20221207. Or maybe enable the chime and indicator toggles regardless of experimental mode.

Thanks, keep up the good work!

As title, after I install 0.8.12-prod-full-honda, and it showed car unrecognised

Add a toggle to allow engaging both ACC and MADS with a single press of RES+ or SET- button.

Describe the bug

I get a warning about the front collision warning on the dev-c3 branch. I wasn’t getting this before the last few updates and don’t get it on the main branch of openpilot.

Which car does this affect?

Hyundai Ioniq 5

Provide a route where the issue occurs

f2a5efadd1dbf33 | 7C2023-10-07--20-20-34

openpilot version

0.9.4

Additional info

No response

2020 palisade with sunnyhaibin none personal keeps getting data sensor issue after install. Won’t engage it also says unable to detect car closes car is 2020 palisade.

Describe the bug

Hello.
I'm using the Sunny Pilot well.

my car is kia ev6 with hda2 / 2022

However, if you restart after stopping, there will be a bug.

"Can Bus Disconnected:Likely Faluty Cable"

I thought it was a cable problem, so I replaced all the cables
Occasionally occurs when restarting after stopping.

What should I do?

I'm sorry to ask for your help every time.

Thank you.

Which car does this affect?

ev6 with hda

Provide a route where the issue occurs

I don't know

openpilot version

relase-c3/staging-c3/dev-c3

Additional info

No response

Describe the bug

My understanding is sunnypilot defaults to uploading GPS traces to osm.org and allows an opt-out in the settings. These GPS traces contain vehicle make, model, year, and detailed position information that can reveal user information like home locations, work locations, where they visit, and other personal information.

The OSMF LWG is concerned that the data being uploaded is from users who have automatically been opted in to this and do not realize what they are publishing.

For automatic opt-in uploading, the traces would need to be sufficiently anonymized that personal information is not present, likely by some form of aggregation and truncation. I'm not sure what would meet those requirements.

A better option would be to default to not uploading traces, and making it opt-in. Then when a user opts in to uploading, they know that they are doing so and providing personal data.

Provide a route where the issue occurs

N/A

openpilot version

N/A

Additional info

No response

Describe the bug

Custom ACC can be toggled but it doesn't seem to change the behavior of stock ACC on Mazda CX5 2023.
Also, experimental mode cannot be toggled.

Which car does this affect?

Mazda CX-5 2023

Provide a route where the issue occurs

n/a

openpilot version

0.9.2

Additional info

No response

Describe the bug

When I have lateral enabled, comes to a complete stop and quickly let the car roll forward. I get the STEERING TEMPORARILY UNAVAILABLE and I can't reengange until I turn off and on the car. I also get the TAKE CONTROL IMMEDIATELY. I tried with dev-c3 and staging-c3, both have the same issue.

I don't have an official device (I'm using Mr.One clone), so I can't upload the logs to comma, but here are them: https://drive.google.com/drive/folders/1LBR7k8OQbNT3fRMk9xr8j5WiCA9X5g0z?usp=sharing

Which car does this affect?

VW Taos 2023

Provide a route where the issue occurs

https://drive.google.com/drive/folders/1LBR7k8OQbNT3fRMk9xr8j5WiCA9X5g0z?usp=sharing

openpilot version

d64b95d

Additional info

No response

Describe the bug

First of all, thank you for contributing GPS traces to OpenStreetMap. We'd like to bring the discussion in openstreetmap/operations#931 to your attention. Right now, sunnypilot is the TOP 1 contributor of GPS traces according to https://planet.openstreetmap.org/statistics/data_stats.html, with more than 10 billion trace points created on OpenStreetMap GPS trace database. This is putting a lot of pressure on our infrastructure: it has doubled the overall growth rate of our database, which includes much more than GPS traces.

When analyzing your traces, we have frequently seen that traces tend to be over-noded, which means, that they contain many more traces points than necessary for our purposes. We would therefore like you to consider simplifying GPS traces before uploading them to osm.org. This way, a trace with 6000 trace points could be easily reduced down to 20-30 trace points, with as little as 1m error. That's a factor of 100-300 in potential data reduction we've seen with data uploaded by sunnypilot.

We typically recommend to check out tools such as GPSBabel. Our wiki page https://wiki.openstreetmap.org/w/index.php?title=GPSBabel/Using_filters#Simplifying_tracks has some examples.

gpsbabel -i gpx -f way_iv.gpx  \
    -x simplify,crosstrack,error=0.001k \
    -o gpx -F merge.gpx

Code: https://github.com/GPSBabel/gpsbabel/blob/cd3cd130541f7a72706120511156c6a61e3bbcc8/smplrout.cc

Please let us know in case of further questions.

//CC: @tomhughes

Provide a route where the issue occurs

N/A

openpilot version

N/A

Additional info

No response

Hello Folks,
I have my comma 3 just for 3 days and after setting up my device and installing the stock version of open pilot 0.9.1 and using my smartphone hotspot successfully the comma 3 connected and showed "CONNECTED ONLINE "
But after that it shows that is connected to my hotspot in the network settings but it shows " CONNECT OFFLINE " in the main screen.
However at home using an external power and connected to my home wifi.
the main screen shows CONNECT ONLINE at all times.
any help please to this issue would be greatly appreciated.
Thanks.

my oneplus3t is eons20
During the installation, I was told to upgrade the system
and after the completion, I was caught in a loop of restarting

Resolves #31

People outside US are likely to have an unlimited/unthrottled data plan, and using Comma device for sharing network would be great

Change language of "Disable MADS" toggle to "Enable MADS" toggle with default to ON.

keep car stationary after 4sec in standstill and keep while not pedal pressed

Sometimes I get lkas error on jeep when going into reverse. Maybe disable acc when reverse then re enable in drive.

I am using sunnypilot well in EV6. thank you

This is an opinion regarding the discrepancy in the cluster screen under HDA2 operating conditions.

Can the curvature expression be improved on the cluster screen?

I used this installer.comma.ai/sunnyhaibin/test-c3

Manager failed to start

Traceback(most recent call last):
File",line 219, in

Describe the bug

A car control objected is expected in the create_common_events() function but missing from the call for Ford and Tesla. That argument is not in the create_common_events definition in Comma master.

Here's the thrown exception on a ford maverick

Provide a route where the issue occurs

foo

openpilot version

SP 0.9.2.2

Additional info

No response

Hello All, I've tried posting this issue a few places but have been unable to resolve the issues. Would love any advice. Thanks in Advance

Upstream's removed the toggle from Settings recently, maybe sunnypilot should have it?

krkeegan/openpilot@d29a698

Separate issue to track in project in response to #16.

Hi. I'm using C3 with Kia K5 Hybrid (2020). It has HDA1 feature, however SLC is not working.

I selected "Hyundai Sonata Hybrid 2020-22", and added fingerprint of the car on the values.py:
FINGERPRINTS = {
CAR.SONATA_HYBRID: [{
127: 8, 304: 8, 320: 8, 339: 8, 352: 8, 356: 4, 516: 8, 544: 8, 576: 8, 593: 8, 688: 6, 757: 2, 832: 8, 881: 8, 882: 8, 897: 8, 902: 8, 903: 8, 905: 8, 909: 8, 913: 8, 916: 8, 919: 8, 1040: 8, 1042: 8, 1056: 8, 1057: 8, 1078: 4, 1096: 8, 1102: 8, 1114: 8, 1136: 6, 1138: 5, 1151: 8, 1155: 8, 1156: 8, 1157: 4, 1162: 8, 1164: 8, 1168: 8, 1173: 8, 1180: 8, 1184: 8, 1186: 2, 1191: 2, 1193: 8, 1210: 8, 1225: 8, 1227: 8, 1265: 4, 1280: 8, 1287: 4, 1290: 8, 1291: 8, 1292: 8, 1294: 8, 1312: 8, 1322: 8, 1330: 8, 1339: 8, 1342: 8, 1343: 8, 1345: 8, 1348: 8, 1355: 8, 1363: 8, 1369: 8, 1371: 8, 1378: 8, 1379: 8, 1407: 8, 1419: 8, 1427: 6, 1429: 8, 1430: 8, 1446: 8, 1448: 8, 1456: 4, 1460: 8, 1470: 8, 1476: 8, 1485: 8, 1535: 8
}],
...
(Checked that it has 0x544 in the fingerprint)

Thanks.

https://github.com/sunnyhaibin/openpilot/blob/f106563174bba424f3afa0c83006fbf11034eba4/selfdrive/controls/lib/lateral_planner.py#L184

Hey Sunny,

I've simplified your DLP code a bit (too many repeated codes), could you please take a look and let me know if anything is missing?

    # Turn off lanes during lane change
    if self.desire == log.LateralPlan.Desire.laneChangeRight or self.desire == log.LateralPlan.Desire.laneChangeLeft:
      self.LP.lll_prob *= self.lane_change_ll_prob
      self.LP.rll_prob *= self.lane_change_ll_prob
    if self.get_dlp_laneless_mode(): # this is where we call the method below
     # laneline logic 
     d_path_xyz = self.LP.get_d_path(v_ego, self.t_idxs, self.path_xyz)
      self.lat_mpc.set_weights(MPC_COST_LAT.PATH, MPC_COST_LAT.HEADING, self.steer_rate_cost)
      self.laneless_mode_is_e2e = True # store auto mode value
    else:
      # laneless logic
      d_path_xyz = self.path_xyz
      path_cost = np.clip(abs(self.path_xyz[0, 1] / self.path_xyz_stds[0, 1]), 0.5, 1.5) * MPC_COST_LAT.PATH
      # Heading cost is useful at low speed, otherwise end of plan can be off-heading
      heading_cost = interp(v_ego, [5.0, 10.0], [MPC_COST_LAT.HEADING, 0.0])
      self.lat_mpc.set_weights(path_cost, heading_cost, self.steer_rate_cost)
      self.laneless_mode_is_e2e = False # store auto mode value

  # a method to decide which mode (e2e or lane) to go
  def get_dlp_laneless_mode(self):
    if self.laneless_mode == 1: # e2e
      return True
    if self.laneless_mode == 0: # lane
      return False
    elif self.laneless_mode == 2: # auto
      # only while lane change is off
      if self.lane_change_state == LaneChangeState.off:
        # lane probability too low, we switch to laneless mode
        if (self.LP.lll_prob + self.LP.rll_prob)/2 < 0.3:
          self.laneless_mode_buffer = True
        if (self.LP.lll_prob + self.LP.rll_prob)/2 > 0.5:
          self.laneless_mode_buffer = False
        if self.laneless_mode_buffer: # in buffer mode, always laneless
          return True
    return False

thanks for the awesome work! :)

Describe the bug

ev6 2022 with hda2
custom stock longitudinal control can't run

Which car does this affect?

ev6 2022 with hda2

Provide a route where the issue occurs

staging-c3

openpilot version

staging-c3

Additional info

i would like to use it