The 31daysofrefactoringinjava from sunnypatel165

31DaysOfRefactoringInJava

Most part of my job is to work on a piece of code that's already written by someone. When I read such code, I often like to think(sometimes actually do) about changing things to make the code better. And I also wonder, how a piece of code I am writing today, will be changed by someone else in future. Coz that's what a lot of jobs demand - to be able to re-use/improve/extend code already written.

So I thought of reading a bit about Refactoring, and upon googling, I came acorss this book called 31 Days of Refactoring by Sean Chambers, Simone Chiaretta. It is a great book - clear and concise. It has one lesson per day, but you can really finish the entire book in a day.

The book is originally written for .net as a language. And hence, I took up the task of learning the lessons as given in the book - one per day. But, I also started converting them to Java.

This repo is a literal translation of the book called 31 days of refactoring. Now, a lot of the lessons - like the 1st one - feel very obvious to a Java developer. Those who have read Effective Java might find this a waste! But the point is not to teach Java, it's about engendering the thought of Reafctoring and what to keep in mind while doing it yourself!

I will try to add one lesson each day!

Feel free to contribute! :D

Contributors

Stargazers

Watchers

31daysofrefactoringinjava's Issues

Poor examples on some days

The lessons of the book are really good - small and yet meaningful.
But some examples aren't as good. Maybe it's the case when converted to Java.

Day 13 java files class and README content are out of sync

The Order.java file has the fixed calculate() method, whereas the README still has the old one

Day 13 : Order class's calculate method is not pure

Calling calculate on a given Order should return the same value, regardless of how many times it is called.

The current implementation will return a new, increased value each time.

https://github.com/sunnypatel165/31DaysOfRefactoringInJava/blob/master/src/com/sunnypatel/daysofrefactoringjava/day13/extractmethodobjects/problem/Order.java#L20-L30

Add Syntax highlighting for C# code day 1 to day 10 and day 12.

C# code in the README snippets

The code snippets in the READMEs are in C#, whereas you'd expect them to be in Java.

Links in ToC of Main README have hard links

The links in your table of contents in the main README link directly to your repo. Someone with a fork to your repo cannot use the main README to navigate his own repo.

Specifically, instead of this:
[Day 1 - Encapsulate Collection](https://github.com/sunnypatel165/31DaysOfRefactoringInJava/tree/master/src/com/sunnypatel/daysofrefactoringjava/day1/encapsulatecollection)

You need to have
[Day 1 - Encapsulate Collection](src/com/sunnypatel/daysofrefactoringjava/day1/encapsulatecollection)

Will send a PR.

Recommend Projects