sulu / suluarticlebundle Goto Github PK

Actual Behavior

Exception thrown in content type will only call in twig and cant be catched.

Steps to Reproduce

A thrown exception in a content type.

Possible Solutions

Resolve the proxy object in the controller.

Actual Behavior

At the moment this options isn't provided.

Expected Behavior

Same as it works in Sulu pages.

Actual Behavior

It is not possible to delete an article.

Expected Behavior

It should be possible from list and form.

Expected Behavior

Articles should be able to load the content from another locale (like pages). The index should be updated also in live index with the shadowed data.

Actual Behavior

Currently the french translation is not complete and the netherlands translation is not even started.

Possible Solutions

Ask people from slack channel to extend the translations.

Actual Behavior

When saving an article - after changing it via e.g. a Command without setting a changer - following error is thrown:

Entity with the type "" and the id "null" not found.

Request URL:http://oelz.dev/admin/api/users/null
Request Method:GET
Status Code:404 Not Found

Expected Behavior

It should not throw an error.

Steps to Reproduce

1. Create an article and save it
2. Update / change the article via a command without setting a changer
3. Open the article in the backend and save.

Possible Solutions

Do not try to fetch a user when the changer is null or use the creator as changer.

Actual Behavior

In sulu we have implemented a single-select author. The same behavior should be in this bundle.

Should also be displayable in the list.

Actual Behavior

Actually you dont see which template is render in the symfony toolbar.

Expected Behavior

It should also be shown which template should be render in the symfony toolbar also the type: article should be shown.

Steps to Reproduce

Open the article page and hover on the symfony profiler sulu icon.

Actual Behavior

The routePath of ArticleViewDocument and ArticlePageViewObject are indexed via the standard analyzer.

Expected Behavior

In an ideal world, this property should be analyzed via an analyzer with the path_hierachy tokenizer. But the problem is that this analyzer does not exist for default in elasticsearch.

Possible Solutions

Possibility 1: We could start prepending configuration to the elasticsearch-bundle. The problem here could be that this could be hard to maintain and override.

Possibility 2: We could use a custom analyzer which has to add to the configuration (like the other config). This is not very error-tolerant but would work.

Actual Behavior

The reindex command has the option --clear which should remove all the documents before creating new once. There we use paginated remove - which does not delete all documents.

Possible Solutions

Always fetch first page.

Actual Behavior

If an article is added as a teaser it doesn't show up in the teaser-selection content type. It also doesn't appear after a save...

Expected Behavior

The list for teaser-selection should also show the assigned articles.

Steps to Reproduce

1. Create a page with a teaser selection
2. Create an article
3. Add the article on a page as a teaser
4. The article doesn't show up in the list of the teaser selection (but for pages it is working)

Actual Behavior

We have implemented the author selection overlay in this bundle.
Same code as in Sulu content bundle.
File: /Users/trickreich/Sandbox/sulu-minimal-dev/vendor/sulu/article-bundle/Resources/public/js/components/articles/edit/settings/author-selection/main.js

Expected Behavior

Remove the component and use it from Sulu when updating the dependency to Sulu 1.5.*

Actual Behavior

The tests should run with --prefer-lowest. The problem is that sulu <1.5 is not able to run the tests with lowest.

Actual Behavior

Actual Behavior

When an article gets deleted, the related path inside ro_routes isn't deleted.

Expected Behavior

The path to the deleted article should be deleted as well.

Steps to Reproduce

1. Create an article named test
2. Check ro_routes table, the generate path should be /test
3. Delete this article
4. Create a new article named test
5. path is now /test-1 because the old pathhasn't been deleted

Actual Behavior

At the moment we don't check if the type is in the request.

Expected Behavior

Proof that the article type can't be different between translations.

Actual Behavior

With two hacks it works in this bundle it. When the bug in Sulu is solved these lines could be removed:

• https://github.com/sulu/SuluArticleBundle/blob/feature/multilingual/Resources/public/js/components/articles/list/main.js#L245
• https://github.com/sulu/SuluArticleBundle/blob/feature/multilingual/Resources/public/js/components/articles/edit/main.js#L195

Expected Behavior

Same as in Sulu issue.

Reference

sulu/sulu#3198

Expected Behavior

List in tab 'All' should display column with article type, which is only displayed in this tab.

Actual Behavior

At the moment we just have two filter options:

• All
• Filter by logged in user

Expected Behavior

Add a third option 'Filter by...' which opens a overlay where the user can select a contact id.

Actual Behavior

In the getSearchResult function the search automatically gets sorted on title.
Line 230
$search->addSort(new FieldSort('title'));

Expected Behavior

Gives back the standard order from phpcr.

Possible Solutions

Remove this line to give the user the standard sorting

Actual Behavior

At the moment the dropdown is empty.

Expected Behavior

In my opinion it would be nice if we would display a short info/error.

Actual Behavior

The behaviour should be the same as there but should not have any dependencies to 1.5 version of sulu.

Actual Behavior

When adding a property with the content type category_list to an article xml, the rendering in the backend isn't working anymore.

Expected Behavior

The backend article page should load without errors and display the properties instead of a grey area with nothing.

Steps to Reproduce

1. Create an article xml with a category_list in it
2. Create / edit an article with the template and the category_list in it
3. See the error in the devtools:

Uncaught ReferenceError: categoryLocale is not defined
    at eval (eval at _.template (husky.js:13053), <anonymous>:6:9)
    at Object._.template (husky.js:13059)
    at child.renderFormTemplate (main.js?v=develop:187)
    at child.<anonymous> (main.js?v=develop:158)
    at Object.execCb (husky.js:1636)
    at Module.check (husky.js:870)
    at Module.<anonymous> (husky.js:1111)
    at husky.js:129
    at husky.js:1154
    at each (husky.js:57)
    at Module.emit (husky.js:1153)

Actual Behavior

At the moment the article can only be saved in one language.

Expected Behavior

It should be possible to create language in all locales which are provided by Sulu.

Todo

• Elastic search: Save one entry per language (id: uuid + locale)
• Frontend: Implement language switcher
• Type: Can't change between languages

Actual Behavior

Translation for the key sulu_article.list.author is missing when viewing the articles as list.

Expected Behavior

The key should be translated.

Steps to Reproduce

Develop version of ArticleBundle, create article, head back to the overview and check the field descriptor titles.

Possible Solutions

Add translation key to the backend.??.xlf files.

Actual Behavior

ArticleController doesn't check the security permissions.

Actual Behavior

When deletion takes some times when you remove multiple articles the loading status is missing.

Expected Behavior

It should also show the loading bubble when delete items.

Steps to Reproduce

Delete many articles no loading is shown.

Possible Solutions

Show loading bubble.

Actual Behavior

Currently the complete teaser-selection/list@sulucontent was copied to this bundle to add a locale parameter.

Expected Behavior

This file should not be copied to the bundle it should be handled correctly in sulu.

Actual Behavior

The types wont be translated.

Actual Behavior

the code in https://github.com/wachterjohannes/SuluArticleBundle/blob/04908a8d58df8ba8666321212252306a6108a9c8/Resources/public/js/services/property-configuration.js was copied from https://github.com/sulu/sulu/blob/develop/src/Sulu/Bundle/ContentBundle/Resources/public/js/components/content/form/main.js#L255.

Possible Solutions

When updating the dependency for sulu/sulu we could backport this service to content-bundle and use the same in content-bundle and article-bundle.

IMPORTANT

If the update to 1.6-dev will never be done this issue can be closed without any changes.

Actual Behavior

Sulu shows 10 elements selected though it should return XX elements selected unless the max limit parameter is set to a specific value. The website returns all of the elements and is not limited to 10 (right behavior).

Expected Behavior

That the sulu backend shows the right value for "elements selected".

Steps to Reproduce

SmartContent with <param name="provider" value="articles"/>. Add more than 10 articles - it will always show 10 elements selected.
In this case we used additionally a filter for categories and tags - SmartContent should have returned 30 elements selected.

Expected Behavior

Versioning should behave like sulu pages. For this we have to drop support for sulu 1.4.

Actual Behavior

Currently only ElasticSearch 2.* is supported

Expected Behavior

Also ElasticSearch 5.* support available

Actual Behavior

It is not possible to unpublish articles.

Expected Behavior

It should be a dropdown "Edit" with "Delete" and "Unpublish" and a button which indicates the "State" in the toolbar of the form. (see content-form)

Actual Behavior

When ElasticSearch is down, the Articles screen in the adminUI dies with a perpetual loader displayed. It doesn't read the 500 error message provided by the app.

Expected Behavior

There should be a flashing error message saying something like "No ES nodes available on the server".

Steps to Reproduce

Install Sulu and ArticleBundle. Kill ES. Open Articles UI in Admin UI.

Possible Solutions

Read the error message (it's very well structured) and produce a simple warning div with its main message flashed. Image below.

Actual Behavior

False webspacekey in structure

Expected Behavior

Structure should return the current and not articles as webspacekey.

Steps to Reproduce

Content Type with following code:

$webspaceKey = $property->getStructure()->getWebspaceKey();

Possible Solutions

Should get the webspaceKey from the requestAnalyzer.

Actual Behavior

the hasNextPage property is always false

Expected Behavior

to get the right value for hasNextPage from the smartcontent contenttype

During installation, it's clearly stated that guzzle/guzzle is abandoned. Why does this bundle still use it instead of something like httplug for abstraction?

Expected Behavior

The ArticleDataProvidershould provide a data-source with a selection of the type.

Actual Behavior

The function getSearchResult is private so there isn't a way to extend the sort when you extend from this class.

Expected Behavior & Possible Solutions

Some public function where you can add sort options to the search.

Actual Behavior

Multisite is enabled per default for all articles.

Expected Behavior

The developer can configure for which types multisites are enabled.

Actual Behavior

The SuluArticleBundle has no frontend tests.

Expected Behavior

It would be nice if we would implement frontend tests.

Actual Behavior

Currently the article-selection produces an error because of missing locale parameter in selection.

Actual Behavior

The article that is copied from an existing locale is both in draft mode and marked as published.

Expected Behavior

It should be only one of those things, preferably draft.

Steps to Reproduce

Write article in locale1. Switch to locale2 and pick to copy content from existing locale.

Actual Behavior

I have multiple languages and an ArticleIndexListener that adds some properties to the custom ArticleViewDocument. The articles only exist in de!

When using the reindex command like this:

app/webconsole sulu:article:index-rebuild en --live -e prod
app/webconsole sulu:article:index-rebuild de --live -e prod

Everything works fine. When the order of the commands is switched (first de, then en), it overwrites the de values with the en values.

Expected Behavior

As the uuid consists of the page uuid and the locale, I expect to receive the correct view document in my listener.

Steps to Reproduce

1. Install bundle with a version of 0.3.*
2. Crate article in de but not in en
3. Create custom view document with a new property
4. Create an index listener and set the new property
5. Execute the reindex command first with de then en and check the index

Actual Behavior

Currently a snippet content type with default true will throw an error.

Expected Behavior

It should use the current webspace to load the default snippet.

Steps to Reproduce

    <property name="sidebars" type="snippet">
        <meta>
            <title lang="de">Sidebar</title>
            <title lang="en">Sidebar</title>
        </meta>

        <params>
            <param name="default" value="true"/> <!-- the fallback dont work in articles -->
            <param name="snippetType" value="sidebar" />
        </params>
    </property>

Possible Solutions

Use the request analyzer in the snippet (sulu/sulu) or set the webspace key in the ArticleBridge.

Actual Behavior

Additional properties added to ArticleViewDocument for elastic search indexing are not returned in page document.

Expected Behavior

return of properties in page document

Steps to Reproduce

What are the steps to reproduce this bug? Please add code examples,
screenshots or links to GitHub repositories that reproduce the problem.

Possible Solutions

add getContent and getRoutePath to ArticleResourceItem

Actual Behavior

CSV Export is currently not available

Expected Behavior

Export should be added to articles.

Steps to Reproduce

The list view should have a export function.

Possible Solutions

Add basic sulu csv export function.

Actual Behavior

Currently the Typ translation is the same as the tab translation.

Expected Behavior

There should be 2 Translations for typ used in the list and typ used in the Tabnavigation e.g. the Type is Magazine and the Tab are Magazines

Possible Solutions

Add translation_key_tab or something to the configuration.

Actual Behavior

Smartcontent with <param name="provider" value="articles"/> doesn't load categories button for filtering.

Error message in console:

Webspace "" has no defined locale

Cannot convert undefined or null to object

Error loading component: smart-content/categories@sulucontent TypeError: Cannot convert undefined or null to object
>> Object.getContentLocale (user-settings-manager.js?v=develop:41)

Expected Behavior

Smartcontent categories button does load and categories are selectable.

Steps to Reproduce

1. Add an article template with a smartcontent which has <param name="provider" value="articles"/>
2. click on the smartcontent filter button.
3. see a loader where the button for categories should be placed.

Possible Solutions

Add default webspace key for articles.