Monorepo for SUI (Simple User Interface) packages.
SUI Components is an Open-Source, high quality library of React components that empowers teams to craft any product with ease.
![dependabot[bot] avatar](https://avatars.githubusercontent.com/in/29110?v=4 "dependabot[bot]")
We should let developers to pass also a config that's being mutated, for that, we're still offering use a config passed to the factory, or pass a new config in the constructor, so the config is instantiable and could be mutated, so the config is not shared among instances of the domain.
class Father {
constructor (params) {
this._params = params
Object.keys(params).forEach(key => (this[`_${key}`] = params[key]))
console.log('constructor', params)
}
toJSON() {
console.log('toJSON', this._params, Object.keys(this))
return Object.keys(this).reduce((json, privateKey) => {
const key = privateKey.replace('_', '')
if (!this._params[key]) { return json }
if (typeof this._params[key] === 'ValueObject') {
return {...json, ...this._params[key].toJSON()}
}
json[key] = this._params[key]
return json
}, {})
}
}
class Child extends Father {
red = 1
blue () {}
}
console.log(
new Child({a:1, b:2}).toJSON()
)
sui-mono
mono-package repos use to tag in git each release, sui-mono is not doing this since sui-studio never tagged component releases
We want to make sui-mono tag each release
Mono packages should be tagged as it's the current standard.
For multi packages if we tag it should contain the component context and name (card/basic-version or card-basic-version)
It keeps on reinstalling the dependencies over and over again
npm run phoenixExpected behavior: It should install all dependencies and finish its execution.
Actual behavior: It installs the dependencies over and over again.
Reproduces how often: Only if an empty folder is in the sui-studio components folder
Temporary fix You can avoid this issue by removing all empty folders in the repo, to find them run find . -type d -empty
We want to be able to release a single package when running sui-momo release in order to avoid releasing packages from others
sui-mono@latest
Create new command that links packages between each other.
Use this code as inspiration: https://github.com/cyclejs/cyclejs/blob/master/.scripts/symlink-to-each-other.sh
[sui-domain-connector]
Migrate the package https://github.com/SUI-Components/ddd-react to the sui monorepo
ssr
Add a way to define in the config a pattern that will force to go to the proxy, even without the need to check the match of the routes.
"proxy": {
"host": "coches.net",
"port": 80,
"protocol": "http",
"force": "/^((.*\.)*)(dev|pre2?|integra|www)\.coches\.net(.*)$/"
},
[sui-bundler]
Change the preload scripts for prefetch for now.
Expected behavior: Don't block load of assets.
Actual behavior: Blocking assets because preload has high priority and defer lower.
This is temporary until we find another solution in order to get in SSR a reliable way to prefetch needed assets for each route.
[sui-mono]@[1.18]
Bug: sui-mono check does not detect releases
Expected behavior:
Release is detected
Actual behavior:
No release is detected
Reproduces how often: always
Here
the release is not detected for search/filters
sui-studio
API Tab not working for some components
Expected behavior:
It should render all props
Actual behavior:
Looks like it happens for every component that uses withLocalService from @schibstedspain/ddd-react-redux
[sui-studio]@4
Update babel-standalone to version 7
Use preset env
Expected behavior: Being able to use in playground object spread and modern features
Actual behavior: Can't be done
[sui-bundler]
When you import a component, first look fo a es6 folder to import the es6 version of the component or import the es5 version in other cases.
[sui-studio]
Instead generating packages with babel and sass scripts, create the package.json with a build:js and build:styles.
We would like to add prettier to our sui-lint in order to format our code automatically based on our linter config rules, so all developers improve development time.
The implementation should be totally transparent for the user so he shouldn't notice any change but the advantatge of gettign automatically the code formatted before passing the linter, so it gets fixed before even he notice it.
Some dependency used is not being installed in the package.json.
Issue from previous repo
https://github.com/SUI-Components/SUIStudio/issues/19
[babel-preset-sui]
Use a env variable to use or not ES6 modules
We would like to do a npm install after creating a studio in order to be ready to start hacking after creating it.
Load sui-polyfills to make the studio and all the components compatible with all the browsers we expect to support.
[sui-studio]
To improve the DX we must recover the HMR, to do that we have migrate react router from v2 to v4
Issue from previous repo: https://github.com/SUI-Components/SUIStudio/issues/9
Multipackage repo detected as monopackage.
Expected behavior:
Detect release as multipackage repo
Actual behavior:
Detects release as monopackage repo
Reproduces how often: always
The problem is located here:
https://github.com/SUI-Components/sui/blob/master/packages/sui-mono/src/config.js#L43
We should check that there is on subfolder with package.json and that's it.
Issue from previous repository:
https://github.com/SUI-Components/SUIStudio/issues/56
Prepare deployments for now.sh instead of surge
Issue from previous repo
https://github.com/SUI-Components/SUIStudio/issues/51
babel-preset-sui
Add support to preact and flow by installed needed presets if those dependencies are installed.
[sui-decorators]
Instead of having a big md5.js file (2.5KB gziped) for hashing our params we could consider another more cheap hashing algorithm in terms of performance and size of the bundle.
A simple alternative could be using the Java hash algorithm, that's small (less than 100 bytes gzipped) and it has good performance.
function javaHash (str) {
var hash = 0;
if (str.length == 0) return hash;
for (i = 0; i < str.length; i++) {
char = str.charCodeAt(i);
hash = ((hash<<5)-hash)+char;
hash = hash & hash; // Convert to 32bit integer
}
return hash;
}
javaHash('{ params: "hola" }') -> 1329245074
md5() -> 897245d00d4ac9b18989deb9b56c5e50
[babel-preset-sui]@latest
Use env preset instead of plugins
Modifie browsers config according to SUI requirements
TODO: Add a description.
[META]
In order to sui-mono detect this repo like a monorepo - multipackage, each folder inside packages must have a package.json
Packages with no build command cannot be committed
Expected behavior: package is published
Actual behavior: package is not published and an error is thrown of missing "npm run build" command
Reproduces how often: always
Executing build makes no sense. Developer should simply add a "prepublish" command that would be automatically executed by npm client.
Nevertheless, to be retrocompatible, we'll make npm run build to be executed only if it exits
To be able instanciate the domain outside of the domain package, we must change that:
export default class EntryPoint {}
for
export default ({useCases, config}) => class EntryPoint {}
sui-studio
This task depends on #9
import {config, logger, performance} from '@s-ui/domain'
@logger
@config
@performance
export default class HTTPUserRepository {
current () {
this._log('start request')
this._config().get()
}
}
sui-cz
Currently, sui-cz if taking packagesFolder from sui-mono config (here)
To make sui-cz resuable in non sui-mono projects, it makes sense to apply the following behavior
When ["config"]["sui-cz"] node exists in packages.json
Then get packagesFolder from there
Otherwise maintain current behavior
Update docs to mention ["config"]["sui-cz"] and how sui-cs integrates with sui-mono taking ["config"]["sui-mono"] otherwise
[sui-ssr]
Add a way to add redirections and rewrites to the package.json to be handled by ssr.
"rewrites": {
"https": true,
"forceSlash": true,
"rules": {
"coches.net": {"target": "www.coches.net", "code": 302},
"m.coches.net": "www.coches.net"
}
}
}
sui-mono@latest
Add a new command to link all package one between others.
More info https://github.com/cyclejs/cyclejs/blob/master/.scripts/symlink-to-each-other.sh
Issue from previous repo:
https://github.com/SUI-Components/SUIStudio/issues/50
Create a package to be executed globally, that does current behavior of suistudio init <project_name>
[sui-hoc]
Create an package with all HoC that we use in our projects
The help command does not work as expected
> sui-studio help check-release
Expected behavior: Information about sui-studio check-release
Actual behavior: It executes sui-studio check-release
Reproduces how often: (only for bugs) 100%
I'm not man enough to execute sui-studio help release
sui-perf
Right now sui-perf provides an integration to get superagent requests timings.
We want to add support for Axios
Expected behavior: Get time marks on axios requests
Actual behavior:
I've made a very quick'n dirt implementation but I've noticed that since they are promises and two promises can be spawned at the same time but resolved in any order, this libs groups them as one call as child of the other one (like with react components)
Example:
/example1 request is performed (perf.mark(/example1)
/example2 request is performed (perf.mark(/example2))
/example2 request done (perf.stop(/example2)
/example1 request done (perf.stop(/example1)
This will be reported as example2 being a child of example1 when the requests are independent to each other.
In my mind this should also happen to superagent implementation on events, but I didn't test it.
sui-studio@latest
To be able to migrate common deps to sui-studio, we need to make it work locally.
When sui-studio is executed
Then it should check is there is a local and/or global instance of it
When there is a local instance of the studio,
Then it should warn the user it's using local version and do it
Otherwise it should throw error and ask user to npm install sui-studio --save-dev
Expected behavior:
There should be no linting errors
Actual behavior:
It shows linting errors
Reproduces how often: (only for bugs) always
The postinstall creates a folder named react with transpiled code which obviously does not pass the linting rules
When generating a new component, the files created by the studio are not indented correctly
Expected behavior: The package.json, src/index.js, src/index.scss, .gitignore, .npmignore files should be indented correctly
Actual behavior: They are not
Reproduces how often: Always
Looks like the template used to generate those files is generated by the `` string interpolation operator adds the spaces used as indentation for the own generator file itself. https://github.com/SUI-Components/sui/blob/master/packages/sui-studio/bin/sui-studio-generate.js#L83
[sui-mono]
Avoid release packages privates. If the package has the key private: true in the package.json we must not try to publish the package.
[sui-mono]@[version-of-the-package]
We're using private when it should be restricted. We might need a way to avoid users to put a non-controlled access type on the package.json. Maybe avoiding the publishing with a wrong value.
Expected behavior: Publish as restricted.
sui-precommit@latest
We need a new task in sui-precommit wich follows the follow
Given that I'm in a mono-repo
And I'm committing in the scope of a package
And package.json has been changed
Then it should check that none dependency is duplicated in 2 or more packages of the monorepo
And it should check that none dependency is duplicated with sui-common-dependecies
Expected behavior:
If the version is the same in all places, we throw a warning to inform user with message
[package-name] is used in other packages of this mono-repo. We recommend to have a single source of truth for each dependency
If the version is NOT the same in all places, we throw an error to avoid commit with folowwinf message:
[package-name] is used in other packages in different version. This might increase bundle size duplicating this dependency in the bundle.
[babel-preset-sui]@1
It's missing legacy decorators thus some packages are not working as expected.
Expected behavior: Compiles! :)
Actual behavior: It's not compiling! It throws an error! :(
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
Django
The Web framework for perfectionists with deadlines.
Laravel
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft
Open source projects and samples from Microsoft.
Google
Google ❤️ Open Source for everyone.
Alibaba
Alibaba Open Source for everyone
D3
Data-Driven Documents codes.
Tencent
China tencent open source team.