just changes are not stored yet. please have a look if satisfied for a first version daniel.

will need a bit of tweaking and styling. but now this renders fast without the delays and we can connect the thing to undo/redo functionality of the composer.

• make a selection (PropertySelection)
• toggle on subject reference
• select a subject

=> dialog closes

Possible because of implicit state switch (caused by selection change). See #20

Steps to reproduce:

• go to http://localhost:4001/
• navigate to last para
• hit enter

it will return error, and after this you will not able to hit enter anywhere, it'll always return error

Hey @oliver----!

Could you please add line breaks to this composer version? For shift+enter keys for example.

Thanks.

Currently the entry is still there and also the anchors appear in the markup. The fragments are gone though.

That way we can have a responsive user interface (e.g. when switching between entities and subjects panel). We will poll for updates from time to time and if subjectsDBVersion changes we fetch new values.

Reproduce:

• In test article break entity reference (entity_reference_1)
• Undo that change and watch console

What happens:

• the undo reconstructs the previous state of the doc but somehow the writer-state points to the auto-created entityReferenceId that was valid before the undo.

Maybe bring back status bar for an error message display... but also thought that displaying a red save icon and some text message near this place would be good.

Steps to reproduce:

• make any selection bold or italic
• set cursor inside fragment
• hit any key

you'll lose whole fragment

Maybe treat headings as paragraphs in the archivist case

Use the one from http://lens.elifesciences.org.

Hey @michael, @oliver---- !
Old urgent bug still here. When i'm pasting text it removes few spaces in every row.

Steps to reproduce:

• go to http://www.bbc.com/news/world-europe-32399433
• copy text fragment without new lines from article
• paste it

cursor will stay at the position where you paste text

I'm implementing remarks as a containerannotation. Now I want on cursor movement to determine which annotation should be highlighted based on where the cursor is.

So we need something like this:

https://github.com/substance/archivist-composer/blob/master/src/writer_modules/entities/state_handlers.js#L50

Currently I get an error when switching to the metadata panel. Can this be a rule only for fullfledgededitors but not formeditors?

We need some sort of guard to know if we are in an in-between container state.

Reproduce:

• make selection within one paragraph (not collapsed)
• hit enter.

After toggling an annotation on or off, the selection should be preserved. Currently we loose the cursor and thus also the tool states don't feel accurate.

Try this:

• expand a subject annotation
• hit undo

-> user interface does not update

Maybe we could go the route with a simple node array as a property of the document node instead of the content container node. Maybe then we could specify some function to determine the nodes that should go into into the top level container, and that could be passed somehow to the ContainerComponent. I understand that the title property differs from a text node and there's a different handling of expansion needed.

var myCustomContainerNodes = [
   "document.title", // since we know this is a string property we can expand it to the ["document", "title"] component
   "text_1",
   "text_2
];

Not good from a naming perspective since we mix nodes and properties. Maybe we need to call this a special concept.. like ContainerSeed that takes a list of paths in the doc and only expands nodes but not properties?

However, I guess it's not nice that now we have all info now in the model except for stuff like this. For the archivist maybe we should rather have a form editor for the title. Only thing we loose is moving the cursor with the keyboard.

Hey!

When you're pasting something it'll copy styles and will not save pasted data.
See:

but not when doc updates.. e.g. when you split or join an entity reference.. it doesn't get reflected at scrollbar.

is it legitimate to bind to document:changed events in content_panel?

E.g. when you want to assign another entity with a reference. Currently you need to delete it and create a new reference.

How can we prevent from having unassigned references? We currently have that case with subject references. We create them immediately and show an edit dialog. So the target property is empty at the beginning. It would be good ensure data consistency and have no instances of unassigned references at any time.

I just did a very basic implementation. And i don't know how those items should be presented best. Daniel, maybe you make an iteration here.

The relevant files are here:

https://github.com/substance/archivist-composer/tree/react/src/writer_modules/entities/entity_types

Also you probably want to adjust the styles:

https://github.com/substance/archivist-composer/blob/react/styles/composer.css#L530

For subject references we use an array for the target property of a reference/annotation.

    "subject_reference_1": {
      "id": "subject_reference_1",
      "type": "subject_reference",
      "path": [
        "text_54",
        "content"
      ],
      "target": ["54bae4cda868bc6fab4bcd0e", "54bae99ca868bc3ec7fb5ad8"], // these are external objects
      "range": [
        85,
        95
      ]
    },

I also created an index to look up subject references by target.

  // Index subject references (multi-annotations)
  this.subjectReferencesIndex = this.addIndex('subjectReferencesIndex', {
    types: ["subject_reference"],
    property: "target"
  });

Now when i employ this index, i only get results for the first entry of the array.

doc.subjectReferencesIndex.get("54bae4cda868bc6fab4bcd0e")); // => ["subject_reference_1"]

doc.subjectReferencesIndex.get("54bae99ca868bc3ec7fb5ad8")); // => []

currently it is before.

Following situation:

• select some text inside of a paragraph (PropertySelection)
• click subject reference bracket to highlight that subject reference
• now click again on reference bracket

Expected: should be disabled now
Actual: it stays open

What happened?

• selection change event gets fired right before second toggle (core extension switches state to default state)
• toggle reference code than does the check if contextId = editSubjectReference and finds it's not so it activates it again.

Possible problem:

• property selection somehow does not get cleared after first click
• second toggle click leads to a blur finally and triggers the unwanted state change..

not sure how we should deal with that kind of problems... Oliver?

Also make sure they use mousedown for toggling instead of click. That way we prevent a blur to happen on the surface.

while __v property gets incremented in database, the change doesn't get reflected in the doc that findByIdAndUpdate returns.

https://github.com/substance/archivist/blob/next/models/document.js#L192

For example when you save a doc with version 12, documentVersion: document.__v will evaluate to 12 after the update instead of 13. This leads to errors of subsequent saves.

I suspect something has changed in mongoose.. so results of findByIdAndUpdate don't have the latest updates.

@Integral can you check that?

It's needed so i can successfully complete and test autosave.

Works like this?

One file per component or extension? Let the user decide.

there were some problems with it in combination (probably related to our CJSServer implementation). I include React currently via script tag and assume window.React is defined.

on initial loadpage

disappearing after any operation

steps to reproduce:

• come and see in Daniel's laptop

Steps to reproduce:

• select text from end of any para, next para and begin of another para
• hit enter or backspace

it will return Uncaught TypeError: Cannot read property 'type' of undefined

E.g. when you click on an entity reference, or navigate using arrow keys the cursor doesn't stay there.

If you pasting one para it usually blocks the content which is now very good (maybe we could define default behaviour like clean all html?)

But when you copy few paras and pasting them, it'll return TypeError: Cannot read property 'getComponents' of undefined {stack: (...), message: "Cannot read property 'getComponents' of undefined"}

Steps to reproduce:

• go to http://substance.io/about/
• navigate to Oliver Buchtala's section and copy few paras like bio and "Find him on Github"
• paste it to composer

@oliver---- , backspace for everything more than one paragraph isn't working.

Button should be disabled.

Here's one case with remarks where multiple targets are touched.

is there a special treatment for the "{" character..?

Now selections are preserved after toggling / untoggling an annotation (e.g. bold). However the tool only listens to selection changes to verify it's active state.

When reapplying of the prev. selection after transaction save, no selection:changed event get fired.

tx.save({ selection: Selection.create(path, range[0], range[1]) });

Maybe it should fire? Or we need another way of triggering the tools update.

In the previous version we were pulling in the entire subjectsDB whenever it's version number changes.