Code Monkey home page Code Monkey logo

jamming's People

Watchers

 avatar  avatar

jamming's Issues

Login Feature

Adding the feature to process the accessToken before running the app is an intuitive approach. The logic for this was fine.

PLayListName onMouseLeave

The onMouse effects for playlistName is very clever. However, it still can be tightened up. Because after onMouseLeave you can still add text to 'New Playlist'. I do not think that is what you wanted. Instead of onMouseLeave you could try onBlur. Here are some other events you should look into;

https://www.w3schools.com/jsref/dom_obj_event.asp

Summary

The app ran very well. Great attention to detail. No major errors were detected. The app may not be utilizing some of reacts features such as state and setState. An example is when you set the value of a DOM element directly like;
playListInput.value = '';
It would be a better practice store that value as a state and make changes to it using setState. More information about states can be found here;
https://facebook.github.io/react-vr/docs/components-props-and-state.html

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.