Code Monkey home page Code Monkey logo

extras's Introduction

extras's People

Contributors

jxnblk avatar kevinsuttle avatar zephraph avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

extras's Issues

css() isn't picking up pseudo-selector styles defined in emotion css prop

Is there something I'm missing?

css={css({':focus': {borderColor: 'blue20'}}

Image 2019-05-03 at 11 25 45 AM

This is being used on a <Flexbox /> component built in @emotion/styled + styled-system.

// @flow

import styled from '@emotion/styled';

import {
  alignItems,
  alignContent,
  justifyContent,
  justifyItems,
  flexWrap,
  flexBasis,
  flexDirection,
  flex,
  justifySelf,
  alignSelf,
  order,
} from 'styled-system';
import shouldForwardProp from '@styled-system/should-forward-prop';

import {Box} from './Box';

export const Flexbox = styled(Box, {
  shouldForwardProp,
})(
  {
    boxSizing: 'border-box',
    display: 'flex',
    label: 'flexbox-primitive',
  },
  alignItems,
  alignContent,
  justifyContent,
  justifyItems,
  flexWrap,
  flexBasis,
  flexDirection,
  flex,
  justifySelf,
  alignSelf,
  order
);

What's odd is that I can get it to work here: https://stackblitz.com/edit/react-zzznyy

Key is being appended to the selector causing responsive arrays to fail

Hey,
I'm really enjoying this new CSS prop! Thanks for your work. I'm seeing a failure on some responsive arrays where a number is being appended. For example:

<style data-emotion="css">.css-wnbiem-NavLink-StyledSubNavLink 0{padding:4px;}</style>
<style data-emotion="css">@media screen and (min-width:480px){.css-wnbiem-NavLink-StyledSubNavLink 1{padding:4px;}}</style>
<style data-emotion="css">@media screen and (min-width:750px){.css-wnbiem-NavLink-StyledSubNavLink 2{padding:16px;}}</style>

If I can find some time, I'll will try to put together a minimal example with demonstrates this.

Add omitAdditionalProps to clean-tag

We've got a lot of cases where props are ending up in the dom. We're trying to go through and clean those up, but adding things to omitProps means it doesn't get all the defaults. I'd like to be able to add props to omit in addition to the defaults.

I'll have a PR shortly.

css package: sizes key?

I'm seeing a delta between the css package doc
Image 2019-05-16 at 12 47 53 PM

And the reference table in Style System's docs.
Screen Shot 2019-05-16 at 12 53 02 PM

Screen Shot 2019-05-16 at 12 56 55 PM

I tried using sizes in styled-system, but found it didn't work yet. Are there plans to unify this?

@styled-system/css inside MDX

Hello again,

Should the css prop work inside of MDX?

I have attempted to use it in both a normal MDX file and one that I was using MDX-blocks with.

Thanks.

add `outline` support

Yo,

How do you feel about adding outline properties?

They could map to the same theme objects as border.

I use outline often when I don't the border to impact the computed height/width of my elements.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.