strzibny / invoice_printer Goto Github PK

When notes are more than 1 line the pdf print is not shown correctly.
I have Write a test to demostrate the problem:

  # test/note_test.rb
  def test_setting_a_note_with_multiple_lines

    note = "Lorem Ipsum is simply dummy text of the printing and typesetting industry.\nLorem Ipsum has been the industry's standard dummy text ever since the\n    1500s, when an unknown printer took a galley of type and scrambled it to\n    make a type specimen book. It has survived not only five centuries, but also\n    the leap into electronic typesetting, remaining essentially unchanged."

    params = default_document_params.merge(
      note: note
    )
    invoice = InvoicePrinter::Document.new(**params)
    rendered_pdf = InvoicePrinter.render(document: invoice)
    pdf_analysis = PDF::Inspector::Text.analyze(rendered_pdf)

    assert_equal true, pdf_analysis.strings.include?(note)
  end

output:

$ rake test                                                                
/home/cristiano/.rvm/rubies/ruby-3.0.0/bin/ruby -w -I"lib:test" /home/cristiano/.rvm/rubies/ruby-3.0.0/lib/ruby/gems/3.0.0/gems/rake-13.0.3/lib/rake/rake_test_loader.rb "test/api_test.rb" "test/background_test.rb" "test/cli_test.rb" "test/dates_box_test.rb" "test/examples_test.rb" "test/inputs_test.rb" "test/invoice_printer_test.rb" "test/items_table_test.rb" "test/labels_test.rb" "test/notes_test.rb" "test/page_numbers_test.rb" "test/payment_box_test.rb" 
/home/cristiano/code/invoice_printer/test/payment_box_test.rb:56: warning: method redefined; discarding old test_setting_bank_account_number_and_iban
/home/cristiano/code/invoice_printer/test/payment_box_test.rb:38: warning: previous definition of test_setting_bank_account_number_and_iban was here
Run options: --seed 43778

# Running:

...............................F.....

Finished in 21.031516s, 1.7593 runs/s, 4.6121 assertions/s.

  1) Failure:
NotesTest#test_setting_a_note_with_multiple_lines [/home/cristiano/code/invoice_printer/test/notes_test.rb:28]:
Expected: true
  Actual: false

37 runs, 97 assertions, 1 failures, 0 errors, 0 skips
rake aborted!
Command failed with status (1): [ruby -w -I"lib:test" /home/cristiano/.rvm/rubies/ruby-3.0.0/lib/ruby/gems/3.0.0/gems/rake-13.0.3/lib/rake/rake_test_loader.rb "test/api_test.rb" "test/background_test.rb" "test/cli_test.rb" "test/dates_box_test.rb" "test/examples_test.rb" "test/inputs_test.rb" "test/invoice_printer_test.rb" "test/items_table_test.rb" "test/labels_test.rb" "test/notes_test.rb" "test/page_numbers_test.rb" "test/payment_box_test.rb" ]

Tasks: TOP => test
(See full trace by running task with --trace)

Is it possible to add a Date field to the "item" so that each item can have a date associated with it?
I am trying to use it for a consulting type invoice, and date of service is critical for the invoice.

I want to apply different styles so that each invoice can have a different makeover. Is it possible out of the box?

Add a parameter --document_path or detect it automatically if a document or file is passed, and load the document from a JSON file.

The logo's current position is bottom-left and is kind of counter-intuitive in my opinion.

Would it be helpful to implement a feature that lets the user decide where to place certain components(like logo) on the invoice, change background opacity, etc?

• Each item row should have a tax field
• There should be a tax info associated with the total amount
  • subtotal / taxable / tax rate / tax due / total due

Hi,

I've checked out different command line tools to generate pdf invoices from the command line and yours looks most promising for me :) But (there's always a "but") would it be possible to add

• an introductory sentence to the table of items and
• a suitable place for a QR code?

Introductory sentence

I mean something along the lines of We invoice you for... or In accordance with the Contract No 2021/56844 we are sending you... A similar section is called "Additional information" in the example below:

QR code

This would really be a great addition, it's becoming more and more popular and my clients would certainly appreciate not having to copy the data from the invoice by hand. I don't mean writing extra code to generate such an image (I use qrencode for that), just a suitable place for a QR code image.

Thanks for your great work!

The instance variables that describe the provider and purchaser are identical, providing a lot of repetition in the attr_reader calls, and the initialize method. It should be possible to create a class that describes both of these items, and store them as @Provider and @purchaser within the Document class. This would certainly clean up the code, as well as make it easier for users to call Document.new. If you agree that this is useful, I would like to work on it myself.

I have a question that I haven't found answered in the readme. How can I handle the following localization issues with invoice_printer:

• A4 vs. US letter
• placement of recipient and seller address (i.e. for envelopes with window)
• formatting of date value
• formatting of money values - if there is any...? (the example code is a bit inconsistent, sometimes it includes $ sign, sometimes not)

Thanks, Oliver

Every item in the table should be able to specify a breakdown with a simple free-form item.breakdown field.

Example:

Delivery gift busket
- Including extra roses: $40
- Including extra pralines: $15

Coming from #25 we should be able to support some variety for buyer and seller boxes:

One other comment/suggestion I would have is to simplify/unify the content
of the Buyer and Seller boxes.  I find my use case putting different data
in the fields than you intended.  One contributing factor is that different
locales use different ways of representing addresses.  Also (as in my case)
I am just using email addresses for purchaser, so your fields dont fit my
use case.
Instead of calling the fields "street/city/postcode/etc."  just call them
line1, line2, line3, etc, and let the user put whatever data they want.  No
real need to format this data.

IMO serve functionality does not belong to this gem itself. It would be awesome to extract it into invoice_printer_server so that puma and roda dependencies will be moved away as well. :D

We are getting the following warning:

/home/strzibny/.gem/ruby/2.7.0/gems/invoice_printer_server-2.0.0/bin/invoice_printer_server:65: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

It appears the template only leaves room for one line of notes. If you write too much, it will word wrap, but the additional lines of words won't appear on the page. If you use explicit new lines in the note section than those lines won't appear either.

Let's add native support for a QR code image.

The only way I've found options for the json document is one CLI input example, but it's not clear whether those are all the options, whether they are extensible, etc.

Am I missing some documentation or should I just read the code?

Title says it all.

Also, I didn't look at the code but what does the PDF look like if you have 200 items?

With the change to the new totals table, the total value will be printed in bold if possible. We now need a way to provide custom fonts for both Regular and Bold versions.

generally with praw the pdf start with

respond_to do |format|
    format.html
     format.pdf do
        pdf = InvoicePdf.new
       send_data.to_s pdf.render, filename: "invoice_#{@invoice.id}.pdf", type: 'application/pdf'
     end
  end

and on pdf

include ActionView::Helpers::NumberHelper

class InvoicePdf < Prawn::Document

  def initialize(boutique, invoice, order, buyer, product)
    super({:page_size => 'A4'})
 
    @invoice = invoice
    @order = order

    @product = product
    text "FATURA ##{@invoice.id}"
    move_down 10
    body
  end

but with invoice_printer did not start. thanks

Documents should be able to include a printable comment at the end.

This is related to removal of old depracated fields.

Hi,

is it possible to cut a new version of this gem to be current with what is committed to the master branch of this repository? I am unable to pull in my Gemfile directly from GitHub.

Thanks!

• remove deprecated fields
• remove warning
• edit and regenerate promo.rb example
• update simple_invoice.rb example
• update benchmarks/render.yml

I have shared tax and bank info separately with my clients and would rather not repeat it in every emailed invoice. However, if I don't put a bank account number, the invoice says "Payment in cash", but I would rather specify "By bank deposit" or nothing at all.

Let's switch the alignment of labels to the left and values to the right, and remove the table container (and not so much working width calculations)

This is something that nobody probably hits in the wild, but it would be good to take care of it.

E.g. Due date should be made optional.