Comments (12)
I have the exact same problem. I have also configured Strider and the Github plugin with these 4 environment variables, but get "Project not found" when trying to connect to Github (/auth/github).
I'm using Strider 1.6.0 and have the latest version of the github plugin according to the admin page.
from strider-github.
You say "when I try to connect to github" --> What's the URL that gives you the "Project not found" message?
from strider-github.
It's http://strider/auth/github (if http://strider is the SERVER_NAME, where I access strider).
from strider-github.
In my case it is just the https version of the above.
-- edit --
To be clear it is: https://EC2_SERVER_NAME/auth/github
from strider-github.
If I go to http://strider/auth/github/callback
, I get to authenticate on Github and everything works fine. So I can actually connect to Github now, but still, the url one should go to in order to connect to Github should be /auth/github
, not /auth/github/callback
(which is only the callback called after the authentication on Github).
from strider-github.
The /auth/github
is coming from https://github.com/Strider-CD/strider-github/blob/master/package.json#L29
I'm having that same issue. If I go to /auth/github/callback
and proceed with it, I get the following stack trace:
TypeError: Cannot read property '0' of undefined
at makeAccount (/home/nepoxx/strider/node_modules/strider-github/lib/webapp.js:167:28)
at Strategy.validateAuth [as _verify] (/home/nepoxx/strider/node_modules/strider-github/lib/webapp.js:152:26)
at /home/nepoxx/strider/node_modules/strider-github/node_modules/passport-github/node_modules/passport-oauth2/lib/strategy.js:188:22
at /home/nepoxx/strider/node_modules/strider-github/node_modules/passport-github/lib/strategy.js:109:5
at passBackControl (/home/nepoxx/strider/node_modules/strider-github/node_modules/passport-github/node_modules/passport-oauth2/node_modules/oauth/lib/oauth2.js:126:9)
at IncomingMessage.<anonymous> (/home/nepoxx/strider/node_modules/strider-github/node_modules/passport-github/node_modules/passport-oauth2/node_modules/oauth/lib/oauth2.js:143:7)
at IncomingMessage.emit (events.js:117:20)
at _stream_readable.js:944:16
at process._tickCallback (node.js:442:13)
from strider-github.
Looks like this might be due to the change to Express 4 that I brought in. Since now the extension-loader might be loading things after certain routes, so the catch-all is being called before the provider routes are configured. @jaredly does that sound right?
from strider-github.
Could anyone seeing this issue try this branch: https://github.com/knownasilya/strider/tree/fix-auth-routes
from strider-github.
@knownasilya yeah that sounds right.
from strider-github.
@Nepoxx The error you're getting is related to this issue: #25
So just add your email address on your Github profile, and it should work.
from strider-github.
@doubliez That was indeed the issue (it's kinda weird that we have to fill out our public e-mail, but that's another discussion.
@knownasilya This being said, your fix works!
from strider-github.
The error you're getting is related to this issue: #25
@Nepoxx @doubliez I just submitted a fix for that.
Will also be merging the changes for the fix for this issue. Although this is a temporary fix, since the routes need to be refactored anyway.. I think 1.6.1 needs to be pushed, what do you guys think?
from strider-github.
Related Issues (20)
- Error creating project (Failed to setup repo: Bad status code: 401) HOT 2
- getting this working with github enterprise HOT 10
- sendJob should return true, because if we reach that point in the code, the job has been successfully created?
- Github auth callback url issue HOT 22
- Please update version on npm to 2.2.0 HOT 5
- Setting up a private project I can access but do not own HOT 3
- Fix tests
- File version mismatch on npm install HOT 1
- Allow specification of APP_ID, SECRET, DOMAIN, ENDPOINT per account HOT 1
- webhooks.js expecting objects to exist that do not HOT 2
- Use SSH authentication instead of HTTPS HOT 3
- Unable to 'run' new projects due to ssh failure (publickey) HOT 10
- Delete branch HOT 12
- Strider fails to install deploy key
- Strider build 'undefined' branch when tag is pushed HOT 4
- Plugin crashes when pull request has merge conflict HOT 2
- Webhook error on release HOT 2
- Git Clone Invalid Syntax HOT 1
- git clone fails HOT 9
- Question: Do you need an email address for Github to work? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from strider-github.