getting this working with github enterprise about strider-github HOT 10 OPEN

from strider-github.

I'm not aware if anyone has ever used Github Enterprise with Strider successfully, if they have, then it looks like a possible API change?

from strider-github.

I saw a couple of commits - 39345dd
and
0abde9a
(however, parts of those commits are now gone from the code - in d404010)

Also saw - http://strider.readthedocs.org/en/latest/intro.html#github-github-enterprise-bitbucket
and, a reference in the code - https://github.com/Strider-CD/strider-github/blob/master/lib/api.js#L406-L409
(However, this code is unlikely to work - since we do not get a uri in the res.request anymore.)

Is it okay to then remove those lines in api.js that are dead - so that someone who will implement github enterprise support will have a clean start?

from strider-github.

Can you add a // TODO: add enterprise support line where you remove those lines? Thanks.

from strider-github.

done!

On Thu, Aug 20, 2015 at 11:35 PM, Ilya Radchenko [email protected]
wrote:

Can you add a // TODO: add enterprise support line where you remove those
lines? Thanks.

—
Reply to this email directly or view it on GitHub
#50 (comment)
.

from strider-github.

With some local modifications, I've gotten strider-github to connect to our enterprise github server. I'm working on making more appropriate modifications right now, and should have a pull request up in the next few days.

Basically, what needs to be done:

• api.js:423 - here we are assuming that the team id is the /a/b/this. All enterprise api urls start with /api/v3, so all we need to do is add a replace('/api/v3/', '') to 421.
• webapp.js - the appConfig object needs to use the environment variable overrides, if defined
• all situations where github.com is used need to be made dynamic, to either use the environment override or github.com.
• Docs need to be updated with steps on setting up the app, etc.

Anyways, I really like the Strider-CD project so far. It's a huge step up from jenkins, and has a UI that I can actually... use.

P.S.

Have we considered using an external library for the github api interface? There are a few npm packages out there that take care of connecting to the github api with OAuth. Perhaps we could leverage one of these packages instead of having all of the api call code in-house? The package I'm thinking of is octonode, which supports everything that this project needs right now. Just an idea, let me know what you think.

from strider-github.

Glad to have you onboard @apiv! Looking forward to your PRs.

We already have an issue about using a github API module here: #1 but we would still need to keep the gitane module around. If you want to tackle this, go for it. I'll try to help as much as possible.

from strider-github.

Cool, I've made #56 to add enterprise support without the API refactor. I still want to take a shot at refactoring the API to use octonode, I'm just still getting acquainted with passport and the Strider-CD api. I might have some questions along the way, so I'll open a new issue for 'Use octonode' when I get started.

from strider-github.

#56 merged, this issue should be all set to close.

from strider-github.

I'll close this once I release the GE changes.

from strider-github.