Today I noticed that our strider is no longer processing commits from our projects.</p

I also have this kind of issue after a push on github: <div class="snippet-clipboa

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-u

Problems in GitHub communication about strider-github HOT 9 CLOSED

strider-cd commented on May 27, 2024

Problems in GitHub communication

from strider-github.

Comments (9)

laurentj commented on May 27, 2024

I also have this kind of issue after a push on github:

TypeError: Cannot call method 'indexOf' of undefined
    at pushJob (/home/strider/strider/node_modules/strider-github/lib/webhooks.js:126:19)
    at startFromCommit (/home/strider/strider/node_modules/strider-github/lib/webhooks.js:42:16)
    at receiveWebhook (/home/strider/strider/node_modules/strider-github/lib/webhooks.js:222:3)
    at callbacks (/home/strider/strider/node_modules/express/lib/router/index.js:164:37)
    at projectProvider (/home/strider/strider/lib/middleware.js:107:3)
    at callbacks (/home/strider/strider/node_modules/express/lib/router/index.js:164:37)
    at Promise.<anonymous> (/home/strider/strider/lib/middleware.js:201:5)
    at Promise.<anonymous> (/home/strider/strider/node_modules/mongoose/node_modules/mpromise/lib/promise.js:162:8)
    at Promise.EventEmitter.emit (events.js:95:17)
    at Promise.emit (/home/strider/strider/node_modules/mongoose/node_modules/mpromise/lib/promise.js:79:38)

So it is caused by this line:

if (payload.ref.indexOf('refs/heads/') === 0) {
    branchname = payload.ref.substring('refs/heads/'.length)
    ref = {
      branch: branchname,
      id: payload.after
    }
  } else {

although, in the payload in the request, I have the ref property

  "ref": "refs/heads/jelix-1.6.x",

from strider-github.

oliversalzburg commented on May 27, 2024

@laurentj That was fixed by #16 Unless I'm mistaken :)

from strider-github.

laurentj commented on May 27, 2024

@oliversalzburg yes, you're right. I didn't saw the fix about JSON.parse...

from strider-github.

niallo commented on May 27, 2024

Latest HEAD of strider-github is now on npm as v1.2.2. But you can confirm that there is still an issue with Github web hooks?

from strider-github.

oliversalzburg commented on May 27, 2024

@niallo Our setup seems to work fine now. I think the problem I was seeing is only related to that initial ping sent by GitHub when the webhook is set up.

from strider-github.