stonelasley / barcode-parsing Goto Github PK

Could I create a PR to optionally turn off the console output for reader initialization here? Would there be a preferred method for turning it off?

Options that I can think of off the top of my head:

• check a node env variable like NODE_ENV === "development" or something similar
• Add it as an option for the IParserConfiguration

Thoughts?

Style is pretty bad throughout.

Could you please add the following Application Identifier for GS1-128? Thanks. I would be willing to add it myself and create a PR if guided.

Source: https://www.gs1.org/standards/barcodes/application-identifiers/7007

    // AI   DESCRIPTION                             FORMAT    DATA TITLE   FNC1?     REGEX
    // ---- --------------------------------------- --------- ------------ --------- ------------------------------------------------------------------------
    // 7007 Harvest date                            N4+N6..12 HARVEST DATE Yes       ^7007(\d{6,12})$
    // ---- --------------------------------------- --------- ------------ --------- ------------------------------------------------------------------------

Hi, It looks like there is some type clashing going on.
This symbology returns a string[] as opposed to the Code39 or ITFnn style symbology types.
If it is included in the same BarcodeParser object creation then the compile step fails for me.

I am actually trying to use the GS1_128 symbology & this symbology fails to derive a valid reader configuration when the constructor is called.
I cannot determine whether I can pass in an explicit readConfiguration object in the constructor parameter to overcome this, or whether the problem lies in the the way that the constructor is deriving the valid reader list.
At the point the readerConfigurations are being filtered in BarcodeParser.initReaders() the configuration list is empty.
However, I can't see a suitable readerConfiguration object to instantiate & pass in - that makes it look like more of an output parameter?
At the minute I am picking through the code39 test class to see if I learn anything from that to apply instead.

in response to the Pr to add a missing AI and the realization that I'm missing a handful. It would be nice to have a feature that allows the consuming application to specify an AI either because it's missing or even a custom AI that isn't part of the spec.

The typing is confused and probably needs an overhaul. I'd like to make better use of interfaces. This will be a large refactor but I'm hopeful that the initial introduction can be backwards compatible.

some notes while they are fresh

• move interfaces into types directory, and I think remove "models" , I think it's inappropriate here.
• move ai list into pure JSON file.
• path aliases maybe

🚨 The automated release from the master branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you can benefit from your bug fixes and new features again.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can fix this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here are some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

No npm token specified.

An npm token must be created and set in the NPM_TOKEN environment variable on your CI environment.

Please make sure to create an npm token and to set it in the NPM_TOKEN environment variable on your CI environment. The token must allow to publish to the registry https://registry.npmjs.org/.

Good luck with your project ✨

Your semantic-release bot 📦🚀