The dblock from stonehqs

dblock's People

Contributors

Stargazers

Watchers

dblock's Issues

there may be some problems when retrying

when i run your program,there are incorrect records on field "browse_count" in my databases,

so i think there might be some wrong in RetryAspect.java:

@Around("retryOnFailure()") //around can be execute before and after the point
public Object doConcurrentOperation(ProceedingJoinPoint pjp) throws Throwable {
	int attempts = 0;
	do {
		attempts++;
		try {
			pjp.proceed();
		} catch (Exception e) {
			if(e instanceof ObjectOptimisticLockingFailureException ||
					e instanceof StaleObjectStateException) {
				log.info("retrying....times:{}", attempts);
				if(attempts > MAX_RETRY_TIMES) {
					log.info("retry excceed the max times..");
					throw e;
				}
			}

		}
	} while (attempts < MAX_RETRY_TIMES);
	return  null;
}

i thought it should be return null; behind pjp.proceed();

so there is my code:

@Around("retryOnFailure()") //around can be execute before and after the point
public Object doConcurrentOperation(ProceedingJoinPoint pjp) throws Throwable {
	int attempts = 0;
	do {
		attempts++;
		try {
			pjp.proceed();
			return null;
		} catch (Exception e) {
			if(e instanceof ObjectOptimisticLockingFailureException ||
					e instanceof StaleObjectStateException) {
				log.info("retrying....times:{}", attempts);
				if(attempts > MAX_RETRY_TIMES) {
					log.info("retry excceed the max times..");
					throw e;
				}
			}
		}
	} while (attempts < MAX_RETRY_TIMES);
	return  null;
}