stonecypher / flocks.js Goto Github PK

see StoneCypher/sc-eslint#1

Lock and unlock are cool.

There should be a reject, to throw away all changes since a lock began, to establish full transactionality.

Here's some example code: https://github.com/acrispino/flockstest

Everything works as expected in Firefox. On Chrome, the calling Flocks.create fails:

flocks.jsx:69 Flocks2 [1] Flocks2 root creation begins
flocks.jsx:69 Flocks2 [2]  - Flocks2 engaging auto-context
flocks.jsx:143 Uncaught TypeError: Converting circular structure to JSON

The issue seems to be that the flocks context contains a copy of the config object, which contains a reference to the target element for the root component. In Chrome, this causes the call to JSON.stringify to fail.

Firefox and IE9+ seem to serialize elements as objects without any of the DOM properties. IE8 returns undefined.

Arguably implements #9 in its wake

Idea taken from cortex. Provided by @unclecheese (thanks).

this is not desirable

http://kent.doddsfamily.us/genie/

Thanks for the idea, @jeffscottward

sigh

If the render target is null, don't bother rendering. Useful for detatching and for testing.

@glenjamin recommends to move the library off of window into a global, to make referring to it more convenient. I agree, and will do so.

sc-eslint and gulp-strip-react-dom-comment don't seem to be necessary to actually run flocks.

This would allow npm users to not install sc-eslint, gulp-strip-react-dom-comment, and their dependencies to use flocks. This probably affects me more than others because I prefer to vendor my node_modules.

Related, I feel that react should be a dependency or peerDependency.

this should not be

something is le wrongue

Let's make it flocks instead of flocksjs2, and the mixin plumbing instead of member