stoewer / go-strcase Goto Github PK

Hi! I found a small bug in UpperCamelCase/LowerCamelCase conversion functions when they are applied on a string "XRequestId". The second letter (R) is not capitalized after conversion. Here is a code to reproduce:

package main

import (
	"fmt"
	"github.com/stoewer/go-strcase"
)

func main() {
	fmt.Println(strcase.UpperCamelCase("XRequestId"))
	fmt.Println(strcase.LowerCamelCase("XRequestId"))
}

Expected output:

XRequestId
xRequestId

What I actually got:

XrequestId
xrequestId

If I convert a upper camel string to lower camel, it loses fidelity.

TLDR: strcase.LowerCamelCase("FooBarBaz") returns foobarbaz, when it should return fooBarBaz.

I can work around it by doing strcase.LowerCamelCase(strcase.SnakeCase("FooBarBaz")). (The fix might literally be for the LowerCamelCase method, and potentially others, to do the same thing.)

Reproduction case: https://play.golang.org/p/i5dgNRhEQ75

Use go 1.11 modules to manage test dependencies and adjust .travis.yml accordingly.

It's used for a couple asserts that could be a simple ==, but it gets installed, with its own dependencies, for every user of go-strcase.