stevieb9 / berrybrew Goto Github PK

... and remove the image

I get an error trying to call config from a non-admin command prompt. Since manipulating the path probably requires elevated privileges, it probably should always check and warn if not run with correct privileges.

C:\berrybrew\bin>berrybrew.exe config

This is berrybrew, version
1.04

Would you like to add berrybrew to your user PATH? y/n [n]

y

Unhandled Exception: System.UnauthorizedAccessException: Access to the registry key 'HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment' is denied.
at Microsoft.Win32.RegistryKey.Win32Error(Int32 errorCode, String str)
at Microsoft.Win32.RegistryKey.CreateSubKeyInternal(String subkey, RegistryKeyPermissionCheck permissionCheck, Object registrySecurityObj, RegistryOptions registryOptions)
at Microsoft.Win32.RegistryKey.CreateSubKey(String subkey, RegistryKeyPermissionCheck permissionCheck)
at BerryBrew.Berrybrew.PathSet(List`1 path)
at BerryBrew.Berrybrew.Config()
at BBConsole.bbconsole.Main(String[] args)

See dnmfarrell/berrybrew#21

When berrybrew edits the PATH during a 'config' or 'switch', it expands any %VARIABLE% in the PATH and writes them back hardcoded.

For example, my original PATH had

...;%VARTHATCHANGES%\bin;...

but after running 'config' or 'switch', it became

...;c:\expanded\version\bin;...

However, I sometimes need to change %VARTHATCHANGES%: with the hardcoded PATH, new instances no longer follow the change in %VARTHATCHANGES%.

My guess is that the C# Environment.GetEnvironmentVariable() is evaluating all the sub-variables inside the PATH when it reads it, and I can understand why that would often be a nice feature. But I don't know if there's a way to override that behavior to get at the raw value of the PATH. (I know that the Windows Scripting Host WScript.Shell's WshEnvironment object does not expand the internal variables when reading a PATH, but I don't know if there's a way to tell the C# interface to not do the internal expansion.

Unfortunately, unless this gets fixed, I won't be able to use berrybrew.

• PathRemoveBerrybrew()
• Unconfig()
• CheckInstallDir()

leave config behind for backwards compatibility reasons

berrybrew register instance_name.

Possibly provide the option to a user if an orphan is found to auto-register it.

• will likely need to change it to use Machine env
• need to ensure that the proper perl is being called with exec

Strawberry perl also has a PDL edition. It would be good if that were listed as well for the 5.24.1 and 5.22.3 versions.

(There are currently 5.24.0 and 5.22.2 PDL editions available, so this will be consistent with the previous releases).

Thanks,
Shawn.

• update SYNOPSIS with more recent Perls
• add unconfig to the main menu and docs

http://stackoverflow.com/questions/1387769/create-registry-entry-to-associate-file-extension-with-application-in-c

Would really prefer it if we could remove Administrator requirement entirely

• root dir in %USERPROFILE%
• all %PATH% changes in User target
• need admin privileges to remove Strawberry/ActiveState from Machine PATH

• remove berrybrew path from PATH
• in "berrybrew available", add a line that shows that an external perl is the one currently being used
• update README
• update help with new command
• configure system path (see 1st comment)
• remove PATH warning if perl already is in path

I download berrybrew.zip, but berrybrew.zip contains only data directory.

After I have downloaded berrybrewand run bin\berrybrew config, I got this message:

WARNING! orphaned perl installations:

  bin

  data

What does it mean? Before the brerrybrew download, I uninstalled the strawberry perl 5.18.0 my labtop had.

Save the extracted instance in a storage directory, so on subsequent removal/reinstall of an instance, we can just copy the stored pristine instance dir into the perls directory.

The configuration command throws an error when the target folder does not exist. See error log below.

Creating the folder manually makes things work as expected.

Thanks,
Shawn.

C:\git\berrybrew>bin\berrybrew.exe config

This is berrybrew, version
1.04


Would you like to add berrybrew to PATH? y/n [n]

y

berrybrew was successfully added to PATH, start a new terminal to use it.


Unhandled Exception: System.IO.DirectoryNotFoundException: Could not find a part of the path 'C:\berrybrew'.
   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.IO.FileSystemEnumerableIterator`1.CommonInit()
   at System.IO.FileSystemEnumerableIterator`1..ctor(String path, String originalUserPath, String searchPattern, SearchOption searchOption, SearchResultHandler`1 resultHandler, Boolean checkHost)
   at System.IO.Directory.GetDirectories(String path)
   at BerryBrew.Berrybrew.PerlFindOrphans()
   at BerryBrew.Berrybrew.Finalize()

This will allow us to use the file directly, and not have to translate it into a custom JSON file.

I installed the zip version of berrybrew on my windows 10 machine. I made the mistake of installing it into c:\berrybrew so I moved it to a different location and removed the setting in the path env var. Well now berrybrew will not run. I keep getting this error.

Unhandled Exception: System.IO.DirectoryNotFoundException: Could not find a part of the path 'C:\berrybrew\data\config.json'.
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.StreamReader..ctor(String path, Encoding encoding, Boolean detectEncodingFromByteOrderMarks, Int32 bufferSize, Boolean checkHost)
at System.IO.StreamReader..ctor(String path)
at BerryBrew.Berrybrew.JsonParse(String type, Boolean raw)
at BerryBrew.Berrybrew..ctor()
at BBConsole.bbconsole.Main(String[] args)

C:\bin\berrybrew>

I've tried deleting everything and reloading, checked the path variable to make sure it was not set with berrybrew and it still insists on looking for c:\berrybrew\data\config.json

Is there some other file in perhaps the AppData dir?

Attempting to install 5.22.2_32, and encountered the following error:

PS C:berrybrew> berrybrew install 5.22.2_32
Downloading http://strawberryperl.com/download/5.22.2.1/strawberry-perl-5.22.2.1-32bit.zip to C:\berrybrew\installed\temp\strawberry-perl-5.22.2.1-32bit.zip
Confirming checksum ...
Error checksum of downloaded archive
C:\berrybrew\installed\temp\strawberry-perl-5.22.2.1-32bit.zip
does not match expected output
expected: 6c750c56a4eccf3b5f77af56e4cee572c360a1c2
     got: 804a0dff0a3e4a9b3ac37c4495894467cccd35ec
Whould you like berrybrew to delete the corrupted download file? y/n [n]
PS C:\berrybrew> berrybrew install 5.22.2_32
Confirming checksum ...
Error checksum of downloaded archive

When I checked the Strawberry Perl website (http://strawberryperl.com/releases.html), I found both checksums. When I examined the links, I found that the URL for 804a0dff0a3e4a9b3ac37c4495894467cccd35ec checksum referred to the file strawberry-perl-5.22.2.1-32bit.zip, while the 6c750c56a4eccf3b5f77af56e4cee572c360a1c2 checksum referred to the file strawberry-perl-5.22.2.1-32bit-portable.zip. Examining data\perls.json, I found that the section for 5.22.2_32 points to the -32bit.zip file, rather than the -32bit-portable.zip file (as all other _32 sections except those for PDL version).

[
    {
        "name" : "5.22.2_32",
        "file" : "strawberry-perl-5.22.2.1-32bit.zip",
        "url"  : "http://strawberryperl.com/download/5.22.2.1/strawberry-perl-5.22.2.1-32bit.zip",
        "ver"  : "5.22.2",
        "csum" : "6c750c56a4eccf3b5f77af56e4cee572c360a1c2"
    },
]

My instance of Berrybrew was installed from a file downloaded from this site using this link as a .zip file on 2016-10-29, with size of 522,925 bytes, and an sha1sum of d27f906e868c7fd7d320f4149d908248e867e53a.

Also, (possibly a simplistic question, but) is it possible to re-attempt an install without having to re-download the file again (for example, if you downloaded it via a different method)?

• ExecCompile() hands off
• Exec() performs a task on one perl only

check other docs to ensure there's no ambiguity

as it is, we interfere with the in-use stuff and that's really becoming a problem.

Need to really think this through

eg: berrybrew exec -h

Nitpick: the most recent messages.json says version 1.04, despite everything else claiming you're at version 1.05. :-)

...we don't need them in these files

Currently, we only allow ver,ver,ver etc, with no space. Need to make the regex more resilient, and add exception handling

the prod version gets overwritten