steveworkman / grunt-yslow-test Goto Github PK

Hello,

I had a hell of a job getting this to work for a server not started within node, but eventually figured it out and here's my solution. Could be a valuable addition to the docs? http://stackoverflow.com/questions/19787805/using-grunt-and-phantomjs-with-a-jetty-server/19794250#19794250 (although this example is for jetty it should work regardless of what the server's running on)

It would appear that grunt-yslow uses the files API to set URLs, rather than placing them in options. Maybe that's a more intuitive signature than requiring an empty files array? Thanks!

Digging the task! I would love to see it fail if the threshold parameter is not met, though. It would be great for enforcing certain criteria are met in order for the project to build.

Example:

        yslow_test: {
            options: {
            info: "grade",
            format: "json",
            urls: ['http://google.com'],
            reports: ['test/reports/yslow.json'],
            threshold: 90
        },

If the YSlow score wasn't above 90, the task would log an error and the build would fail. This could get very helpful when thresholds were set for specific tests using JSON objects as described here: http://yslow.org/phantomjs/.