steventhuriot / dinnertime Goto Github PK

• When loading website
• When loading menu

• Account removal functionality
• Company removal functionality for leaders

When you get redirected to company select, you should go back to where you came from

Let's store our secrets in there, shall we. 😄

Easy to fix by prefixing the company trigger with

SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;

• set width on menu tiles on the employee's page
• white background on menu + black text ( Make configurable later? )
• remove "menu" title from navigation bar
• blue colors should be pink
• top bar should be 1 color
• hamburger should be completely on the right
• sign up button in pink
• remove pink lines on home page
• remove colors from page titles
• show selected company on admin page
• move home page logo so it's not in the center
• fix transfer leadership (dropdown has a scrollbar)
• Leader + officer --> explain in a short sentence what they are or do

Instead of just showing the highest level
Also show companies in menu instead of profile

It would also be far better to remove the tabs from the menu management page and place them as submenu items

Post a message on service bus and handle CSV async instead of doing it during the first call

Split admin section into lazy loading module to save some loading times on the default page

https://angular.io/guide/lazy-loading-ngmodules

Create a sample CSV and hook it up to the link placeholder on the upload-menu screen.

When you get redirected to company select, you should go back to where you came from

Add some info, links for login/signup

Cover should be 100vh so you scroll down for the info

When you only have one company assigned, skip the company selection screen and auto redirect instead.

Allow users to reset their passwords

Cause you might still have employee subs you want to manage.

Add a popup overlay when clicking it instead of navigating to your profile.

Move :

• the language picker
• sign out
• Something else?

Navigate admin section, then sign out, then sign in again. Observables trigger with the incorrect company id

Replace with new Error class that will set the correct http codes for us.

Also map EF errors:

// <seealso href="https://docs.microsoft.com/en-us/sql/relational-databases/errors-events/database-engine-events-and-errors"/>
public enum SqlErrorNumber
{
	ConstraintViolation = 547,
	UniqueIndexViolation = 2601,
	DuplicateKeyViolation = 2627
}

public static bool IsSqlError(this DbUpdateException dbUpdateException, SqlErrorNumber sqlErrorNumber)
{
	return (dbUpdateException?.InnerException) switch
	{
		SqlException msSqlException => msSqlException.IsSqlError(sqlErrorNumber),
		_ => false
	};
}

public static bool IsSqlError(this SqlException sqlException, SqlErrorNumber sqlErrorNumber)
{
	return sqlException?.Number == (int)sqlErrorNumber;
}

Allow marking a company as private, meaning you can only see the menu while logged in with a token that has access to the company (e.g. you're a member, officer or leader)

Only the company admin and officers can remove you from a company today. Allow leaving by your own choice.

This should also remove all your user roles in case you're not just a regular member.
Leaders can't leave, they should get a message to transfer leadership first.

• Create categories inline
• Create menus inline
• fill in the correct ids after creating a new line
• Invite users inline
• Transfer leadership without a dialog or try to figure out why PrimeNG 10 is causing a navigation on dialogreference.close();
• Add floatlabels to input fields

Some catchError pipes aren't written the correct way, breaking the pipes. Rewrite them so they pipe on the requests

• Google
• Facebook
• LinkedIn

Report bug link that links to this Repo

manage name, etc

You can click it multiple times

Menu and category creation
CSV upload as well (or maybe do it based on file title?)

Allow a company to upload their own background.

• Probably best to limit to 1 picture/video.
• Max size, 3mb?

Add an "I agree with usage rights" + a page that lists them